Re: [FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

2024-11-16 Thread Rémi Denis-Courmont
Le lauantaina 16. marraskuuta 2024, 16.39.29 EET James Almer a écrit : > > This a large proportion of values to underflow or overflow out of the int > > range. The C version then triggers Undefined Behaviour in that case by > > negating INT_MIN, so I don't suppose that that's correct. > > So is th

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

2024-11-16 Thread James Almer
On 11/16/2024 11:50 AM, Rémi Denis-Courmont wrote: Le lauantaina 16. marraskuuta 2024, 16.39.29 EET James Almer a écrit : This a large proportion of values to underflow or overflow out of the int range. The C version then triggers Undefined Behaviour in that case by negating INT_MIN, so I don't

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

2024-11-16 Thread James Almer
On 11/16/2024 4:50 AM, Rémi Denis-Courmont wrote: Le perjantaina 15. marraskuuta 2024, 22.41.20 EET James Almer a écrit : Without this, the tables will be zero and the tests completely useless. Signed-off-by: James Almer --- tests/checkasm/aacencdsp.c | 1 + 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

2024-11-15 Thread Rémi Denis-Courmont
Le perjantaina 15. marraskuuta 2024, 22.41.20 EET James Almer a écrit : > Without this, the tables will be zero and the tests completely useless. > > Signed-off-by: James Almer > --- > tests/checkasm/aacencdsp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/checkasm/aacencdsp.c

[FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

2024-11-15 Thread James Almer
Without this, the tables will be zero and the tests completely useless. Signed-off-by: James Almer --- tests/checkasm/aacencdsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/checkasm/aacencdsp.c b/tests/checkasm/aacencdsp.c index 5308a2ac03..d53a04c532 100644 --- a/tests/checkasm/a