Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-06-04 Thread Michael Niedermayer
Servus Manuel On Wed, Jun 04, 2025 at 10:06:28PM +0200, Manuel Lauss wrote: > Servus Michael, > > On Wed, Jun 4, 2025 at 1:00 PM Michael Niedermayer > wrote: > > > > On Tue, Jun 03, 2025 at 12:30:40PM +0200, Manuel Lauss wrote: > > > Servus Michael, > > > > > > On Sat, May 31, 2025 at 12:51 AM M

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-06-04 Thread Manuel Lauss
Servus Michael, On Wed, Jun 4, 2025 at 1:00 PM Michael Niedermayer wrote: > > On Tue, Jun 03, 2025 at 12:30:40PM +0200, Manuel Lauss wrote: > > Servus Michael, > > > > On Sat, May 31, 2025 at 12:51 AM Michael Niedermayer > > wrote: > > > > > > > > /* smooth top and left block border

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-06-04 Thread Michael Niedermayer
On Tue, Jun 03, 2025 at 12:30:40PM +0200, Manuel Lauss wrote: > Servus Michael, > > On Sat, May 31, 2025 at 12:51 AM Michael Niedermayer > wrote: > > > > > > /* smooth top and left block borders with neighbours */ > > > > > -if (((pxoff - p + k) < 0) || ((pxoff - p + k)

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-06-03 Thread Manuel Lauss
Servus Michael, On Sat, May 31, 2025 at 12:51 AM Michael Niedermayer wrote: > > > > /* smooth top and left block borders with neighbours */ > > > > -if (((pxoff - p + k) < 0) || ((pxoff - p + k) >= maxpxo) > > > > +if (((pxoff - p + 0) < 0) || ((pxoff - p + k

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-05-30 Thread Michael Niedermayer
Hi Manuel On Fri, May 30, 2025 at 10:54:01PM +0200, Manuel Lauss wrote: > Hi Michael, > > On Fri, May 30, 2025 at 9:52 PM Michael Niedermayer > wrote: > > > > Hi Manual > > > > On Wed, May 14, 2025 at 03:39:53AM +0200, Michael Niedermayer wrote: > > > k is always 4 here and it seems this is not

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-05-30 Thread Manuel Lauss
Hi Michael, On Fri, May 30, 2025 at 9:52 PM Michael Niedermayer wrote: > > Hi Manual > > On Wed, May 14, 2025 at 03:39:53AM +0200, Michael Niedermayer wrote: > > k is always 4 here and it seems this is not what was intended > > replacing it with 0 works but it may be wrong > > > > This needs revi

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-05-30 Thread Michael Niedermayer
Hi Manual On Wed, May 14, 2025 at 03:39:53AM +0200, Michael Niedermayer wrote: > k is always 4 here and it seems this is not what was intended > replacing it with 0 works but it may be wrong > > This needs review > > Fixes: out of array read > Fixes: > 409593384/clusterfuzz-testcase-minimized-f

[FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

2025-05-13 Thread Michael Niedermayer
k is always 4 here and it seems this is not what was intended replacing it with 0 works but it may be wrong This needs review Fixes: out of array read Fixes: 409593384/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SANM_fuzzer-6488251907244032 Found-by: continuous fuzzing process https://gi