On Sun, Sep 21, 2014 at 07:43:39PM +0200, Nicolas George wrote:
> Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> > One case that might break is when used as a callback. That's very unlikely
> > to happen, but it's still a change in the public API. You might get some
> > rainbow colo
Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> One case that might break is when used as a callback. That's very unlikely
> to happen, but it's still a change in the public API. You might get some
> rainbow colors from http://upstream-tracker.org/ typically.
All right, but only mic
On Sun, Sep 21, 2014 at 07:36:19PM +0200, Nicolas George wrote:
> Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> > Doesn't this need at least a minor bump?
>
> I consider it a bug fix, not an API change. Can you imagine a case where
> people would need to check for it?
>
One case
Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> Doesn't this need at least a minor bump?
I consider it a bug fix, not an API change. Can you imagine a case where
people would need to check for it?
> Not really; in SAMI at least the buffer is allocated only once, and
> finalized onl
On Sun, Sep 21, 2014 at 07:19:43PM +0200, Nicolas George wrote:
> Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> > So I did that and pushed that part of the patchset, adjusted to use a
> > bprint helper.
> >
> > Unfortunately, this raises a warning because av_bprint_is_complete()
>
Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> So I did that and pushed that part of the patchset, adjusted to use a
> bprint helper.
>
> Unfortunately, this raises a warning because av_bprint_is_complete()
> doesn't take a const parameter. I was too lazy to actually fix the API,
>
On Sun, Sep 21, 2014 at 11:20:26AM +0200, Nicolas George wrote:
> Le jour de la Raison, an CCXXII, Clément Bœsch a écrit :
> > ---
> > libavcodec/webvttdec.c | 10 --
> > 1 file changed, 8 insertions(+), 2 deletions(-)
>
> Patches 5-10 look right, except most of them could benefit from th
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit :
> ---
> libavcodec/webvttdec.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
Patches 5-10 look right, except most of them could benefit from the
factorization.
Regards,
--
Nicolas George
___
---
libavcodec/webvttdec.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c
index 6b86bed..411abf0 100644
--- a/libavcodec/webvttdec.c
+++ b/libavcodec/webvttdec.c
@@ -74,6 +74,7 @@ static int webvtt_event_to_ass(AVBPrin
