Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2017-01-06 Thread Andreas Cadhalpun
On 15.12.2016 01:53, Andreas Cadhalpun wrote: > On 14.12.2016 11:16, Moritz Barsnick wrote: >> On Wed, Dec 14, 2016 at 01:02:41 +0100, Andreas Cadhalpun wrote: >>> On 13.12.2016 08:11, Paul B Mahol wrote: > -st->codecpar->bit_rate= samplerate * framesize * 8 / 2048; > +s

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-14 Thread Andreas Cadhalpun
On 14.12.2016 11:16, Moritz Barsnick wrote: > On Wed, Dec 14, 2016 at 01:02:41 +0100, Andreas Cadhalpun wrote: >> On 13.12.2016 08:11, Paul B Mahol wrote: -st->codecpar->bit_rate= samplerate * framesize * 8 / 2048; +st->codecpar->bit_rate= samplerate * framesize /

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-14 Thread Hendrik Leppkes
On Wed, Dec 14, 2016 at 1:02 AM, Andreas Cadhalpun wrote: > On 13.12.2016 08:11, Paul B Mahol wrote: >> On 12/13/16, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/omadec.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-14 Thread Moritz Barsnick
On Wed, Dec 14, 2016 at 01:02:41 +0100, Andreas Cadhalpun wrote: > On 13.12.2016 08:11, Paul B Mahol wrote: > >> -st->codecpar->bit_rate= samplerate * framesize * 8 / 2048; > >> +st->codecpar->bit_rate= samplerate * framesize / 256; > > Why multiply with 8 when dividing by

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-13 Thread Paul B Mahol
On 12/14/16, Andreas Cadhalpun wrote: > On 13.12.2016 08:11, Paul B Mahol wrote: >> On 12/13/16, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/omadec.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavformat/omadec.c

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-13 Thread Andreas Cadhalpun
On 13.12.2016 08:11, Paul B Mahol wrote: > On 12/13/16, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/omadec.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/omadec.c b/libavformat/omadec.c >> index 6e476db..e7751d

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-12 Thread Paul B Mahol
On 12/13/16, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/omadec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/omadec.c b/libavformat/omadec.c > index 6e476db..e7751d0 100644 > --- a/libavformat/omadec.c > +++ b/liba

[FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-12 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavformat/omadec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/omadec.c b/libavformat/omadec.c index 6e476db..e7751d0 100644 --- a/libavformat/omadec.c +++ b/libavformat/omadec.c @@ -365,7 +365,7 @@ static int oma_read