On Wed, Jul 22, 2015 at 6:18 AM, Nedeljko Babic
wrote:
>>On Mon, Jul 20, 2015 at 8:50 AM, Nedeljko Babic
>> wrote:
This commit moves the tables required for encoding and decoding
LTP and TNS AAC files out of the decoder's standalone tables file
and into the shared aactab.h, where they
>On Mon, Jul 20, 2015 at 8:50 AM, Nedeljko Babic
> wrote:
>>>This commit moves the tables required for encoding and decoding
>>>LTP and TNS AAC files out of the decoder's standalone tables file
>>>and into the shared aactab.h, where they can be used by both the
>>>encoder and the decoder.
>>>
>>>Th
On Mon, Jul 20, 2015 at 8:50 AM, Nedeljko Babic
wrote:
>>This commit moves the tables required for encoding and decoding
>>LTP and TNS AAC files out of the decoder's standalone tables file
>>and into the shared aactab.h, where they can be used by both the
>>encoder and the decoder.
>>
>>This commi
On Mon, Jul 20, 2015 at 4:15 PM, Rostislav Pehlivanov
wrote:
> Yep, with this patch compute_lpc_coefs() (referenced in aacdec_template.c
> when applying TNS) in ltp.c prints a warning when compiling the fixed
> decoder, which is fine since it changed a type from INTFLOAT to float.
>
>>And it will
Yep, with this patch compute_lpc_coefs() (referenced in aacdec_template.c
when applying TNS) in ltp.c prints a warning when compiling the fixed
decoder, which is fine since it changed a type from INTFLOAT to float.
>And it will probably be accepted first anyhow :)
I'm fine either way too, it's not
>Thanks for your response.
>If you are okay with it then it would make sense to push this patch to
>master first then because you have to rebase aactab.* to INTFLOATs anyway.
>
I am ok with that.
As I said, I don't have a problem to make necessary changes to my patch set if
this patch is accepted
Thanks for your response.
If you are okay with it then it would make sense to push this patch to
master first then because you have to rebase aactab.* to INTFLOATs anyway.
Could you consider moving ltp.c into the aacdec_template.c file? It's
relatively short (compared to the decoder source) and it
>This commit moves the tables required for encoding and decoding
>LTP and TNS AAC files out of the decoder's standalone tables file
>and into the shared aactab.h, where they can be used by both the
>encoder and the decoder.
>
>This commit does not break the already-broken aac_fixed decoder.
Not su
This commit moves the tables required for encoding and decoding
LTP and TNS AAC files out of the decoder's standalone tables file
and into the shared aactab.h, where they can be used by both the
encoder and the decoder.
This commit does not break the already-broken aac_fixed decoder.
All of the va