Thanks for your response. If you are okay with it then it would make sense to push this patch to master first then because you have to rebase aactab.* to INTFLOATs anyway.
Could you consider moving ltp.c into the aacdec_template.c file? It's relatively short (compared to the decoder source) and it's only used a single time in the entire libavcodec by the aac decoder? Perhaps you can just inline the whole function in the decoder. When compiling aacdec_fixed it prints a warning saying it expects float * rather than an INTFLOAT *. On 20 July 2015 at 12:50, Nedeljko Babic <nedeljko.ba...@imgtec.com> wrote: > >This commit moves the tables required for encoding and decoding > >LTP and TNS AAC files out of the decoder's standalone tables file > >and into the shared aactab.h, where they can be used by both the > >encoder and the decoder. > > > >This commit does not break the already-broken aac_fixed decoder. > > Not sure I would say that it is broken, since it is not implemented fully > yet... > > >All of the values in aactab.* are untouched by the INTFLOAT type > >and this commit stays true to this by keeping all of the values > >as floats. This will give a heads-up to the aac_fixed maintainers > >to either keep the file as-is or to use INTFLOATS, depending on > >their choice as long as they don't break the encoder. > > If this patch enters FFmpeg before rest of implementation of fixed point > aac > decoder, I will do necessary rebase. > > If the implementation of fixed point decoder enters first, I think that > this > patch needs to be rebased, since it will break the decoder (for real this > time) > and there would be unneeded additional patch to fix this. > > Thanks, > - Nedeljko _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
