Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-22 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-08-21): >> This only works if one only works with one list without owner at a time; >> if one has several such lists at the same time and an error happens when >> working with one of these lists, one has to free the other lists. >> >> This scenario can of

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-22 Thread Nicolas George
Andreas Rheinhardt (12020-08-21): > This only works if one only works with one list without owner at a time; > if one has several such lists at the same time and an error happens when > working with one of these lists, one has to free the other lists. > > This scenario can of course usually be avo

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-21 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-08-18): >> 1. Adding this struct has also another benefit besides the ones in your >> two other patches: One can simplify the freeing process by adding a new >> ff_formatscfg_unref() (I'm not sure on the name). This could also be >> used in the uninit fun

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-20 Thread Nicolas George
Andreas Rheinhardt (12020-08-18): > 1. Adding this struct has also another benefit besides the ones in your > two other patches: One can simplify the freeing process by adding a new > ff_formatscfg_unref() (I'm not sure on the name). This could also be > used in the uninit function of the aformat f

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-18 Thread Andreas Rheinhardt
Nicolas George: > It will allow to refernce it as a whole without clunky macros. > > Most of the changes have been automatically made with sed: > > sed -i ' > s/-> *in_formats/->incfg.formats/g; > s/-> *out_formats/->outcfg.formats/g; > s/-> *in_channel_layouts/->incfg.channel_layouts/g; >

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-17 Thread Nicolas George
Nicolas George (12020-08-13): > It will allow to refernce it as a whole without clunky macros. > > Most of the changes have been automatically made with sed: > > sed -i ' > s/-> *in_formats/->incfg.formats/g; > s/-> *out_formats/->outcfg.formats/g; > s/-> *in_channel_layouts/->incfg.channel

[FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-13 Thread Nicolas George
It will allow to refernce it as a whole without clunky macros. Most of the changes have been automatically made with sed: sed -i ' s/-> *in_formats/->incfg.formats/g; s/-> *out_formats/->outcfg.formats/g; s/-> *in_channel_layouts/->incfg.channel_layouts/g; s/-> *out_channel_layouts/->outc