Nicolas George: > Andreas Rheinhardt (12020-08-21): >> This only works if one only works with one list without owner at a time; >> if one has several such lists at the same time and an error happens when >> working with one of these lists, one has to free the other lists. >> >> This scenario can of course usually be avoided by making sure that one >> only has one list without owner at any given time. I used this method in >> my patches a lot. I have also rewritten the hwdownload patch [1] to >> avoid explicit ff_formats_unref() in it. This means that >> ff_formats_unref() can become static, too. >> >> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-August/268429.html > > Well done. > >> What does "this" refer to here? If it refers to my patches, then nothing >> is missing (except a review). They can be applied at once and then they >> can also be directly backported and you can then apply your big patch on >> top of it; of course, there will be trivial conflicts in the few files >> that I touch. >> >> If "this" refers to your patches: Applying them before fixing the >> leaks/double-frees will make backporting the fixes much more troublesome. > > I meant your patch series: I have become lost in the various > submissions. Are there still patches that need review? > Basically patches 8-17 (with the exception of 10 and 13 which Paul already LGTM'ed) still need review. 17 [1] is the key patch of the whole series; you should probably look at it first to see what's wrong with the current API. The other patches are very similar and easy.
- Andreas [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-August/267595.html _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
