Re: [FFmpeg-devel] [PATCH 1/2] Extract FFV1 FATE tests to own Makefile

2015-09-02 Thread Michael Niedermayer
On Wed, Sep 02, 2015 at 07:40:18PM +0200, Peter B. wrote: > On 09/02/2015 02:53 PM, Michael Niedermayer wrote: > > the include breaks out of tree builds > > mkdir delthisdir > > cd delthisdir > > ../configure > > make -j12 > > /home/michael/ffmpeg/tests/fate/vcodec.mak:71: tests/fate/ffv1.mak: No s

Re: [FFmpeg-devel] [PATCH 1/2] Extract FFV1 FATE tests to own Makefile

2015-09-02 Thread Peter B.
On 09/02/2015 02:53 PM, Michael Niedermayer wrote: > the include breaks out of tree builds > mkdir delthisdir > cd delthisdir > ../configure > make -j12 > /home/michael/ffmpeg/tests/fate/vcodec.mak:71: tests/fate/ffv1.mak: No such > file or directory > make: *** No rule to make target `tests/fate/

Re: [FFmpeg-devel] [PATCH 1/2] Extract FFV1 FATE tests to own Makefile

2015-09-02 Thread Michael Niedermayer
On Wed, Sep 02, 2015 at 12:01:06AM +0200, Peter B. wrote: > On 09/01/2015 11:40 PM, Michael Niedermayer wrote: > >> +include tests/fate/ffv1.mak > > doesnt this belong in tests/Makefile ? > > I did so first, but then all the prerequisites set in vcodec.mak are not > applied, causing ffv1.mak to fa

Re: [FFmpeg-devel] [PATCH 1/2] Extract FFV1 FATE tests to own Makefile

2015-09-01 Thread Peter B.
On 09/01/2015 11:40 PM, Michael Niedermayer wrote: >> +include tests/fate/ffv1.mak > doesnt this belong in tests/Makefile ? I did so first, but then all the prerequisites set in vcodec.mak are not applied, causing ffv1.mak to fail. So in order to keep the modifications as little as possible, I jus

Re: [FFmpeg-devel] [PATCH 1/2] Extract FFV1 FATE tests to own Makefile

2015-09-01 Thread Michael Niedermayer
On Tue, Sep 01, 2015 at 11:27:31PM +0200, Peter B. wrote: > On 09/01/2015 09:54 PM, Peter B. wrote: > > [...] > > But actually, I think it'd be best to change the FFV1 tests to match the > > ones in "lossless-video.mak", using framecrc rather than the enc_dec > > function used in "vcodec.mak". > >

Re: [FFmpeg-devel] [PATCH 1/2] Extract FFV1 FATE tests to own Makefile

2015-09-01 Thread Peter B.
On 09/01/2015 09:54 PM, Peter B. wrote: > [...] > But actually, I think it'd be best to change the FFV1 tests to match the > ones in "lossless-video.mak", using framecrc rather than the enc_dec > function used in "vcodec.mak". > > Changing that however, makes it difficult to stick with the > auto-g