Re: [FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-09 Thread John Stebbins
On Thu, 2020-04-09 at 09:43 -0700, Philip Langdale wrote: > On Thu, 9 Apr 2020 15:09:45 + > John Stebbins wrote: > > > > > > > > I missed this review earlier. What about the indentation is > > off? Do > > you mean the indent of the function parameters does not align after > > the openin

Re: [FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-09 Thread Philip Langdale
On Thu, 9 Apr 2020 15:09:45 + John Stebbins wrote: > > > > I missed this review earlier. What about the indentation is off? Do > you mean the indent of the function parameters does not align after > the opening paren? I was keeping the lines aligned without wrapping > at 80 characters.

Re: [FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-09 Thread John Stebbins
On Mon, 2020-04-06 at 20:03 +0200, Nicolas George wrote: > John Stebbins (12020-04-06): > > A conversion from rgb to bgr is necessary > > --- > > libavcodec/movtextdec.c | 11 +++ > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/movtextdec.c b/libavcodec

Re: [FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:51:56 -0600 John Stebbins wrote: > A conversion from rgb to bgr is necessary > --- > libavcodec/movtextdec.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index c38c5edce6..05becaf64

Re: [FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-06 Thread Nicolas George
John Stebbins (12020-04-06): > A conversion from rgb to bgr is necessary > --- > libavcodec/movtextdec.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index c38c5edce6..05becaf64d 100644 > --- a/libavcodec/

[FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-06 Thread John Stebbins
A conversion from rgb to bgr is necessary --- libavcodec/movtextdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index c38c5edce6..05becaf64d 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c @@