On Thu, 2020-04-09 at 09:43 -0700, Philip Langdale wrote: > On Thu, 9 Apr 2020 15:09:45 +0000 > John Stebbins <jstebb...@jetheaddev.com> wrote: > > > > > > > > I missed this review earlier. What about the indentation is > > off? Do > > you mean the indent of the function parameters does not align after > > the opening paren? I was keeping the lines aligned without > > wrapping > > at 80 characters. > > Yes, I believe he's referring to the function parameters and not the > overall indent. I would normally align to the paren. I think you can > do > that and keep under 80 if you put each one on its own line? > >
The lines get longer in a subsequent patch (7) and do not fit without wrapping. So I would just have to undo the indent in that patch ;) I could conceivable break lines at expression operators instead of commas, but I think that would make reading more difficult. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
