Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

Ronald S. Bultje gmail.com> writes: > > > I have no idea but attached covers this case. > > > > Fine with me (although the coding style looks slightly strange). > > I agree that coding style should be changed. I believe it is more readable as it is in the patch (and is used in many places in F

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

Hi, On Tue, May 3, 2016 at 3:22 PM, wm4 wrote: > On Tue, 3 May 2016 18:29:44 +0200 > Carl Eugen Hoyos wrote: > > > On Tuesday 03 May 2016 06:11:59 pm Ronald S. Bultje wrote: > > > Hi, > > > > > > On Tue, May 3, 2016 at 11:54 AM, Carl Eugen Hoyos > wrote: > > > > On Tuesday 03 May 2016 03:04:50

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Tue, 3 May 2016 18:29:44 +0200 Carl Eugen Hoyos wrote: > On Tuesday 03 May 2016 06:11:59 pm Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 3, 2016 at 11:54 AM, Carl Eugen Hoyos wrote: > > > On Tuesday 03 May 2016 03:04:50 pm Ronald S. Bultje wrote: > > > > > +if (av_pix_f

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Tuesday 03 May 2016 06:11:59 pm Ronald S. Bultje wrote: > Hi, > > On Tue, May 3, 2016 at 11:54 AM, Carl Eugen Hoyos wrote: > > On Tuesday 03 May 2016 03:04:50 pm Ronald S. Bultje wrote: > > > > +if (av_pix_fmt_desc_get(st->codecpar->format)->flags > > > > && AV_PIX_FMT_FLAG_ALPH

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

Hi, On Tue, May 3, 2016 at 11:54 AM, Carl Eugen Hoyos wrote: > On Tuesday 03 May 2016 03:04:50 pm Ronald S. Bultje wrote: > > > > +if (av_pix_fmt_desc_get(st->codecpar->format)->flags > && > > > AV_PIX_FMT_FLAG_ALPHA) > > > I think you want s/&&/&/? > > Definitely, new patch atta

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Tuesday 03 May 2016 03:04:50 pm Ronald S. Bultje wrote: > > +if (av_pix_fmt_desc_get(st->codecpar->format)->flags && > > AV_PIX_FMT_FLAG_ALPHA) > I think you want s/&&/&/? Definitely, new patch attached. Thank you, Carl Eugen From 359b2b5a46d8274ac66f9c47a88e2ead25f7479c Mon

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

Hi, On Tue, May 3, 2016 at 4:18 AM, Carl Eugen Hoyos wrote: > On Monday 02 May 2016 08:57:31 pm wm4 wrote: > > On Mon, 2 May 2016 08:36:16 -0400 > > > > "Ronald S. Bultje" wrote: > > > Hi, > > > > > > On Mon, May 2, 2016 at 5:49 AM, Carl Eugen Hoyos > wrote: > > > > On Wednesday 13 April 2016

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Monday 02 May 2016 08:57:31 pm wm4 wrote: > On Mon, 2 May 2016 08:36:16 -0400 > > "Ronald S. Bultje" wrote: > > Hi, > > > > On Mon, May 2, 2016 at 5:49 AM, Carl Eugen Hoyos wrote: > > > On Wednesday 13 April 2016 10:27:03 am you wrote: > > > > Maybe it should just check whether the pixel forma

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Mon, 2 May 2016 08:36:16 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Mon, May 2, 2016 at 5:49 AM, Carl Eugen Hoyos wrote: > > > On Wednesday 13 April 2016 10:27:03 am you wrote: > > > Maybe it should just check whether the pixel format is alpha, instead > > > of whether it's not yuv420p.

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

Hi, On Mon, May 2, 2016 at 5:49 AM, Carl Eugen Hoyos wrote: > On Wednesday 13 April 2016 10:27:03 am you wrote: > > Maybe it should just check whether the pixel format is alpha, instead > > of whether it's not yuv420p. (Just a suggestion.) > > Isn't that exactly equivalent to what my patch is do

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On 5/2/16, Carl Eugen Hoyos wrote: > On Wednesday 13 April 2016 10:27:03 am you wrote: >> On Tue, 12 Apr 2016 19:53:13 + (UTC) >> >> Carl Eugen Hoyos wrote: >> > wm4 googlemail.com> writes: >> > > > -flags |= 2 + 16; >> > > > +flags |= 2; >> > > > +

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Wednesday 13 April 2016 10:27:03 am you wrote: > On Tue, 12 Apr 2016 19:53:13 + (UTC) > > Carl Eugen Hoyos wrote: > > wm4 googlemail.com> writes: > > > > -flags |= 2 + 16; > > > > +flags |= 2; > > > > +if (st->codecpar->format != AV_PIX_FMT_Y

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Tue, 12 Apr 2016 19:53:13 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > -flags |= 2 + 16; > > > +flags |= 2; > > > +if (st->codecpar->format != AV_PIX_FMT_YUV420P) > > > +flags |= 16; // stream ma

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

wm4 googlemail.com> writes: > > -flags |= 2 + 16; > > +flags |= 2; > > +if (st->codecpar->format != AV_PIX_FMT_YUV420P) > > +flags |= 16; // stream may contain transparency > > information > The pixel format shouldn't be requir

Re: [FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

On Tue, 12 Apr 2016 21:32:43 +0200 Carl Eugen Hoyos wrote: > diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c > index 2e0147c..38183ff 100644 > --- a/libavformat/webpenc.c > +++ b/libavformat/webpenc.c > @@ -107,7 +107,9 @@ static int flush(AVFormatContext *s, int trailer, int64_t > pt

[FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

Hi! Attached patch may fix ticket #5431. Please review, Carl Eugen diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c index 2e0147c..38183ff 100644 --- a/libavformat/webpenc.c +++ b/libavformat/webpenc.c @@ -107,7 +107,9 @@ static int flush(AVFormatContext *s, int trailer, int64_t pts)