On Tue, 3 May 2016 18:29:44 +0200
Carl Eugen Hoyos <ceho...@ag.or.at> wrote:

> On Tuesday 03 May 2016 06:11:59 pm Ronald S. Bultje wrote:
> > Hi,
> >
> > On Tue, May 3, 2016 at 11:54 AM, Carl Eugen Hoyos <ceho...@ag.or.at> wrote:
> > > On Tuesday 03 May 2016 03:04:50 pm Ronald S. Bultje wrote:
> > > > > +                if (av_pix_fmt_desc_get(st->codecpar->format)->flags
> > > > > && AV_PIX_FMT_FLAG_ALPHA)
> > > >
> > > > I think you want s/&&/&/?
> > >
> > > Definitely, new patch attached.
> >
> > So, to address wm4's other concern, are there cases where
> > st->codecpar->format is not set? E.g. codec copy or so?

Just seems questionable that API users which mux and don't use most of
ffmpeg's infrastructure directly would set the pixfmt for non-raw
formats at all.

> I have no idea but attached covers this case.

Fine with me (although the coding style looks slightly strange).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to