Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 14:57 GMT+01:00 Mark Thompson : > I've applied the second patch and closed the ticket. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Mark Thompson
On 10/12/16 12:52, Carl Eugen Hoyos wrote: > 2016-12-10 13:50 GMT+01:00 Mark Thompson : >> Fixes ticket #6003. >> --- >> On 10/12/16 12:09, Carl Eugen Hoyos wrote: >>> 2016-12-08 16:51 GMT+01:00 Mark Thompson : Fixes ticket #6003. >>> > May I suggest to revert this? > >> +pp->b

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 13:50 GMT+01:00 Mark Thompson : > Fixes ticket #6003. > --- > On 10/12/16 12:09, Carl Eugen Hoyos wrote: >> 2016-12-08 16:51 GMT+01:00 Mark Thompson : >>> Fixes ticket #6003. >> May I suggest to revert this? > +pp->bit_depth = h->h.bpp; Google doesn't easily f

[FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Mark Thompson
Fixes ticket #6003. --- On 10/12/16 12:09, Carl Eugen Hoyos wrote: > 2016-12-08 16:51 GMT+01:00 Mark Thompson : >> Fixes ticket #6003. > >>> May I suggest to revert this? >>> +pp->bit_depth = h->h.bpp; >>> >>> Google doesn't easily find a version of va_dec_vp9.h >>> with _VADecPicturePara

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Carl Eugen Hoyos
2016-12-08 16:51 GMT+01:00 Mark Thompson : > Fixes ticket #6003. >> May I suggest to revert this? >> >>> +pp->bit_depth = h->h.bpp; >> >> Google doesn't easily find a version of va_dec_vp9.h >> with _VADecPictureParameterBufferVP9->bit_depth. > > Urgh: libva 1.6.0 to 1.6.2 don't have this fiel

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-08 Thread James Almer
On 12/8/2016 12:55 PM, Mark Thompson wrote: > On 08/12/16 15:51, Mark Thompson wrote: >> Hacky fix enclosing, only compile tested. >> >> A configure test for this might be better, because we could then check it >> sensibly in the generic code and bail out earlier? (Which would permit >> software

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-08 Thread Mark Thompson
On 08/12/16 15:51, Mark Thompson wrote: > Hacky fix enclosing, only compile tested. > > A configure test for this might be better, because we could then check it > sensibly in the generic code and bail out earlier? (Which would permit > software decode, this will attempt hardware decode and fai

[FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-08 Thread Mark Thompson
Fixes ticket #6003. --- On 08/12/16 15:16, Carl Eugen Hoyos wrote: > 2016-12-05 21:32 GMT+01:00 Mathieu Velten : >> --- >> libavcodec/vaapi_vp9.c | 1 + >> libavcodec/vp9.c | 10 +- >> 2 files changed, 10 insertions(+), 1 deletion(-) > > (This is missing a review here but I guess i