Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-13 Thread Daniel Kučera
> > The good approach is to fix the bugs. You do not need to fix all of > them, just fix the one or two instances that break things for you: in > your use case, there is one line of code in the whole project that gets > ret=0 and thinks it means EOF: find it and fix it, and you should be > good. Ot

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-12 Thread wm4
On Thu, 12 Oct 2017 16:16:31 +0200 Nicolas George wrote: > Le quintidi 15 vendémiaire, an CCXXVI, Daniel Kučera a écrit : > > I'm not sure if you mean this patch is unacceptable but if so, I want > > to note, that this patch is not the same as I submitted before: this > > one adds cmdlne option t

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-12 Thread Nicolas George
Le quintidi 15 vendémiaire, an CCXXVI, Daniel Kučera a écrit : > I'm not sure if you mean this patch is unacceptable but if so, I want > to note, that this patch is not the same as I submitted before: this > one adds cmdlne option to ignore empty packets and it doesn't ignore > them when not explic

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-09 Thread Daniel Kučera
Waiting for review. Dňa 6. 10. 2017 10:32 dopoludnia používateľ "Daniel Kučera" < daniel.kuc...@gmail.com> napísal: > > And since empty packets are valid and can be used by applications (and > > are actually used by protocols out there), the workaround of dropping > > them is not acceptable. > >

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-06 Thread Daniel Kučera
> And since empty packets are valid and can be used by applications (and > are actually used by protocols out there), the workaround of dropping > them is not acceptable. > I'm not sure if you mean this patch is unacceptable but if so, I want to note, that this patch is not the same as I submitted

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-06 Thread Nicolas George
Le quartidi 14 vendémiaire, an CCXXVI, Carl Eugen Hoyos a écrit : > Just curious: Is it useful at all to exit on an empty packet? It is not useful at all, it is a bug. More specifically, when reading plain files, ret = 0 means EOF for plain files, just because there is nothing more to read (but i

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-05 Thread Daniel Kučera
Dňa 5. 10. 2017 10:19 odpoludnia používateľ "Carl Eugen Hoyos" < ceffm...@gmail.com> napísal: 2017-10-05 16:26 GMT+02:00 Daniel Kucera : > Time to time some devices send UDP packets without payload. > ffmpeg previously exited on receiving such packet Just curious: Is it useful at all to exit on a

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-05 Thread Carl Eugen Hoyos
2017-10-05 16:26 GMT+02:00 Daniel Kucera : > Time to time some devices send UDP packets without payload. > ffmpeg previously exited on receiving such packet Just curious: Is it useful at all to exit on an empty packet? Carl Eugen ___ ffmpeg-devel mailin

[FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-05 Thread Daniel Kucera
Time to time some devices send UDP packets without payload. ffmpeg previously exited on receiving such packet, this patch adds an option to ignore such packets. Signed-off-by: Daniel Kucera --- libavformat/udp.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib