Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Carl Eugen Hoyos
Am So., 23. Feb. 2020 um 23:43 Uhr schrieb James Darnley : > > On 2020-02-23 18:58, Michael Niedermayer wrote: > > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: > >> Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer > >> : > >>> > >>> From: Parker Ernest <@> > >>> >

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Darnley
On 2020-02-23 18:58, Michael Niedermayer wrote: > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: >> Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer >> : >>> >>> From: Parker Ernest <@> >>> >>> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on >>> x86_

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Hendrik Leppkes
On Sun, Feb 23, 2020 at 6:58 PM Michael Niedermayer wrote: > > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: > > Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer > > : > > > > > > From: Parker Ernest <@> > > > > > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Almer
On 2/23/2020 2:58 PM, Michael Niedermayer wrote: > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: >> Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer >> : >>> >>> From: Parker Ernest <@> >>> >>> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on >>> x86

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Michael Niedermayer
On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: > Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer > : > > > > From: Parker Ernest <@> > > > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Hendrik Leppkes
On Sun, Feb 23, 2020 at 6:26 PM Paul B Mahol wrote: > > On 2/23/20, James Almer wrote: > > On 2/23/2020 9:33 AM, Paul B Mahol wrote: > >> lgtm > > > > No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent > > any of these functions from running on old CPUs. > > this is about bui

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Paul B Mahol
On 2/23/20, James Almer wrote: > On 2/23/2020 9:33 AM, Paul B Mahol wrote: >> lgtm > > No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent > any of these functions from running on old CPUs. this is about building. > > It would help actually knowing what kind of failure is the

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Almer
On 2/23/2020 9:33 AM, Paul B Mahol wrote: > lgtm No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent any of these functions from running on old CPUs. It would help actually knowing what kind of failure is the user getting. > > On 2/23/20, Michael Niedermayer wrote: >> From:

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Carl Eugen Hoyos
Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer : > > From: Parker Ernest <@> > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II Does the commit break build on specific CPUs or specific toolchains? Carl Euge

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Paul B Mahol
lgtm On 2/23/20, Michael Niedermayer wrote: > From: Parker Ernest <@> > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II > > Signed-off-by: Michael Niedermayer > --- > libswscale/x86/yuv2rgb.c | 2 ++ > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Darnley
On 2020-02-23 13:22, Michael Niedermayer wrote: > From: Parker Ernest <@> > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II > > Signed-off-by: Michael Niedermayer > --- > libswscale/x86/yuv2rgb.c | 2 ++ > 1 file change

[FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Michael Niedermayer
From: Parker Ernest <@> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II Signed-off-by: Michael Niedermayer --- libswscale/x86/yuv2rgb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libswscale/x86/yuv2rgb.c b/libsws