Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 12:10 PM, Mats Peterson wrote: On 12/13/2015 12:01 PM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On 12/13/2015 11:06 AM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Paul B Mahol wrote: On 12/12/15, Mats Peterson wrote: On Sat, 12

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 12:10 PM, Mats Peterson wrote: On 12/13/2015 12:01 PM, Paul B Mahol wrote: Have you provided such several test filest to others? In this directory are three sample Matroska files with QuickTime video that will display with the wrong palette (none at all, really) without the p

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 12:01 PM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On 12/13/2015 11:06 AM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Paul B Mahol wrote: On 12/12/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Michael Niedermayer wrote: On Sat,

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Paul B Mahol
On 12/13/15, Mats Peterson wrote: > On 12/13/2015 11:06 AM, Paul B Mahol wrote: >> On 12/13/15, Mats Peterson wrote: >>> On Sat, 12 Dec 2015, Paul B Mahol wrote: >>> On 12/12/15, Mats Peterson wrote: > On Sat, 12 Dec 2015, Michael Niedermayer wrote: > >> On Sat, Dec 12, 2015 at

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 11:06 AM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Paul B Mahol wrote: On 12/12/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Michael Niedermayer wrote: On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: Obviously that private d

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Paul B Mahol
On 12/13/15, Mats Peterson wrote: > On Sat, 12 Dec 2015, Paul B Mahol wrote: > >> On 12/12/15, Mats Peterson wrote: >>> On Sat, 12 Dec 2015, Michael Niedermayer wrote: >>> On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: > Obviously that private data is cropped in some way

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
On Sat, 12 Dec 2015, Paul B Mahol wrote: On 12/12/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Michael Niedermayer wrote: On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: Obviously that private data is cropped in some way then, since the minimum size of a video sample descrip

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Paul B Mahol
On 12/12/15, Mats Peterson wrote: > On Sat, 12 Dec 2015, Michael Niedermayer wrote: > >> On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: >>> Obviously that private data is cropped in some way then, since the >>> minimum size of a video sample description in QuickTime video is 86 >>>

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
On Sat, 12 Dec 2015, Michael Niedermayer wrote: On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: Obviously that private data is cropped in some way then, since the minimum size of a video sample description in QuickTime video is 86 bytes. FFmpeg tries to support all kind of odd

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Michael Niedermayer
On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: > Obviously that private data is cropped in some way then, since the minimum > size of a video sample description in QuickTime video is 86 bytes. FFmpeg tries to support all kind of odd and broken files, so even if the file is invalid

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
ginal Message - From: Mats Peterson To: FFmpeg development discussions and patches Sent: Saturday, December 12, 2015 12:17 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handlepalettized QuickTime video properly Obviously that private data is cropped in some way then, since the m

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
ches Sent: Saturday, December 12, 2015 12:17 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly Obviously that private data is cropped in some way then, since the minimum size of a video sample description in QuickTime video is 86 bytes. Mats

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
and patches Sent: Saturday, December 12, 2015 11:58 AM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly On Fri, Dec 11, 2015 at 11:32:13AM +, Mats Peterson wrote: > OK, here is an improved version of my previous patch of matroskadec.c t

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Michael Niedermayer
On Fri, Dec 11, 2015 at 11:32:13AM +, Mats Peterson wrote: > OK, here is an improved version of my previous patch of matroskadec.c that > manages the palette itself without calling code in mov.c. I have borrowed > some code from it, though, and I'm including qtpalette.h. One thing I don't >

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
ormat Reference for additional info. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ From: compn To: FFmpeg development discussions and patches Sent: Friday, December 11, 2015 3:08 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly On Fr

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread compn
On Fri, 11 Dec 2015 12:59:16 + (UTC) Mats Peterson wrote: > I just want someone of you guys to take a look at what I've done. You > know Git much better than me, and you can create a pull request it > looks decent enough. I'm not going to participate a lot in this in > the future, but I wante

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
they have been overlooked for such a long time. Mats  -- Mats Peterson http://matsp888.no-ip.org/~mats/       From: Moritz Barsnick To: FFmpeg development discussions and patches Sent: Friday, December 11, 2015 1:55 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickT

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
d for such a long time. Mats  -- Mats Peterson http://matsp888.no-ip.org/~mats/ From: Moritz Barsnick To: FFmpeg development discussions and patches Sent: Friday, December 11, 2015 1:55 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Moritz Barsnick
On Fri, Dec 11, 2015 at 11:48:15 +, Mats Peterson wrote: > And I said before, I'm not going to "learn" how to use the messy Git > system. What's messy? That's just the way it works here. It may be a bit more tedious for you, but makes life for everyone else (testers, reviewers, committers) mu

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
ect: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly On Friday 11 December 2015 12:32:13 pm Mats Peterson wrote: > OK, here is an improved version of my previous patch of > matroskadec.c that manages the palette itself without calling > code in m

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
"the original author", most of the old patch has been modified by me. Mats  -- Mats Peterson http://matsp888.no-ip.org/~mats/ From: Carl Eugen Hoyos To: FFmpeg development discussions and patches Sent: Friday, December 11, 2015 12:42 PM Subject: Re: [FFmpeg-devel] [PATCH] ma

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Carl Eugen Hoyos
On Friday 11 December 2015 12:32:13 pm Mats Peterson wrote: > OK, here is an improved version of my previous patch of > matroskadec.c that manages the palette itself without calling > code in mov.c. I have borrowed some code from it This is completely unacceptable afaict. Unrelated: It is a mys

[FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
OK, here is an improved version of my previous patch of matroskadec.c that manages the palette itself without calling code in mov.c. I have borrowed some code from it, though, and I'm including qtpalette.h. One thing I don't understand is why the minimum private data size for V_QUICKTIME has bee