On 13.09.24 13:59, Tomas Härdin wrote:
RE: performance, we might want to move to a hash table based approach
so we don't scan the entire table every time. The approach in this
patch would be detrimental to such a change (it's an extra if that's
always evaluated), hence why I prefer a table base
fre 2024-09-13 klockan 08:23 + skrev Nicolas Gaullier:
>
> - why not using a simple "if" on the av_log rather than inserting a
> new block of code ?
That's way ugly
RE: performance, we might want to move to a hash table based approach
so we don't scan the entire table every time. The approac
On 13.09.24 10:23, Nicolas Gaullier wrote:
I am not against the idea of the patch: filler items should not be logged as dark metadata.
Fine! -- that's the main point!
I find the patch confusing both because of the commit msg and code:
- the commit msg should not claim it "adds support for"
>De : ffmpeg-devel De la part de martin
>schitter
>Envoyé : jeudi 12 septembre 2024 13:54
>On 12.09.24 13:14, Nicolas Gaullier wrote:
>> The message "Recognize and Ignore" does not make it clear what issue or
>> grave defect is solved here.
>> I see in the code that fill items are currently reco
On 12.09.24 13:14, Nicolas Gaullier wrote:
The message "Recognize and Ignore" does not make it clear what issue or grave
defect is solved here.
I see in the code that fill items are currently recognized as dark metadata and
ignored likewise, but I don't see any issue here.
Maybe could you co
>De : ffmpeg-devel De la part de martin
>schitter
>Envoyé : jeudi 12 septembre 2024 02:36
>
>But an elementary feature like 'fill' should be simply supported by any MXF
>demuxer in a suitable manner, otherwise it's IMHO a grave defect.
>If you don't see any further objections, please just merge
On 11.09.24 10:15, Tomas Härdin wrote:
This could also be done using mxf_metadata_read_table[] using a simple
stub callback.
Alternatively we could add some logic to the parsing loop that skips
KLVs whose key's entry in the table have read == NULL. The loop
termination condition would need to
ons 2024-09-11 klockan 10:15 +0200 skrev Martin Schitter:
> This adds support for empty 'fill' boxes while decoding MXF files.
> ---
> libavformat/mxfdec.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 142b3e6..701fc9f 100644
>
This adds support for empty 'fill' boxes while decoding MXF files.
---
libavformat/mxfdec.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 142b3e6..701fc9f 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -367,6 +367,8 @@
