On Thu, Dec 25, 2014 at 10:02:05AM +0530, arwa arif wrote:
> Merry Christmas! :D
>
[...]
> vf_pp7.c | 500
> +++
> vf_pp7.h | 57 ++
> x86/vf_pp7.c | 74
missing change to Makefile and allfilters.c
Merry Christma
On date Thursday 2014-12-25 10:02:05 +0530, arwa arif encoded:
> Merry Christmas! :D
>
> I have attached 2 patches:
> 1. For deleting the mp=fspp filter.
> 2. For porting pp7
>
> I have tested the ouput for pp7, it is bitexact with mp=pp7 filter. Also, I
> haven't completed the patch. There are j
Merry Christmas! :D
I have attached 2 patches:
1. For deleting the mp=fspp filter.
2. For porting pp7
I have tested the ouput for pp7, it is bitexact with mp=pp7 filter. Also, I
haven't completed the patch. There are just codes. Once the previous
patches are pushed, I will update the patch.
From
On date Tuesday 2014-12-23 22:22:41 +0100, Michael Niedermayer encoded:
> On Tue, Dec 23, 2014 at 10:51:09PM +0530, arwa arif wrote:
> [...]
> > > Test with a fixed qp value for comparison, as the mp=fspp is broken
> > > with regards to qp passing. Also it should generate the same
> > > output as w
On date Tuesday 2014-12-23 22:51:09 +0530, arwa arif encoded:
[...]
> mp=fspp and fspp filter are giving same output. But, fspp with -cpuflags 0
> is giving different output (visually, it
> looks same, but its not bitexact).
[...]
> From 1ee7b1098809dd1e62703ba76a136dd27d243f20 Mon Sep 17 00:00:00
On Tue, Dec 23, 2014 at 08:12:50AM +0100, Stefano Sabatini wrote:
> On date Monday 2014-12-22 17:57:34 +0100, Reimar Döffinger encoded:
> > On 22.12.2014, at 17:23, Stefano Sabatini wrote:
> [...]
> > > I'm testing with:
> > > ffmpeg -i matrixbench_mpeg2.mpg -b:v 200k matrixbench_mpeg2-lq.mpg
> >
On Tue, Dec 23, 2014 at 10:51:09PM +0530, arwa arif wrote:
[...]
> > Test with a fixed qp value for comparison, as the mp=fspp is broken
> > with regards to qp passing. Also it should generate the same
> > output as with -cpuflags 0, but only in case the original filter
> > did. Report in any case.
On Tue, Dec 23, 2014 at 10:51:09PM +0530, arwa arif wrote:
> >
> >
> > > From 05dc64b0048547221f63824b4158701f8257e15c Mon Sep 17 00:00:00 2001
> > > From: Arwa Arif
> > > Date: Sun, 14 Dec 2014 12:03:31 +0530
> > > Subject: [PATCH] lavfi: port mp=fspp to a native libavfilter filter
> > [...]
> >
>
>
> > From 05dc64b0048547221f63824b4158701f8257e15c Mon Sep 17 00:00:00 2001
> > From: Arwa Arif
> > Date: Sun, 14 Dec 2014 12:03:31 +0530
> > Subject: [PATCH] lavfi: port mp=fspp to a native libavfilter filter
> [...]
> > diff --git a/libavfilter/version.h b/libavfilter/version.h
> > index 4bd1
On date Tuesday 2014-12-23 15:52:57 +0530, arwa arif encoded:
> On Tue, Dec 23, 2014 at 12:40 PM, Stefano Sabatini
> wrote:
[...]
Please learn to trim the original message when you reply. I had to
scroll down over 900 lines, and this wastes both bandwidth and time.
> > > +static int filter_frame
On Thu, Dec 18, 2014 at 12:12:14AM +0100, Stefano Sabatini wrote:
[...]
> > +static void mul_thrmat_c(FSPPContext *p, int q)
> > +{
> > +int a;
> > +for (a = 0; a < 64; a++)
> > +((short*)p->threshold_mtx)[a] = q *
> > ((short*)p->threshold_mtx_noq)[a];//ints faster in C
>
> short
On Tue, Dec 23, 2014 at 09:56:16AM +0530, arwa arif wrote:
> On Mon, Dec 22, 2014 at 10:27 PM, Michael Niedermayer
> wrote:
>
> > On Mon, Dec 22, 2014 at 09:51:25PM +0530, arwa arif wrote:
> > [...]
> >
> > > +static int filter_frame(AVFilterLink *inlink, AVFrame *in)
> > > +{
> > > +AVFilter
On Tue, Dec 23, 2014 at 03:52:57PM +0530, arwa arif wrote:
> On Tue, Dec 23, 2014 at 12:40 PM, Stefano Sabatini
[...]
> +static void mul_thrmat_c(FSPPContext *p, int q)
> +{
> +int a;
> +for (a = 0; a < 64; a++)
> +((int8_t *)p->threshold_mtx)[a] = q * ((int8_t
> *)p->threshold_m
On date Monday 2014-12-22 17:57:34 +0100, Reimar Döffinger encoded:
> On 22.12.2014, at 17:23, Stefano Sabatini wrote:
[...]
> > I'm testing with:
> > ffmpeg -i matrixbench_mpeg2.mpg -b:v 200k matrixbench_mpeg2-lq.mpg
> >
> > ffplay -f lavfi -i "nullsrc=s=720x576 [bg];
> > movie=matrixbench_mpeg
On date Monday 2014-12-22 21:51:25 +0530, arwa arif encoded:
> On Mon, Dec 22, 2014 at 5:37 PM, Stefano Sabatini
> wrote:
>
> > On date Friday 2014-12-19 16:46:40 +0530, arwa arif encoded:
> > [...]
> > > From c1c3255203226663fc382a0994182df3d558afe6 Mon Sep 17 00:00:00 2001
> > > From: Arwa Arif
On Mon, Dec 22, 2014 at 10:27 PM, Michael Niedermayer
wrote:
> On Mon, Dec 22, 2014 at 09:51:25PM +0530, arwa arif wrote:
> [...]
>
> > +static int filter_frame(AVFilterLink *inlink, AVFrame *in)
> > +{
> > +AVFilterContext *ctx = inlink->dst;
> > +FSPPContext *fspp = ctx->priv;
> > +
On Mon, Dec 22, 2014 at 09:51:25PM +0530, arwa arif wrote:
> On Mon, Dec 22, 2014 at 5:37 PM, Stefano Sabatini
> wrote:
[...]
> +typedef struct fsppContext {
> +uint64_t threshold_mtx_noq[8 * 2];
The first field must be a AVClass pointer like
typedef struct fsppContext {
AVClass *class;
On 22.12.2014, at 17:23, Stefano Sabatini wrote:
> On date Monday 2014-12-22 13:07:03 +0100, Stefano Sabatini encoded:
>> On date Friday 2014-12-19 16:46:40 +0530, arwa arif encoded:
>> [...]
>>> From c1c3255203226663fc382a0994182df3d558afe6 Mon Sep 17 00:00:00 2001
>>> From: Arwa Arif
>>> Date:
On Mon, Dec 22, 2014 at 09:51:25PM +0530, arwa arif wrote:
[...]
> +static int filter_frame(AVFilterLink *inlink, AVFrame *in)
> +{
> +AVFilterContext *ctx = inlink->dst;
> +FSPPContext *fspp = ctx->priv;
> +AVFilterLink *outlink = ctx->outputs[0];
> +AVFrame *out = in;
> +
> +
On date Monday 2014-12-22 13:07:03 +0100, Stefano Sabatini encoded:
> On date Friday 2014-12-19 16:46:40 +0530, arwa arif encoded:
> [...]
> > From c1c3255203226663fc382a0994182df3d558afe6 Mon Sep 17 00:00:00 2001
> > From: Arwa Arif
> > Date: Sun, 14 Dec 2014 12:03:31 +0530
> > Subject: [PATCH] l
On date Friday 2014-12-19 16:46:40 +0530, arwa arif encoded:
[...]
> From c1c3255203226663fc382a0994182df3d558afe6 Mon Sep 17 00:00:00 2001
> From: Arwa Arif
> Date: Sun, 14 Dec 2014 12:03:31 +0530
> Subject: [PATCH] lavfi: port mp=fspp to a native libavfilter filter
>
> ---
> LICENSE.md
On Fri, 19 Dec 2014, Clément Bsch wrote:
> On Fri, Dec 19, 2014 at 04:40:21PM +0100, Michael Niedermayer wrote:
> [...]
> > then one filter that i remember was requested (longer ago) is
> > nnedi3 but that would need to have its asm removed or ported which
> > is not trivial i suspect
> >
>
> The
On Sat, Dec 20, 2014 at 5:17 AM, Clément Bœsch wrote:
> On Fri, Dec 19, 2014 at 08:04:33PM +0100, Michael Niedermayer wrote:
> > On Fri, Dec 19, 2014 at 07:26:52PM +0100, Clément Bœsch wrote:
> > > On Fri, Dec 19, 2014 at 06:42:22PM +0100, Michael Niedermayer wrote:
> > > > On Fri, Dec 19, 2014 a
On Fri, Dec 19, 2014 at 08:04:33PM +0100, Michael Niedermayer wrote:
> On Fri, Dec 19, 2014 at 07:26:52PM +0100, Clément Bœsch wrote:
> > On Fri, Dec 19, 2014 at 06:42:22PM +0100, Michael Niedermayer wrote:
> > > On Fri, Dec 19, 2014 at 04:55:32PM +0100, Clément Bœsch wrote:
> > > > On Fri, Dec 19,
On Fri, Dec 19, 2014 at 07:26:52PM +0100, Clément Bœsch wrote:
> On Fri, Dec 19, 2014 at 06:42:22PM +0100, Michael Niedermayer wrote:
> > On Fri, Dec 19, 2014 at 04:55:32PM +0100, Clément Bœsch wrote:
> > > On Fri, Dec 19, 2014 at 04:40:21PM +0100, Michael Niedermayer wrote:
> > > [...]
> > > > the
On Fri, Dec 19, 2014 at 06:42:22PM +0100, Michael Niedermayer wrote:
> On Fri, Dec 19, 2014 at 04:55:32PM +0100, Clément Bœsch wrote:
> > On Fri, Dec 19, 2014 at 04:40:21PM +0100, Michael Niedermayer wrote:
> > [...]
> > > then one filter that i remember was requested (longer ago) is
> > > nnedi3 b
On Fri, Dec 19, 2014 at 04:55:32PM +0100, Clément Bœsch wrote:
> On Fri, Dec 19, 2014 at 04:40:21PM +0100, Michael Niedermayer wrote:
> [...]
> > then one filter that i remember was requested (longer ago) is
> > nnedi3 but that would need to have its asm removed or ported which
> > is not trivial i
On Fri, Dec 19, 2014 at 04:40:21PM +0100, Michael Niedermayer wrote:
[...]
> then one filter that i remember was requested (longer ago) is
> nnedi3 but that would need to have its asm removed or ported which
> is not trivial i suspect
>
The problem with nnedi3 is that it requires 13MB of learned
On Fri, Dec 19, 2014 at 06:10:00AM +0100, Michael Niedermayer wrote:
> On Fri, Dec 19, 2014 at 02:13:01AM +0100, Stefano Sabatini wrote:
> > On date Thursday 2014-12-18 13:57:27 +0530, arwa arif encoded:
[...]
> >
> > Note: as usual you can prepare a patch to remove the corresponding mp
> > filter
On Fri, Dec 19, 2014 at 06:45:13AM +, Timothy Gu wrote:
> On Dec 18, 2014 10:31 PM, "arwa arif" wrote:
> >
> > On Fri, Dec 19, 2014 at 10:40 AM, Michael Niedermayer
> > wrote:
> > >
> > > it segfaults without -cpuflags 0 here
> > > ./ffplay -i matrixbench_mpeg2.mpg -vf fspp
> > >
> > >
> >
On Fri, Dec 19, 2014 at 12:15 PM, Timothy Gu wrote:
>
> On Dec 18, 2014 10:31 PM, "arwa arif" wrote:
> >
> > On Fri, Dec 19, 2014 at 10:40 AM, Michael Niedermayer
> > wrote:
> > >
> > > it segfaults without -cpuflags 0 here
> > > ./ffplay -i matrixbench_mpeg2.mpg -vf fspp
> > >
> > >
> > I tri
On Dec 18, 2014 10:31 PM, "arwa arif" wrote:
>
> On Fri, Dec 19, 2014 at 10:40 AM, Michael Niedermayer
> wrote:
> >
> > it segfaults without -cpuflags 0 here
> > ./ffplay -i matrixbench_mpeg2.mpg -vf fspp
> >
> >
> I tried this command on my system, and it is not giving segfault on my
> system.
On Fri, Dec 19, 2014 at 02:13:01AM +0100, Stefano Sabatini wrote:
> On date Thursday 2014-12-18 13:57:27 +0530, arwa arif encoded:
> [...]
> > From 3da2573bb66205999cf170997a8d088ccb61c350 Mon Sep 17 00:00:00 2001
> > From: Arwa Arif
> > Date: Sun, 14 Dec 2014 12:03:31 +0530
>
> > Subject: [PATCH
On date Thursday 2014-12-18 13:57:27 +0530, arwa arif encoded:
[...]
> From 3da2573bb66205999cf170997a8d088ccb61c350 Mon Sep 17 00:00:00 2001
> From: Arwa Arif
> Date: Sun, 14 Dec 2014 12:03:31 +0530
> Subject: [PATCH] lavfi: port mp=uspp to a native libavfilter filter
mp=fspp
>
> ---
> LICEN
On Thu, Dec 18, 2014 at 01:57:27PM +0530, arwa arif wrote:
> >
> >
> > > --- a/libavfilter/allfilters.c
> > > +++ b/libavfilter/allfilters.c
> > > @@ -141,6 +141,7 @@ void avfilter_register_all(void)
> > > REGISTER_FILTER(FRAMEPACK, framepack, vf);
> > > REGISTER_FILTER(FRAMESTE
>
>
> > --- a/libavfilter/allfilters.c
> > +++ b/libavfilter/allfilters.c
> > @@ -141,6 +141,7 @@ void avfilter_register_all(void)
> > REGISTER_FILTER(FRAMEPACK, framepack, vf);
> > REGISTER_FILTER(FRAMESTEP, framestep, vf);
> > REGISTER_FILTER(FREI0R, fre
On date Thursday 2014-12-18 12:06:04 +0530, arwa arif encoded:
> >
> > AVFILTER_DEFINE_CLASS(fspp)
>
>
> Why do we need this? Is it not defined already?
>
>
> > > +static int config_input(AVFilterLink *inlink)
> > > +{
> > > +
> > > +AVFilterContext *ctx = inlink->dst;
> > > +FSPPContex
From af45d0edb243a0948581d48e1794e0e496d2204f Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Sun, 14 Dec 2014 12:03:31 +0530
Subject: [PATCH] lavfi: port mp=uspp to a native libavfilter filter
---
LICENSE.md|1 +
configure |1 +
doc/filter
On Thu, Dec 18, 2014 at 12:06:04PM +0530, arwa arif wrote:
> >
> > AVFILTER_DEFINE_CLASS(fspp)
>
>
> Why do we need this? Is it not defined already?
>
See e93abe1f406964e6e59f2bf86b0763f3a90f5acf
[...]
--
Clément B.
pgpCzcqq5KwWm.pgp
Description: PGP signature
_
>
> AVFILTER_DEFINE_CLASS(fspp)
Why do we need this? Is it not defined already?
> > +static int config_input(AVFilterLink *inlink)
> > +{
> > +
> > +AVFilterContext *ctx = inlink->dst;
> > +FSPPContext *fspp = ctx->priv;
> > +const int h = FFALIGN(inlink->h + 16, 16);
> > +const
Stefano Sabatini gmail.com> writes:
> > +extern uint64_t ff_MM_FIX_0_707106781;
> > +extern uint64_t ff_MM_FIX_0_541196100;
>
> why do you need to change this?
>
> Can you just drop the ff_ prefix from the
> constant and put it in the x86 file?
The reason is apparently llvm, see fa35ade8
My
Stefano Sabatini gmail.com> writes:
> > -DECLARE_ALIGNED(8, uint64_t, ff_MM_FIX_0_541196100)=
> > FIX64(0.541196100, 14);
> > -DECLARE_ALIGNED(8, uint64_t, ff_MM_FIX_0_707106781)=
> > FIX64(0.707106781, 14);
> > +extern uint64_t ff_MM_FIX_0_707106781;
> > +extern uint64_t ff_MM_FIX_0_541196100;
>
On date Wednesday 2014-12-17 12:16:12 +0530, arwa arif encoded:
> Updated the patch.
> Since, norm_qsclae uses "libavcodec/avcodec.h", can't remove it.
> From c168321361c99ccb8cea13de0091f112e401614e Mon Sep 17 00:00:00 2001
> From: Arwa Arif
> Date: Sun, 14 Dec 2014 12:03:31 +0530
> Subject: [PA
Updated the patch.
Since, norm_qsclae uses "libavcodec/avcodec.h", can't remove it.
From c168321361c99ccb8cea13de0091f112e401614e Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Sun, 14 Dec 2014 12:03:31 +0530
Subject: [PATCH] Port fspp to FFmpeg
---
configure |1 +
do
On Tue, Dec 16, 2014 at 10:08:52PM +0100, Clément Bœsch wrote:
[...]
> > +#define LIBAVFILTER_VERSION_MICRO 103
>
> this needs to be set to 0
>
to 100, sorry.
[...]
--
Clément B.
pgpFc6Ri_eJAu.pgp
Description: PGP signature
___
ffmpeg-devel mailin
On Tue, Dec 16, 2014 at 07:51:57PM +0530, arwa arif wrote:
>
> From 993cac2530263bd99691016cc2ad8e6ac7be6b2a Mon Sep 17 00:00:00 2001
> From: Arwa Arif
> Date: Sun, 14 Dec 2014 12:03:31 +0530
> Subject: [PATCH] Port fspp to FFmpeg
>
> ---
> configure |1 +
> doc/fil
From 993cac2530263bd99691016cc2ad8e6ac7be6b2a Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Sun, 14 Dec 2014 12:03:31 +0530
Subject: [PATCH] Port fspp to FFmpeg
---
configure |1 +
doc/filters.texi | 25 +
libavfilter/Makefile |1
On Tue, Dec 16, 2014 at 11:14:58AM +0530, arwa arif wrote:
> On Tue, Dec 16, 2014 at 6:06 AM, Michael Niedermayer
> wrote:
> >
> > On Mon, Dec 15, 2014 at 10:55:26PM +0530, arwa arif wrote:
> > > This patch seems to be working. Sorry for the previous one.
> >
> > > doc/filters.texi
arwa arif gmail.com> writes:
> #define LIBAVFILTER_VERSION_MINOR 2
> -#define LIBAVFILTER_VERSION_MICRO 104
> +#define LIBAVFILTER_VERSION_MICRO 105
You should bump minor (and reset micro)
when adding a new filter.
Carl Eugen
___
ffmpeg-devel mail
On Tue, Dec 16, 2014 at 6:06 AM, Michael Niedermayer
wrote:
>
> On Mon, Dec 15, 2014 at 10:55:26PM +0530, arwa arif wrote:
> > This patch seems to be working. Sorry for the previous one.
>
> > doc/filters.texi | 24
> > libavfilter/Makefile |1
> > libavfilter/
On Mon, Dec 15, 2014 at 10:55:26PM +0530, arwa arif wrote:
> This patch seems to be working. Sorry for the previous one.
> doc/filters.texi | 24
> libavfilter/Makefile |1
> libavfilter/allfilters.c |1
> libavfilter/libmpcodecs/vf_fspp.c |
arwa arif gmail.com> writes:
> + * it under the terms of the GNU General Public License
The configure part is missing that makes sure the
filter is only compiled when --enable-gpl was used.
> +DECLARE_ALIGNED(32, static const uint8_t, dither)[8][8] = {
> +{ 0, 48, 12, 60, 3, 51, 15
This patch seems to be working. Sorry for the previous one.
From 97d90c5a1a8c10a1b19a5250c90d02fb74e79735 Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Sun, 14 Dec 2014 12:03:31 +0530
Subject: [PATCH] Port fspp to FFmpeg
---
doc/filters.texi | 24 +
libavfilter/Makefile
On Mon, Dec 15, 2014 at 06:20:36PM +0530, arwa arif wrote:
> Updated the patch. There was a comment in the original filter that
> mul_thrmat is faster in c. So, should mul_thrmat_mmx be included or not?
i dont know that code, where was that comment ?
you could benchamrk it though by enclosing the
arwa arif gmail.com> writes:
> There was a comment in the original filter that
> mul_thrmat is faster in c. So, should
> mul_thrmat_mmx be included or not?
Ideally, you would test yourself what is faster.
Carl Eugen
___
ffmpeg-devel mailing list
ffm
Updated the patch. There was a comment in the original filter that
mul_thrmat is faster in c. So, should mul_thrmat_mmx be included or not?
From ad30ab016a4f2d98e9e979c1cebf3d950d10c156 Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Sun, 14 Dec 2014 12:03:31 +0530
Subject: [PATCH] Port fspp to FFm
arwa arif gmail.com> writes:
> > > +DECLARE_ALIGNED (8, uint64_t, ff_MM_FIX_0_541196100)=
> > > FIX64(0.541196100, 14);
> > > +DECLARE_ALIGNED (8, uint64_t, ff_MM_FIX_0_707106781)=
> > > FIX64(0.707106781, 14);
> >
> > these 2 conflict with the existing fspp filter, they
> > should be removed
>
>
> > +
> > +DECLARE_ASM_CONST(8, uint64_t, MM_FIX_0_382683433) =
> FIX64(0.382683433, 14);
>
> > +DECLARE_ALIGNED (8, uint64_t, ff_MM_FIX_0_541196100)=
> FIX64(0.541196100, 14);
> > +DECLARE_ALIGNED (8, uint64_t, ff_MM_FIX_0_707106781)=
> FIX64(0.707106781, 14);
>
> these 2 conflict with the
On Sun, Dec 14, 2014 at 12:26:15PM +0530, arwa arif wrote:
> I have tried to port fspp. Not sure, if it is correct or not.
[...]
> +static void filter(FSPPContext *p , uint8_t *dst , uint8_t *src,
> + int dst_stride , int src_stride ,
> + int width , int height
arwa arif gmail.com> writes:
> I have tried to port fspp. Not sure, if it is
> correct or not.
Did you compare the output of -vf fspp and -vf mp=fspp?
> +av_cold void ff_fspp_init_x86(FSPPContext *s)
> +{
> +#if HAVE_MMX_INLINE
> +int cpu_flags = av_get_cpu_flags();
> +
> +if (cpu_flag
I have tried to port fspp. Not sure, if it is correct or not.
From da23a3d94181a5d53454d3904d79a422ea1272ac Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Sun, 14 Dec 2014 12:03:31 +0530
Subject: [PATCH] Port fspp to FFmpeg
---
doc/filters.texi | 24 +
libavfilter/Makefile |1
61 matches
Mail list logo
