Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-29 Thread Marek Behun
On Sun, 29 Jan 2017 22:35:12 +1100 Matt Oliver wrote: > Well perhaps making a tls_libressl implementation would be the better > way to go as the APIs are only going to diverge further. So perhaps > in order to support LibreSSL there should be a separate > implementation using LibreSSLs independen

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-29 Thread Matt Oliver
On 29 January 2017 at 01:00, Marek Behun wrote: > On Sat, 28 Jan 2017 14:07:45 +0100 > wm4 wrote: > > > On Sat, 28 Jan 2017 13:01:54 + > > Mark Thompson wrote: > > > > > On 28/01/17 11:28, wm4 wrote: > > > > On Fri, 27 Jan 2017 19:53:50 + > > > > Mark Thompson wrote: > > > > > > > >> O

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-28 Thread Marek Behun
On Sat, 28 Jan 2017 14:07:45 +0100 wm4 wrote: > On Sat, 28 Jan 2017 13:01:54 + > Mark Thompson wrote: > > > On 28/01/17 11:28, wm4 wrote: > > > On Fri, 27 Jan 2017 19:53:50 + > > > Mark Thompson wrote: > > > > > >> On 27/01/17 19:15, Marek Behun wrote: > > >>> On Fri, 27 Jan

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-28 Thread wm4
On Sat, 28 Jan 2017 13:01:54 + Mark Thompson wrote: > On 28/01/17 11:28, wm4 wrote: > > On Fri, 27 Jan 2017 19:53:50 + > > Mark Thompson wrote: > > > >> On 27/01/17 19:15, Marek Behun wrote: > >>> On Fri, 27 Jan 2017 18:41:09 + > >>> Mark Thompson wrote: > >>> > On 27

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-28 Thread Mark Thompson
On 28/01/17 11:28, wm4 wrote: > On Fri, 27 Jan 2017 19:53:50 + > Mark Thompson wrote: > >> On 27/01/17 19:15, Marek Behun wrote: >>> On Fri, 27 Jan 2017 18:41:09 + >>> Mark Thompson wrote: >>> On 27/01/17 17:31, Marek Behún wrote: > Use the LIBRESSL_VERSION_NUMBER macro to

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-28 Thread wm4
On Fri, 27 Jan 2017 19:53:50 + Mark Thompson wrote: > On 27/01/17 19:15, Marek Behun wrote: > > On Fri, 27 Jan 2017 18:41:09 + > > Mark Thompson wrote: > > > >> On 27/01/17 17:31, Marek Behún wrote: > >>> Use the LIBRESSL_VERSION_NUMBER macro to determine if building with > >>> Libr

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-27 Thread Mark Thompson
On 27/01/17 21:42, Marek Behún wrote: > In configure, check if the function BIO_meth_new is defined in the > corresponding OpenSSL/LibreSSL library, and if yes, define > HAVE_OPENSSL_BIO_METH_CALLS variable to 1 in config.h, or to 0 > otherwise. > > Change the heuristics preprocessor check > #if

[FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-27 Thread Marek Behún
In configure, check if the function BIO_meth_new is defined in the corresponding OpenSSL/LibreSSL library, and if yes, define HAVE_OPENSSL_BIO_METH_CALLS variable to 1 in config.h, or to 0 otherwise. Change the heuristics preprocessor check #if OPENSSL_VERSION_NUMBER >= 0x101fL to #if HAVE

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-27 Thread Mark Thompson
On 27/01/17 19:15, Marek Behun wrote: > On Fri, 27 Jan 2017 18:41:09 + > Mark Thompson wrote: > >> On 27/01/17 17:31, Marek Behún wrote: >>> Use the LIBRESSL_VERSION_NUMBER macro to determine if building with >>> LibreSSL instead of OpenSSL. This is pretty straightforward, since >>> it is eno

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-27 Thread Marek Behun
On Fri, 27 Jan 2017 18:41:09 + Mark Thompson wrote: > On 27/01/17 17:31, Marek Behún wrote: > > Use the LIBRESSL_VERSION_NUMBER macro to determine if building with > > LibreSSL instead of OpenSSL. This is pretty straightforward, since > > it is enough to add this check to existing #if macros.

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-27 Thread Mark Thompson
On 27/01/17 17:31, Marek Behún wrote: > Use the LIBRESSL_VERSION_NUMBER macro to determine if building with > LibreSSL instead of OpenSSL. This is pretty straightforward, since > it is enough to add this check to existing #if macros. > > Signed-off-by: Marek Behun > --- > libavformat/tls_openssl

[FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-27 Thread Marek Behún
Use the LIBRESSL_VERSION_NUMBER macro to determine if building with LibreSSL instead of OpenSSL. This is pretty straightforward, since it is enough to add this check to existing #if macros. Signed-off-by: Marek Behun --- libavformat/tls_openssl.c | 12 ++-- 1 file changed, 6 insertions(+