Am 16.02.2018 um 20:01 schrieb Aman Gupta:
>> +if(flags & 0x01) {
>
> Please add a space after "if" here.
>
>> +if(language[0])
>
> Same, missing space.
OK, I will add the spaces. And also add the respective field names as
comments, as you did for the mix_type.
_
On Thu, Feb 15, 2018 at 4:11 AM, Stefan Pöschel wrote:
> The supplementary audio descriptor is defined in ETSI EN 300 468 and
> provides more details regarding accessibility audio tracks, especially
> the normative annex J contains a detailed description of its use.
>
> Its language code (if pres
Am 16.02.2018 um 05:10 schrieb Aman Gupta:
> One option would be to re-use an existing flag.
>
> AV_DISPOSITION_CLEAN_EFFECTS seems to have a similar meaning, but is
> already used for a different purpose in mpegts.c
Right, so this would not be a distinct indicator.
> Another option is AV_DISPOS
On Thu, Feb 15, 2018 at 12:33 PM, Stefan Pöschel
wrote:
> Am 15.02.2018 um 20:52 schrieb Aman Gupta:
> > Patch looks reasonable to me.
>
> Great!
>
> > It might also be worth surfacing when the audio descriptor flags contain
> > mix_type=0, as this indicates a dependent stream which cannot be pla
Am 15.02.2018 um 20:52 schrieb Aman Gupta:
> Patch looks reasonable to me.
Great!
> It might also be worth surfacing when the audio descriptor flags contain
> mix_type=0, as this indicates a dependent stream which cannot be played
> standalone.
Yes, this seems to be useful, as both mixing types
On Thu, Feb 15, 2018 at 4:12 AM Stefan Pöschel wrote:
> The supplementary audio descriptor is defined in ETSI EN 300 468 and
> provides more details regarding accessibility audio tracks, especially
> the normative annex J contains a detailed description of its use.
>
> Its language code (if prese
The supplementary audio descriptor is defined in ETSI EN 300 468 and
provides more details regarding accessibility audio tracks, especially
the normative annex J contains a detailed description of its use.
Its language code (if present) overrides the language code of an also
present ISO 639 langua
