Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-12-23 Thread manuelyuan
thank you,I learned At 2019-12-16 06:17:33, "Martin Storsjö" wrote: >On Tue, 10 Dec 2019, manuelyuan wrote: > >> I opened a ticket in https://trac.ffmpeg.org/ticket/8420 >> my patch may be not absolutely right, but this problem should get your >> attention, thank you > >I sent a patch that doesn

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-12-15 Thread Martin Storsjö
On Tue, 10 Dec 2019, manuelyuan wrote: I opened a ticket in https://trac.ffmpeg.org/ticket/8420 my patch may be not absolutely right, but this problem should get your attention, thank you I sent a patch that doesn't mess up all the details in the fragmentation, but only changes the calculati

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-12-09 Thread manuelyuan
I opened a ticket in https://trac.ffmpeg.org/ticket/8420 my patch may be not absolutely right, but this problem should get your attention, thank you At 2019-12-03 20:57:44, "Martin Storsjö" wrote: >On Thu, 28 Nov 2019, manuelyuan wrote: > >> There are many UGC videos with dynamic frame rates,

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-12-03 Thread Martin Storsjö
On Thu, 28 Nov 2019, manuelyuan wrote: There are many UGC videos with dynamic frame rates, which are represented by PTS jumps. After transcoding with ffmpeg -vsync 0 or -vsync 2, the output video duration becomes longer. Did you post any reproduction case of what, exactly (which field in which

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-29 Thread Martin Storsjö
On Fri, 29 Nov 2019, manuelyuan wrote: Of course I did,and I can give you the bad case videos for your analysis if you need. How can I give them to you? FWIW, I would like to have a closer look at this patch when I get time (within a couple days), so a detailed explanation (including samples)

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-29 Thread Carl Eugen Hoyos
> Am 29.11.2019 um 08:44 schrieb manuelyuan : > > Of course I did,and I can give you the bad case videos for your analysis if > you need. > How can I give them to you? I don’t have access to a stream analyser so it won’t necessarily help (me) to provide the samples but you could mention in t

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-29 Thread myp...@gmail.com
On Fri, Nov 29, 2019 at 3:44 PM manuelyuan wrote: > > Of course I did,and I can give you the bad case videos for your analysis if > you need. > How can I give them to you? > > At 2019-11-28 14:38:34, "Carl Eugen Hoyos" wrote: > > > > > >> Am 28.11.2019 um 03:34 schrieb manuelyuan : > >> > >> In

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-28 Thread manuelyuan
Of course I did,and I can give you the bad case videos for your analysis if you need. How can I give them to you? At 2019-11-28 14:38:34, "Carl Eugen Hoyos" wrote: > > >> Am 28.11.2019 um 03:34 schrieb manuelyuan : >> >> In this case, the input video is of dynamic frame rate and we don't want

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-27 Thread Carl Eugen Hoyos
> Am 28.11.2019 um 03:34 schrieb manuelyuan : > > In this case, the input video is of dynamic frame rate and we don't want to > duplicate or drop frames, but the output video duration calculated by DTS is > incorrect, I solved it by using PTS. > There are many UGC videos with dynamic frame rates

[FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-27 Thread manuelyuan
In this case, the input video is of dynamic frame rate and we don't want to duplicate or drop frames, but the output video duration calculated by DTS is incorrect, I solved it by using PTS. There are many UGC videos with dynamic frame rates, which are represented by PTS jumps. After transcoding wit

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-13 Thread manuelyuan
ensure make fate works, please take a look At 2019-11-08 12:12:58, "manuelyuan" wrote: >From: Mengyang Yuan > >In this case, the input video is of dynamic frame rate and we don't want to >duplicate or drop frames, but the output video duration calculated by DTS is >incorrect, I solved it by us

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-08 Thread Steven Liu
> 在 2019年11月8日,11:58,manuelyuan 写道: > > I have try to make fate again and it still works, I do not know why it breaks > fate-binsub-movtextenc on your side > My steps are: > 1、./configure > 2、make fate > If I'm wrong, what should I do? ./configure need add one parameter: --samples=fate-suite/

[FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-07 Thread manuelyuan
From: Mengyang Yuan In this case, the input video is of dynamic frame rate and we don't want to duplicate or drop frames, but the output video duration calculated by DTS is incorrect, I solved it by using PTS. There are many UGC videos with dynamic frame rates, which are represented by PTS jumps.

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-07 Thread myp...@gmail.com
On Fri, Nov 8, 2019 at 10:58 AM manuelyuan wrote: > > I have try to make fate again and it still works, I do not know why it breaks > fate-binsub-movtextenc on your side > My steps are: > 1、./configure > 2、make fate > If I'm wrong, what should I do? > > > At 2019-11-08 02:21:16, "Michael Niederma

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-07 Thread manuelyuan
I have try to make fate again and it still works, I do not know why it breaks fate-binsub-movtextenc on your side My steps are: 1、./configure 2、make fate If I'm wrong, what should I do? At 2019-11-08 02:21:16, "Michael Niedermayer" wrote: >On Thu, Nov 07, 2019 at 05:55:18PM +0800, manuelyuan w

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-07 Thread Michael Niedermayer
On Thu, Nov 07, 2019 at 05:55:18PM +0800, manuelyuan wrote: > From: Mengyang Yuan > > In this case, the input video is of dynamic frame rate and we don't want to > duplicate or drop frames, but the output video duration calculated by DTS is > incorrect, I solved it by using PTS. > There are many

[FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-07 Thread manuelyuan
From: Mengyang Yuan In this case, the input video is of dynamic frame rate and we don't want to duplicate or drop frames, but the output video duration calculated by DTS is incorrect, I solved it by using PTS. There are many UGC videos with dynamic frame rates, which are represented by PTS jumps.

[FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-07 Thread manuelyuan
From: Mengyang Yuan In this case, the input video is of dynamic frame rate and we don't want to duplicate or drop frames, but the output video duration calculated by DTS is incorrect, I solved it by using PTS. There are many UGC videos with dynamic frame rates, which are represented by PTS jumps.

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-07 Thread manuelyuan
Thanks for your reply! My changes break make fate but this is inevitable. I will update the corresponding references to make sure make fate success At 2019-11-07 00:47:42, "Michael Niedermayer" wrote: >On Wed, Nov 06, 2019 at 10:36:11AM +0800, manuelyuan wrote: >> From: Mengyang Yuan >> >>

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-06 Thread Michael Niedermayer
On Wed, Nov 06, 2019 at 10:36:11AM +0800, manuelyuan wrote: > From: Mengyang Yuan > > In this case, the input video is of dynamic frame rate and we don't want to > duplicate or drop frames, but the output video duration calculated by DTS is > incorrect, I solved it by using PTS. > There are many

[FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

2019-11-05 Thread manuelyuan
From: Mengyang Yuan In this case, the input video is of dynamic frame rate and we don't want to duplicate or drop frames, but the output video duration calculated by DTS is incorrect, I solved it by using PTS. There are many UGC videos with dynamic frame rates, which are represented by PTS jumps.