Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-29 Thread Hendrik Leppkes
On Mon, Feb 29, 2016 at 2:41 PM, Nicolas George wrote: > >> I don't quite understand: Is there something that needs to be fixed in >> the existing md5enc code? > > Apparently not, which means I am misremembering something. > You just can't reuse the classes for mutliple components, options are fi

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-29 Thread Nicolas George
Le primidi 11 ventôse, an CCXXIV, Moritz Barsnick a écrit : > I would like to propose a (quite trivial) patch renaming first the > sources, then the muxers, and of course aliasing the existing muxer > names. No objection from me. If you manage to make it so that the default is MD5 when the name is

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-29 Thread Moritz Barsnick
On Fri, Feb 19, 2016 at 17:51:00 +0100, Nicolas George wrote: > Changing the name of existing muxers is annoying, but for new features I > would like much better if we did not wave around the name of a hash function > that has known vulnerabilities since 20 years: "streamhash" would be an > obvious

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-20 Thread Nicolas George
Le duodi 2 ventôse, an CCXXIV, Moritz Barsnick a écrit : > md5enc is literally waiting to become "hashenc": Yes, of course. But changing the name or the default hash, both theoretically a good thing, would break user scripts, it can not be done lightly. Regards, -- Nicolas George signature.

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-20 Thread Moritz Barsnick
On Fri, Feb 19, 2016 at 17:51:00 +0100, Nicolas George wrote: > Changing the name of existing muxers is annoying, but for new features I > would like much better if we did not wave around the name of a hash function > that has known vulnerabilities since 20 years: "streamhash" would be an > obvious

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-19 Thread Remko Tronçon
Hi Nicolas, Thanks for the comments. On 19 February 2016 at 17:51, Nicolas George wrote: > but I am rather dubious about the > usefulness of that: you could mux the streams independently to the md5 > muxer. > I did not find a way to do this without having to first probe each file to get a list

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-19 Thread Nicolas George
Le primidi 1er ventôse, an CCXXIV, Remko Tronçon a écrit : > Signed-off-by: Remko Tronçon > --- > This patch introduces a new 'streammd5' muxer. > Similarly to the 'md5' and 'framemd5' muxer, it is used to compute > the hash of media. However, I needed something in between both, to > be able to qu

[FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-19 Thread Remko Tronçon
Signed-off-by: Remko Tronçon --- This patch introduces a new 'streammd5' muxer. Similarly to the 'md5' and 'framemd5' muxer, it is used to compute the hash of media. However, I needed something in between both, to be able to quickly see which streams are identical across different files. I did no