On 2024-12-30 20:25 +0200, Rémi Denis-Courmont wrote:
> Le tiistaina 24. joulukuuta 2024, 15.30.00 EET Nuo Mi a écrit :
> > On Mon, Dec 23, 2024 at 11:18 PM flow gg wrote:
> > > Hi, It looks like you submitted your review comments not long after the
> > > patch was merged.
> > >
> > > Previously,
> Yes but there was only a day and a half between v2_2 and my comments, and
> that's way too short.
Hi, the timing feels a bit unclear here because it's v2_2, not v3, as I
only resolved the conflict (#elif ARCH_WASM was newly added) and made no
other changes.
Rémi Denis-Courmont 于2024年12月31日周二 0
Le tiistaina 24. joulukuuta 2024, 15.30.00 EET Nuo Mi a écrit :
> On Mon, Dec 23, 2024 at 11:18 PM flow gg wrote:
> > Hi, It looks like you submitted your review comments not long after the
> > patch was merged.
> >
> > Previously, regarding the VVC avg patch, you mentioned "LGTM for the
> > RISC
On Mon, Dec 23, 2024 at 11:18 PM flow gg wrote:
> Hi, It looks like you submitted your review comments not long after the
> patch was merged.
>
> Previously, regarding the VVC avg patch, you mentioned "LGTM for the RISC-V
> side. No clue about the VVC side",
> so I contacted Nuomi in the hope tha
Hi, It looks like you submitted your review comments not long after the
patch was merged.
Previously, regarding the VVC avg patch, you mentioned "LGTM for the RISC-V
side. No clue about the VVC side",
so I contacted Nuomi in the hope that he could help merge the patch that
had been pending for a w
Hello,
I remember agreeing to rename files. I do not remember agreeing to merging this
new functionality. To the contrary, this patch had objections from me, and not
just about performance. The functional issues are not even addressed here.
Why the heck was this broken SAD code merged when the
> Don't clobber v8 here.
> Use vsub.vv here to avoid the sequential dependency.
Updated.
于2024年12月21日周六 20:22写道：
> From: sunyuechi
>
> ---
> libavcodec/riscv/vvc/vvc_sad_rvv.S | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libavcodec/riscv/vvc/vvc_sad_rvv.
From: sunyuechi
---
libavcodec/riscv/vvc/vvc_sad_rvv.S | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/riscv/vvc/vvc_sad_rvv.S
b/libavcodec/riscv/vvc/vvc_sad_rvv.S
index 341167be1f..f325deee17 100644
--- a/libavcodec/riscv/vvc/vvc_sad_rvv.S
+++ b/libavc
