Hi, It looks like you submitted your review comments not long after the patch was merged.
Previously, regarding the VVC avg patch, you mentioned "LGTM for the RISC-V side. No clue about the VVC side", so I contacted Nuomi in the hope that he could help merge the patch that had been pending for a while. Maybe I pinged too quickly, which led to a misunderstanding that everything was already fine. Please don’t be upset... Rémi Denis-Courmont <r...@remlab.net> 于2024年12月23日周一 19:42写道： > Hello, > > I remember agreeing to rename files. I do not remember agreeing to merging > this > new functionality. To the contrary, this patch had objections from me, and > not > just about performance. The functional issues are not even addressed here. > > Why the heck was this broken SAD code merged when the area maintainer (me) > had > unchallenged objections to it? > > And -1 because this is still broken. This should be reverted entirely. > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
