Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-24 Thread Anton Khirnov
Quoting James Almer (2021-01-23 19:38:57) > > If i apply the following, the output of three remuxing (codec copy) > tests change > > > diff --git a/libavformat/utils.c b/libavformat/utils.c > > index 8ac6bc04b8..0cdf3156a6 100644 > > --- a/libavformat/utils.c > > +++ b/libavformat/utils.c > > @@

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-23 Thread James Almer
On 1/23/2021 3:17 PM, Anton Khirnov wrote: Quoting James Almer (2021-01-21 14:29:22) On 1/21/2021 9:59 AM, Anton Khirnov wrote: Quoting James Almer (2021-01-09 18:47:17) The st->codec values are updated based on the lowres factor by avformat_find_stream_info() when it runs an instance of the d

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-23 Thread Anton Khirnov
Quoting James Almer (2021-01-21 14:29:22) > On 1/21/2021 9:59 AM, Anton Khirnov wrote: > > Quoting James Almer (2021-01-09 18:47:17) > >> The st->codec values are updated based on the lowres factor by > >> avformat_find_stream_info() when it runs an instance of the decoder > >> internally, > >> an

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-21 Thread James Almer
On 1/21/2021 9:59 AM, Anton Khirnov wrote: Quoting James Almer (2021-01-09 18:47:17) The st->codec values are updated based on the lowres factor by avformat_find_stream_info() when it runs an instance of the decoder internally, and the same thing happens in ffmpeg.c when we open ist->dec_ctx wit

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-21 Thread Anton Khirnov
Quoting James Almer (2021-01-09 18:47:17) > The st->codec values are updated based on the lowres factor by > avformat_find_stream_info() when it runs an instance of the decoder > internally, > and the same thing happens in ffmpeg.c when we open ist->dec_ctx with > avcodec_open2(), so these assignm

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-20 Thread James Almer
On 1/9/2021 2:47 PM, James Almer wrote: The st->codec values are updated based on the lowres factor by avformat_find_stream_info() when it runs an instance of the decoder internally, and the same thing happens in ffmpeg.c when we open ist->dec_ctx with avcodec_open2(), so these assignments are re

[FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-09 Thread James Almer
The st->codec values are updated based on the lowres factor by avformat_find_stream_info() when it runs an instance of the decoder internally, and the same thing happens in ffmpeg.c when we open ist->dec_ctx with avcodec_open2(), so these assignments are redundant. Signed-off-by: James Almer ---