Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-24 Thread Richard Shaffer
On Tue, Jan 23, 2018 at 6:15 PM, James Almer wrote: > > > ffprobe -show_format is probably best for an id3v2 tag. Add a new > probeformat() function to fate-run.sh like > > probeformat(){ > run ffprobe${PROGSUF} -show_format -v 0 "$@" > } > > Then call it with the sample in question a argument

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread James Almer
On 1/23/2018 10:46 PM, wm4 wrote: > On Tue, 23 Jan 2018 17:03:26 -0800 > Richard Shaffer wrote: > >> On Tue, Jan 23, 2018 at 2:32 PM, wm4 wrote: >> >>> >>> I think this test program is pretty nice, though usually we try to get >>> by with running the "ffmpeg" utility to test the libs. Having a >

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread wm4
On Tue, 23 Jan 2018 17:03:26 -0800 Richard Shaffer wrote: > On Tue, Jan 23, 2018 at 2:32 PM, wm4 wrote: > > > > > I think this test program is pretty nice, though usually we try to get > > by with running the "ffmpeg" utility to test the libs. Having a > > relatively big program to test some ob

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread Richard Shaffer
On Tue, Jan 23, 2018 at 2:32 PM, wm4 wrote: > > I think this test program is pretty nice, though usually we try to get > by with running the "ffmpeg" utility to test the libs. Having a > relatively big program to test some obscure functionality might have a > maintenance burden. I'm not sure how

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread wm4
On Tue, 23 Jan 2018 09:54:38 -0800 rshaf...@tunein.com wrote: > From: Richard Shaffer > > Adds basic unit tests for parsing and writing ID3v2 tags. > --- > This requires the patch to "add option to parse/store ID3 PRIV tags in > metadata." > > libavformat/Makefile | 3 +- > libavform

[FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread rshaffer
From: Richard Shaffer Adds basic unit tests for parsing and writing ID3v2 tags. --- This requires the patch to "add option to parse/store ID3 PRIV tags in metadata." libavformat/Makefile | 3 +- libavformat/tests/.gitignore | 1 + libavformat/tests/id3v2.c| 229 +