Re: [FFmpeg-devel] [PATCH] avformat: add a TTA Muxer

2016-08-04 Thread James Almer
On 8/4/2016 3:38 PM, Michael Niedermayer wrote: > On Sun, Jul 31, 2016 at 01:03:45PM -0300, James Almer wrote: >> Signed-off-by: James Almer > [...] >> +#include "apetag.h" >> +#include "avformat.h" >> +#include "avio_internal.h" >> +#include "internal.h" >> + >> +typedef struct TTAMuxContext { >>

Re: [FFmpeg-devel] [PATCH] avformat: add a TTA Muxer

2016-08-04 Thread Michael Niedermayer
On Sun, Jul 31, 2016 at 01:03:45PM -0300, James Almer wrote: > Signed-off-by: James Almer [...] > +#include "apetag.h" > +#include "avformat.h" > +#include "avio_internal.h" > +#include "internal.h" > + > +typedef struct TTAMuxContext { > +AVIOContext *seek_table; > +AVIOContext *data; > +

Re: [FFmpeg-devel] [PATCH] avformat: add a TTA Muxer

2016-08-04 Thread James Almer
On 7/31/2016 1:03 PM, James Almer wrote: > Signed-off-by: James Almer > --- > Changelog | 1 + > doc/general.texi| 2 +- > libavformat/Makefile| 1 + > libavformat/allformats.c| 2 +- > libavformat/avio_internal.h | 2 + > libavformat/aviobuf.c

Re: [FFmpeg-devel] [PATCH] avformat: add a TTA Muxer

2016-07-31 Thread Nicolas George
Le quartidi 14 thermidor, an CCXXIV, James Almer a écrit : > AVIOContext is public API. I can't change the update_checksum function > pointer and checksum field to use for example uint32_t just like that. > If anything not until the next major bump, for ABI reasons. I had not realized it was used

Re: [FFmpeg-devel] [PATCH] avformat: add a TTA Muxer

2016-07-31 Thread James Almer
On 7/31/2016 1:36 PM, Nicolas George wrote: > Le quartidi 14 thermidor, an CCXXIV, James Almer a écrit : >> Signed-off-by: James Almer >> --- >> Changelog | 1 + >> doc/general.texi| 2 +- >> libavformat/Makefile| 1 + >> libavformat/allformats.c|

Re: [FFmpeg-devel] [PATCH] avformat: add a TTA Muxer

2016-07-31 Thread Nicolas George
Le quartidi 14 thermidor, an CCXXIV, James Almer a écrit : > Signed-off-by: James Almer > --- > Changelog | 1 + > doc/general.texi| 2 +- > libavformat/Makefile| 1 + > libavformat/allformats.c| 2 +- > libavformat/avio_internal.h | 2 + > lib

[FFmpeg-devel] [PATCH] avformat: add a TTA Muxer

2016-07-31 Thread James Almer
Signed-off-by: James Almer --- Changelog | 1 + doc/general.texi| 2 +- libavformat/Makefile| 1 + libavformat/allformats.c| 2 +- libavformat/avio_internal.h | 2 + libavformat/aviobuf.c | 6 ++ libavformat/tta.c | 10 +-- li