On 7/31/2016 1:36 PM, Nicolas George wrote: > Le quartidi 14 thermidor, an CCXXIV, James Almer a écrit : >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> Changelog | 1 + >> doc/general.texi | 2 +- >> libavformat/Makefile | 1 + >> libavformat/allformats.c | 2 +- > >> libavformat/avio_internal.h | 2 + >> libavformat/aviobuf.c | 6 ++ > > Maybe put that part in a separate first patch?
Sure, done locally. > > >> +unsigned long ff_crcEDB88320_update(unsigned long checksum, const uint8_t >> *buf, >> + unsigned int len); > > I know the surrounding code is already using it, but long is absolutely not > the correct type here. AVIOContext is public API. I can't change the update_checksum function pointer and checksum field to use for example uint32_t just like that. If anything not until the next major bump, for ABI reasons. > > Regards, > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
