Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Michael Niedermayer
On Wed, Apr 01, 2020 at 03:28:06PM +0200, Matthieu Bouron wrote: > On Wed, Apr 01, 2020 at 01:04:58PM +0100, Derek Buitenhuis wrote: > > On 01/04/2020 09:52, Matthieu Bouron wrote: > > > --- > > > libavformat/img2dec.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > Looks correct, but a commi

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Matthieu Bouron
On Wed, Apr 01, 2020 at 04:29:16PM +0200, Carl Eugen Hoyos wrote: > Am Mi., 1. Apr. 2020 um 16:24 Uhr schrieb Matthieu Bouron > : > > > > On Wed, Apr 01, 2020 at 04:09:08PM +0200, Carl Eugen Hoyos wrote: > > > Am Mi., 1. Apr. 2020 um 15:48 Uhr schrieb Matthieu Bouron > > > : > > > > > > > > On Wed,

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Carl Eugen Hoyos
Am Mi., 1. Apr. 2020 um 16:24 Uhr schrieb Matthieu Bouron : > > On Wed, Apr 01, 2020 at 04:09:08PM +0200, Carl Eugen Hoyos wrote: > > Am Mi., 1. Apr. 2020 um 15:48 Uhr schrieb Matthieu Bouron > > : > > > > > > On Wed, Apr 01, 2020 at 03:38:45PM +0200, Carl Eugen Hoyos wrote: > > > > Am Mi., 1. Apr.

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Matthieu Bouron
On Wed, Apr 01, 2020 at 04:09:08PM +0200, Carl Eugen Hoyos wrote: > Am Mi., 1. Apr. 2020 um 15:48 Uhr schrieb Matthieu Bouron > : > > > > On Wed, Apr 01, 2020 at 03:38:45PM +0200, Carl Eugen Hoyos wrote: > > > Am Mi., 1. Apr. 2020 um 10:57 Uhr schrieb Matthieu Bouron > > > : > > > > > > > > --- > >

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Carl Eugen Hoyos
Am Mi., 1. Apr. 2020 um 15:48 Uhr schrieb Matthieu Bouron : > > On Wed, Apr 01, 2020 at 03:38:45PM +0200, Carl Eugen Hoyos wrote: > > Am Mi., 1. Apr. 2020 um 10:57 Uhr schrieb Matthieu Bouron > > : > > > > > > --- > > > libavformat/img2dec.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > >

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Derek Buitenhuis
On 01/04/2020 14:28, Matthieu Bouron wrote: > Would "Skips the DHT segment in jpeg_probe() to avoid looking for JPEG > markers in the DHT segment data" be OK ? Sounds OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Matthieu Bouron
On Wed, Apr 01, 2020 at 01:04:58PM +0100, Derek Buitenhuis wrote: > On 01/04/2020 09:52, Matthieu Bouron wrote: > > --- > > libavformat/img2dec.c | 1 + > > 1 file changed, 1 insertion(+) > > Looks correct, but a commit message explaining why would be good. > Would "Skips the DHT segment in jpe

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Matthieu Bouron
On Wed, Apr 01, 2020 at 03:38:45PM +0200, Carl Eugen Hoyos wrote: > Am Mi., 1. Apr. 2020 um 10:57 Uhr schrieb Matthieu Bouron > : > > > > --- > > libavformat/img2dec.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > > index 40f3e3d499e

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Carl Eugen Hoyos
Am Mi., 1. Apr. 2020 um 10:57 Uhr schrieb Matthieu Bouron : > > --- > libavformat/img2dec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > index 40f3e3d499e..93cd51c1932 100644 > --- a/libavformat/img2dec.c > +++ b/libavformat/img2dec.c > @

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Derek Buitenhuis
On 01/04/2020 09:52, Matthieu Bouron wrote: > --- > libavformat/img2dec.c | 1 + > 1 file changed, 1 insertion(+) Looks correct, but a commit message explaining why would be good. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ff

[FFmpeg-devel] [PATCH] avformat/img2dec: skip DHT segment in jpeg_probe()

2020-04-01 Thread Matthieu Bouron
--- libavformat/img2dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index 40f3e3d499e..93cd51c1932 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -775,6 +775,7 @@ static int jpeg_probe(const AVProbeData *p)