On Wed, Apr 01, 2020 at 03:28:06PM +0200, Matthieu Bouron wrote: > On Wed, Apr 01, 2020 at 01:04:58PM +0100, Derek Buitenhuis wrote: > > On 01/04/2020 09:52, Matthieu Bouron wrote: > > > --- > > > libavformat/img2dec.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > Looks correct, but a commit message explaining why would be good. > > > > Would "Skips the DHT segment in jpeg_probe() to avoid looking for JPEG > markers in the DHT segment data" be OK ?
i suspect that startcodes in a valid DHT are quite rare. It seems they arent disallowed by the spec, just that a valid table with such values would be a bit odd. In the bits array it would imply that basically all huffman codes are equal length. So iam not sure this patch will affect any real files, but its more proper to skip the DHT unless iam missing something. So with a clear commit message patch should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If the United States is serious about tackling the national security threats related to an insecure 5G network, it needs to rethink the extent to which it values corporate profits and government espionage over security.-Bruce Schneier
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
