Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-15 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > On 9/14/2015 7:49 PM, Carl Eugen Hoyos wrote: > > But nobody wants to send a patch with an updated > > commit message afaict. > > How is that important? Afaiu, it is the only objection that was raised. (But I am not a native speaker and may of course have misu

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-15 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > > that said, the patches are fine, the bugs are just in cases that > > > the there exist unanimous consent that they should be dropped > > > > Second patch attached that fixes ticket #2089 for me. Only the container bitrate is fixed now, patch for codec

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-14 Thread James Almer
On 9/14/2015 7:49 PM, Carl Eugen Hoyos wrote: > But nobody wants to send a patch with an updated commit message afaict. How is that important? If you're talking about stating somewhere that we're dropping ABI compatibility then the correct place is changelog, RELEASE_NOTES and/or APIChanges, not a

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-14 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 12:49:31AM +0200, Carl Eugen Hoyos wrote: > On Monday 14 September 2015 04:31:56 pm Michael Niedermayer wrote: > > On Mon, Sep 14, 2015 at 01:16:34AM +0200, Carl Eugen Hoyos wrote: > > > On Monday 14 September 2015 12:48:27 am Michael Niedermayer wrote: > > > > the entries i

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-14 Thread Carl Eugen Hoyos
On Monday 14 September 2015 04:31:56 pm Michael Niedermayer wrote: > On Mon, Sep 14, 2015 at 01:16:34AM +0200, Carl Eugen Hoyos wrote: > > On Monday 14 September 2015 12:48:27 am Michael Niedermayer wrote: > > > the entries in avcodec_options are wrong > > > > New patch attached. > > [...] > > > di

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-14 Thread Michael Niedermayer
On Mon, Sep 14, 2015 at 01:16:34AM +0200, Carl Eugen Hoyos wrote: > On Monday 14 September 2015 12:48:27 am Michael Niedermayer wrote: > > the entries in avcodec_options are wrong > > New patch attached. [...] > diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h > index d6a5c69

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-13 Thread Carl Eugen Hoyos
On Monday 14 September 2015 12:48:27 am Michael Niedermayer wrote: > the entries in avcodec_options are wrong New patch attached. Thank you, Carl Eugen diff --git a/doc/APIchanges b/doc/APIchanges index 958035c..415463a 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6 +15,10 @@ libavutil

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-13 Thread Michael Niedermayer
On Sun, Sep 13, 2015 at 11:19:00PM +0200, Carl Eugen Hoyos wrote: > On Sunday 13 September 2015 12:30:20 am Michael Niedermayer wrote: > > On Sat, Sep 12, 2015 at 07:52:42PM +0200, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached is a new patch that should be ready to be applied > > > no mat

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-13 Thread Carl Eugen Hoyos
On Sunday 13 September 2015 12:30:20 am Michael Niedermayer wrote: > On Sat, Sep 12, 2015 at 07:52:42PM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached is a new patch that should be ready to be applied > > no matter if we drop compatibility or not. > > > > Please comment (quickly if possib

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-12 Thread Michael Niedermayer
On Sat, Sep 12, 2015 at 07:52:42PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached is a new patch that should be ready to be applied no matter if we > drop compatibility or not. > > Please comment (quickly if possible), Carl Eugen i think there are a few changes missing: libavcodec/cook.c: I

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-12 Thread Carl Eugen Hoyos
Hi! Attached is a new patch that should be ready to be applied no matter if we drop compatibility or not. Please comment (quickly if possible), Carl Eugen diff --git a/doc/APIchanges b/doc/APIchanges index 958035c..415463a 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6 +15,10 @@ libav

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-08 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > This would break the fork ABI compatibility option > and theres a IRC meeting sheduled on saturday to > discuss the "ABI compatibility policy" > > I wont apply this before the meeting, that would > be kind of wrong You could apply it with "#if INCOMPATIB

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-08 Thread Michael Niedermayer
On Tue, Sep 08, 2015 at 09:46:42AM +, Carl Eugen Hoyos wrote: > Michael Niedermayer gmx.at> writes: > > > a 32bit bitrate is insufficient for high resolution, > > high framerate material an example would be rawvideo > > Ping? This would break the fork ABI compatibility option and theres a

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-08 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > a 32bit bitrate is insufficient for high resolution, > high framerate material an example would be rawvideo Ping? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-03 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > a 32bit bitrate is insufficient for high resolution, > high framerate material an example would be rawvideo Please mention ticket #2089 if it is fixed by this commit. Thanks, Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread compn
On Wed, 2 Sep 2015 14:06:43 -0700 Ganesh Ajjanagadde wrote: > On Wed, Sep 2, 2015 at 1:57 PM, wm4 wrote: > > On Wed, 2 Sep 2015 16:49:41 -0400 > > "Ronald S. Bultje" wrote: > > > >> Hi, > >> > >> On Wed, Sep 2, 2015 at 4:47 PM, Ganesh Ajjanagadde > >> wrote: > >> > >> > On Wed, Sep 2, 2015 at

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread wm4
On Wed, 2 Sep 2015 14:06:43 -0700 Ganesh Ajjanagadde wrote: > On Wed, Sep 2, 2015 at 1:57 PM, wm4 wrote: > > On Wed, 2 Sep 2015 16:49:41 -0400 > > "Ronald S. Bultje" wrote: > > > >> Hi, > >> > >> On Wed, Sep 2, 2015 at 4:47 PM, Ganesh Ajjanagadde > >> wrote: > >> > >> > On Wed, Sep 2, 2015 at

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread Ronald S. Bultje
Hi Ganesh, On Wed, Sep 2, 2015 at 5:06 PM, Ganesh Ajjanagadde wrote: > On Wed, Sep 2, 2015 at 1:57 PM, wm4 wrote: > > On Wed, 2 Sep 2015 16:49:41 -0400 > > "Ronald S. Bultje" wrote: > > > >> Hi, > >> > >> On Wed, Sep 2, 2015 at 4:47 PM, Ganesh Ajjanagadde > wrote: > >> > >> > On Wed, Sep 2, 2

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread Ganesh Ajjanagadde
On Wed, Sep 2, 2015 at 1:57 PM, wm4 wrote: > On Wed, 2 Sep 2015 16:49:41 -0400 > "Ronald S. Bultje" wrote: > >> Hi, >> >> On Wed, Sep 2, 2015 at 4:47 PM, Ganesh Ajjanagadde wrote: >> >> > On Wed, Sep 2, 2015 at 1:20 PM, Michael Niedermayer >> > wrote: >> > > From: Michael Niedermayer >> > > >>

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread wm4
On Wed, 2 Sep 2015 16:49:41 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Wed, Sep 2, 2015 at 4:47 PM, Ganesh Ajjanagadde wrote: > > > On Wed, Sep 2, 2015 at 1:20 PM, Michael Niedermayer > > wrote: > > > From: Michael Niedermayer > > > > > > a 32bit bitrate is insufficient for high resolution

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread wm4
On Wed, 2 Sep 2015 22:20:40 +0200 Michael Niedermayer wrote: > From: Michael Niedermayer > > a 32bit bitrate is insufficient for high resolution, high framerate material > an example would be rawvideo > > Not all changes are covered by #if as its easier to just push when the > bump is done in

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread Michael Niedermayer
On Wed, Sep 02, 2015 at 01:47:07PM -0700, Ganesh Ajjanagadde wrote: > On Wed, Sep 2, 2015 at 1:20 PM, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > a 32bit bitrate is insufficient for high resolution, high framerate material > > an example would be rawvideo > > > > Not all chan

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread Ronald S. Bultje
Hi, On Wed, Sep 2, 2015 at 4:47 PM, Ganesh Ajjanagadde wrote: > On Wed, Sep 2, 2015 at 1:20 PM, Michael Niedermayer > wrote: > > From: Michael Niedermayer > > > > a 32bit bitrate is insufficient for high resolution, high framerate > material > > an example would be rawvideo > > > > Not all cha

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread Ganesh Ajjanagadde
On Wed, Sep 2, 2015 at 1:20 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > a 32bit bitrate is insufficient for high resolution, high framerate material > an example would be rawvideo > > Not all changes are covered by #if as its easier to just push when the > bump is done instead

[FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-02 Thread Michael Niedermayer
From: Michael Niedermayer a 32bit bitrate is insufficient for high resolution, high framerate material an example would be rawvideo Not all changes are covered by #if as its easier to just push when the bump is done instead of making it coditional and removig the conditionallity again Signed-o