Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/16/2017 12:38 AM, Carl Eugen Hoyos wrote: > 2017-11-16 3:51 GMT+01:00 James Almer : > >> gcc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-strict-overflow >> -fstack-protector-all -fPIE -c -o /tmp/ffconf.OTilhXct/test.o >> /tmp/ffconf.OTilhXct/test.c >> gcc -Wl,-z,relro -Wl,-z,now -fPIE -pie -o

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

2017-11-16 3:51 GMT+01:00 James Almer : > gcc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-strict-overflow > -fstack-protector-all -fPIE -c -o /tmp/ffconf.OTilhXct/test.o > /tmp/ffconf.OTilhXct/test.c > gcc -Wl,-z,relro -Wl,-z,now -fPIE -pie -o /tmp/ffconf.OTilhXct/test.exe > /tmp/ffconf.OTilhXct/te

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/16/2017 12:04 AM, James Almer wrote: > On 11/15/2017 11:55 PM, Carl Eugen Hoyos wrote: >> 2017-11-16 3:51 GMT+01:00 James Almer : >> >>> configure can't even succeed with --toolchain=hardened on mingw-w64, so >>> looks like i wouldn't have been able to reproduce it to begin with. >> >> Try re

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/15/2017 11:55 PM, Carl Eugen Hoyos wrote: > 2017-11-16 3:51 GMT+01:00 James Almer : > >> configure can't even succeed with --toolchain=hardened on mingw-w64, so >> looks like i wouldn't have been able to reproduce it to begin with. > > Try replacing toolchain with --extra-cflags=-fstack-pro

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

2017-11-16 3:51 GMT+01:00 James Almer : > configure can't even succeed with --toolchain=hardened on mingw-w64, so > looks like i wouldn't have been able to reproduce it to begin with. Try replacing toolchain with --extra-cflags=-fstack-protector-all: $ configure --extra-cflags=-fstack-protector-a

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/15/2017 11:01 PM, Carl Eugen Hoyos wrote: > 2017-11-16 2:52 GMT+01:00 James Almer : >> On 11/15/2017 10:35 PM, Carl Eugen Hoyos wrote: >>> 2017-11-16 2:29 GMT+01:00 James Almer : >>> The OP configure line is a massive dump of pointless "--disable" options typical from Gentoo builds,

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

2017-11-16 2:52 GMT+01:00 James Almer : > On 11/15/2017 10:35 PM, Carl Eugen Hoyos wrote: >> 2017-11-16 2:29 GMT+01:00 James Almer : >> >>> The OP configure line is a massive dump of pointless >>> "--disable" options typical from Gentoo builds, >> >> Good to know we agree on something. >> >>> so i

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/15/2017 10:35 PM, Carl Eugen Hoyos wrote: > 2017-11-16 2:29 GMT+01:00 James Almer : > >> The OP configure line is a massive dump of pointless >> "--disable" options typical from Gentoo builds, > > Good to know we agree on something. > >> so i didn't even bother looking at it for specific t

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

2017-11-16 2:29 GMT+01:00 James Almer : > The OP configure line is a massive dump of pointless > "--disable" options typical from Gentoo builds, Good to know we agree on something. > so i didn't even bother looking at it for specific things. > And now that i look at yours they are completely di

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/15/2017 9:50 PM, Carl Eugen Hoyos wrote: > 2017-11-16 1:49 GMT+01:00 James Almer : >> On 11/15/2017 9:33 PM, Carl Eugen Hoyos wrote: >>> 2017-11-16 1:29 GMT+01:00 James Almer : On 11/15/2017 9:21 PM, Carl Eugen Hoyos wrote: > 2017-11-16 1:14 GMT+01:00 James Almer : >> Should fix

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

2017-11-16 1:49 GMT+01:00 James Almer : > On 11/15/2017 9:33 PM, Carl Eugen Hoyos wrote: >> 2017-11-16 1:29 GMT+01:00 James Almer : >>> On 11/15/2017 9:21 PM, Carl Eugen Hoyos wrote: 2017-11-16 1:14 GMT+01:00 James Almer : > Should fix ticket #6838 > Untested as i can't reproduce.

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/15/2017 9:33 PM, Carl Eugen Hoyos wrote: > 2017-11-16 1:29 GMT+01:00 James Almer : >> On 11/15/2017 9:21 PM, Carl Eugen Hoyos wrote: >>> 2017-11-16 1:14 GMT+01:00 James Almer : Should fix ticket #6838 >>> Untested as i can't reproduce. >>> >>> What did you try? >> >> GCC 7.2.0 mingw

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

2017-11-16 1:29 GMT+01:00 James Almer : > On 11/15/2017 9:21 PM, Carl Eugen Hoyos wrote: >> 2017-11-16 1:14 GMT+01:00 James Almer : >>> Should fix ticket #6838 >> >>> Untested as i can't reproduce. >> >> What did you try? > > GCC 7.2.0 mingw-w64 x86_64. The buffers were sufficiently > aligned every

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

On 11/15/2017 9:21 PM, Carl Eugen Hoyos wrote: > 2017-11-16 1:14 GMT+01:00 James Almer : >> Should fix ticket #6838 > >> Untested as i can't reproduce. > > What did you try? GCC 7.2.0 mingw-w64 x86_64. The buffers were sufficiently aligned every time i decoded the file without this patch. > >

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

2017-11-16 1:14 GMT+01:00 James Almer : > Should fix ticket #6838 > Untested as i can't reproduce. What did you try? Thank you! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/proresdec: align dequantization matrix buffers

Should fix ticket #6838 Signed-off-by: James Almer --- Untested as i can't reproduce. libavcodec/proresdec2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index e9e0153ee9..d97e264e44 100644 --- a/libavcodec/proresdec2