On Thu, Aug 29, 2019 at 10:30 PM Nicolas George wrote:
> Aman Gupta (12019-08-29):
> > > > -in_port_params.format.video.xFramerate = (1 << 16) *
> > > avctx->framerate.num / avctx->framerate.den;
> > > > +in_port_params.format.video.xFramerate = (int64_t)(1 << 16)
> *
> > > avctx-
Aman Gupta (12019-08-29):
> > > -in_port_params.format.video.xFramerate = (1 << 16) *
> > avctx->framerate.num / avctx->framerate.den;
> > > +in_port_params.format.video.xFramerate = (int64_t)(1 << 16) *
> > avctx->framerate.num / avctx->framerate.den;
> >
> > change 1 > 1LL is more
On Thu, Aug 29, 2019 at 5:56 PM Limin Wang wrote:
> On Thu, Aug 29, 2019 at 05:30:25PM -0700, Aman Gupta wrote:
> > From: Aman Gupta
> >
> > Integer overflow in the Q16 framerate calculation was sending
> > invalid values to the OMX encoder.
> >
> > On the RPI4, this manifested as bitrate contro
On Thu, Aug 29, 2019 at 05:30:25PM -0700, Aman Gupta wrote:
> From: Aman Gupta
>
> Integer overflow in the Q16 framerate calculation was sending
> invalid values to the OMX encoder.
>
> On the RPI4, this manifested as bitrate controls being ignored
> on video streams with 6/1001 framerates.
From: Aman Gupta
Integer overflow in the Q16 framerate calculation was sending
invalid values to the OMX encoder.
On the RPI4, this manifested as bitrate controls being ignored
on video streams with 6/1001 framerates. Video streams with
3/1001 framerates were not affected.
Signed-off-by
