Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-10-14 Thread Timo Rothenpieler
On 14.10.2019 17:43, Hendrik Leppkes wrote: Since some users seem to have blindly passed -refs to their commandline which now fails without really telling them why, any thoughts on moving the capability check error messages onto a high log level so that they are shown by default, since they are t

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-10-14 Thread Hendrik Leppkes
On Fri, Sep 27, 2019 at 8:07 PM Timo Rothenpieler wrote: > > applied, but after some discussion on IRC, I opted to rename the current > -refs option to -dpb_size, and use -refs for this one. > > -refs now matches what libx264 uses it for and what probably the > majority of users expect. Since som

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-09-27 Thread Timo Rothenpieler
applied, but after some discussion on IRC, I opted to rename the current -refs option to -dpb_size, and use -refs for this one. -refs now matches what libx264 uses it for and what probably the majority of users expect. ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-09-27 Thread Carl Eugen Hoyos
Am Fr., 27. Sept. 2019 um 14:15 Uhr schrieb Timo Rothenpieler : > > On 27/09/2019 12:28, Roman Arzumanyan wrote: > >> First, this needs SDK Version Guards > > Thanks, I've missed that. Added to patch. > > >> Second, in what way is this different from the existing global > >> option(avctx->refs), w

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-09-27 Thread Timo Rothenpieler
On 27/09/2019 12:28, Roman Arzumanyan wrote: First, this needs SDK Version Guards Thanks, I've missed that. Added to patch. Second, in what way is this different from the existing global option(avctx->refs), which nvenc.c already uses to set It's slightly different from existing global opti

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-09-27 Thread Roman Arzumanyan
eler Sent: Friday, September 27, 2019 12:56 PM To: FFmpeg development discussions and patches ; Roman Arzumanyan Cc: Yogender Gupta Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support On 27/09/2019 11:04, Roman Arzumanyan wrote: > Hello, > > This patch a

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-09-27 Thread Timo Rothenpieler
On 27/09/2019 11:04, Roman Arzumanyan wrote: Hello, This patch adds multiple reference frames support (part of Video Codec SDK 9.1). It adds "nb_ref_frames" CLI option to set number of reference frames. Possible values: * auto - let encoder decide (default value). * [0;7] - set value

[FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-09-27 Thread Roman Arzumanyan
Hello, This patch adds multiple reference frames support (part of Video Codec SDK 9.1). It adds "nb_ref_frames" CLI option to set number of reference frames. Possible values: * auto - let encoder decide (default value). * [0;7] - set value by hand. 0 is equal to auto. Usage example: ffm