Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-08-07 Thread Caleb Etemesi
Also apologies for a really late reply, Still learning about mail threads Kind regards. Caleb On Sun, 7 Aug 2022, 22:51 Michael Niedermayer, wrote: > On Sun, Aug 07, 2022 at 07:46:51PM +0300, Caleb Etemesi wrote: > > caleb is fine. > > ok will apply > > thx > > [...] > -- > Michael GnuPG

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-08-07 Thread Michael Niedermayer
On Sun, Aug 07, 2022 at 07:46:51PM +0300, Caleb Etemesi wrote: > caleb is fine. ok will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school:

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-08-07 Thread Caleb Etemesi
caleb is fine. On Sat, May 7, 2022 at 11:35 AM Michael Niedermayer wrote: > Hi > > before applying this > > Author: caleb > > If you want your full name there please resend this with your full name > so its in git with your full name. It cannot be > changed later if its pushed like this > > th

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-05-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Saturday, May 7, 2022 10:31 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if > HTJ2

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-05-07 Thread Michael Niedermayer
Hi before applying this Author: caleb If you want your full name there please resend this with your full name so its in git with your full name. It cannot be changed later if its pushed like this thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The educ

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-05-07 Thread Michael Niedermayer
On Fri, May 06, 2022 at 10:56:16AM -0700, Pierre-Anthony Lemieux wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote th

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-05-06 Thread Pierre-Anthony Lemieux
LGTM On Thu, May 5, 2022 at 11:56 PM caleb wrote: > > --- > libavcodec/jpeg2000.h| 2 ++ > libavcodec/jpeg2000dec.c | 4 > 2 files changed, 6 insertions(+) > > diff --git a/libavcodec/jpeg2000.h b/libavcodec/jpeg2000.h > index d06313425e..e5ecb4cbf9 100644 > --- a/libavcodec/jpeg2000.h

[FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-05-05 Thread caleb
--- libavcodec/jpeg2000.h| 2 ++ libavcodec/jpeg2000dec.c | 4 2 files changed, 6 insertions(+) diff --git a/libavcodec/jpeg2000.h b/libavcodec/jpeg2000.h index d06313425e..e5ecb4cbf9 100644 --- a/libavcodec/jpeg2000.h +++ b/libavcodec/jpeg2000.h @@ -110,6 +110,8 @@ enum Jpeg2000Quantsty

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000:fast-fail if HTJ2K codeblocks are present

2022-05-03 Thread Pierre-Anthony Lemieux
Hi Caleb, There is a space missing in the commit message before "fast-fail". Few minor comments below. Looks good otherwise -- it works as expected on an MXF file that contains JPEG 2000 Part 15 code-blocks. Looking forward to the full implementation! Best, -- Pierre On Tue, Apr 19, 2022 at

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000:fast-fail if HTJ2K codeblocks are present

2022-04-19 Thread Pierre-Anthony Lemieux
FYI. This is the qualification task for the GSOC project at [1]. [1] https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2022#AddsupportforPart15totheJPEG2000decoder On Tue, Apr 19, 2022 at 1:17 AM caleb wrote: > > --- > This patch adds support for detecting Part 15 codeblocks to JPEG2000 > s

[FFmpeg-devel] [PATCH] avcodec/jpeg2000:fast-fail if HTJ2K codeblocks are present

2022-04-19 Thread caleb
--- This patch adds support for detecting Part 15 codeblocks to JPEG2000 specified in (Rec. ITU-T T.814 | ISO/IEC 15444-15). The decoder on detecting Part 15 codeblocks now fails gracefully with a AVERROR_PATCHWELCOME return code libavcodec/jpeg2000.h| 2 ++ libavcodec/jpeg2000dec.c | 9 ++