Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-28 Thread Stefano Sabatini
On date Tuesday 2015-01-27 22:05:08 +0100, Michael Niedermayer encoded: > On Tue, Jan 27, 2015 at 06:32:13PM +0530, arwa arif wrote: > > On Tue, Jan 27, 2015 at 3:26 PM, Stefano Sabatini [...] > > I have included lut16 in the code. Also, I tested it with various options, > > and it is coming out t

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-27 Thread Michael Niedermayer
On Tue, Jan 27, 2015 at 06:32:13PM +0530, arwa arif wrote: > On Tue, Jan 27, 2015 at 3:26 PM, Stefano Sabatini > wrote: > > > On date Monday 2015-01-26 13:20:49 +0100, Michael Niedermayer encoded: > > > On Mon, Jan 26, 2015 at 11:31:49AM +0100, Christophe Gisquet wrote: > > [...] > > > > To me, i

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-27 Thread arwa arif
On Tue, Jan 27, 2015 at 3:26 PM, Stefano Sabatini wrote: > On date Monday 2015-01-26 13:20:49 +0100, Michael Niedermayer encoded: > > On Mon, Jan 26, 2015 at 11:31:49AM +0100, Christophe Gisquet wrote: > [...] > > > To me, it looks like just a normal > > > clipping is needed. > > > > yes > > > >

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-27 Thread Paul B Mahol
On 1/27/15, Stefano Sabatini wrote: > On date Monday 2015-01-26 13:20:49 +0100, Michael Niedermayer encoded: >> On Mon, Jan 26, 2015 at 11:31:49AM +0100, Christophe Gisquet wrote: > [...] >> > To me, it looks like just a normal >> > clipping is needed. >> >> yes >> >> also on a differnt topic, i t

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-27 Thread Stefano Sabatini
On date Monday 2015-01-26 13:20:49 +0100, Michael Niedermayer encoded: > On Mon, Jan 26, 2015 at 11:31:49AM +0100, Christophe Gisquet wrote: [...] > > To me, it looks like just a normal > > clipping is needed. > > yes > > also on a differnt topic, i think "gamma*" should be removed from > eq, the

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread Michael Niedermayer
On Mon, Jan 26, 2015 at 11:31:49AM +0100, Christophe Gisquet wrote: > Hi, > > so my comments are not aimed at that specific patch at all, but when looking > at: > > 2015-01-24 22:06 GMT+01:00 Paul B Mahol : > > +static void process_c(EQParameters *param, uint8_t *dst, int dst_stride, > > +

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread Christophe Gisquet
Hi, 2015-01-26 12:33 GMT+01:00 wm4 : > But it's faster! I'm not trying to bash nor troll anyone here, or to debate whether the filter and/or the asm should go, so please don't drag me into that particular crusade. I'd just like the filter and/or the asm to be fixed. And as I'

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread wm4
On Mon, 26 Jan 2015 11:31:49 +0100 Christophe Gisquet wrote: > Hi, > > so my comments are not aimed at that specific patch at all, but when looking > at: > > 2015-01-24 22:06 GMT+01:00 Paul B Mahol : > > +static void process_c(EQParameters *param, uint8_t *dst, int dst_stride, > > +

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread Christophe Gisquet
Hi, so my comments are not aimed at that specific patch at all, but when looking at: 2015-01-24 22:06 GMT+01:00 Paul B Mahol : > +static void process_c(EQParameters *param, uint8_t *dst, int dst_stride, > + uint8_t *src, int src_stride, int w, int h) > +{ > +int x, y, pel

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-25 Thread Michael Niedermayer
On Sat, Jan 24, 2015 at 09:06:33PM +, Paul B Mahol wrote: > From: Arwa Arif > > Code adapted from James Darnley's port > > Signed-off-by: Paul B Mahol merged with arwas latest patch and applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Ever

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-24 Thread Paul B Mahol
On 1/24/15, Paul B Mahol wrote: > From: Arwa Arif > > Code adapted from James Darnley's port > > Signed-off-by: Paul B Mahol > --- > configure| 1 + > doc/filters.texi | 43 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter

[FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-24 Thread Paul B Mahol
From: Arwa Arif Code adapted from James Darnley's port Signed-off-by: Paul B Mahol --- configure| 1 + doc/filters.texi | 43 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 4 +- libavfilter/vf_eq.c | 27