Quoting Amir Mazzarella (2022-07-19 23:21:00)
> Thank you for your response! A C++ compiler can't do implicit casts like a
> C compiler can, in this instance. This is fine for most of FFmpeg's
> codebase, since these tricks are in C source files, but in this instance it
> is in a header file. If an
Amir Mazzarella (12022-07-19):
> I understand that FFmpeg does not contain accommodations, but in my
> opinion it is less of an accommodation and more for readability, avoiding
> an implicit cast. An explicit void pointer cast, like the one presented in
The arguments against useless casts have bee
On Tue, Jul 19, 2022 at 2:24 PM Nicolas George wrote:
> Thanks for clarifying. I confess I had more or less guessed. FFmpeg is
> C, and its headers, public or not, as a rule do not contain
> accommodations to be included as is in other languages.
I understand that FFmpeg does not contain accommod
Amir Mazzarella (12022-07-19):
> Thank you for your response! A C++ compiler can't do implicit casts like a
> C compiler can, in this instance. This is fine for most of FFmpeg's
> codebase, since these tricks are in C source files, but in this instance it
> is in a header file. If any C++ code incl
On Tue, Jul 19, 2022 at 11:21 PM Amir Mazzarella
wrote:
>
> Thank you for your response! A C++ compiler can't do implicit casts like a
> C compiler can, in this instance. This is fine for most of FFmpeg's
> codebase, since these tricks are in C source files, but in this instance it
> is in a heade
Thank you for your response! A C++ compiler can't do implicit casts like a
C compiler can, in this instance. This is fine for most of FFmpeg's
codebase, since these tricks are in C source files, but in this instance it
is in a header file. If any C++ code includes this header file, even with
extern
Hi. Thanks for the patch.
Amir Mazzarella (12022-07-09):
> Signed-off-by: Amir Mazzarella
> ---
> libavutil/vulkan_loader.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/vulkan_loader.h b/libavutil/vulkan_loader.h
> index 3f1ee6aa46..fa8e5ed171 100644
> ---
Ping
On Fri, Jul 8, 2022 at 9:31 PM Amir Mazzarella wrote:
> Signed-off-by: Amir Mazzarella
> ---
> libavutil/vulkan_loader.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/vulkan_loader.h b/libavutil/vulkan_loader.h
> index 3f1ee6aa46..fa8e5ed171 100644
> -
Signed-off-by: Amir Mazzarella
---
libavutil/vulkan_loader.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/vulkan_loader.h b/libavutil/vulkan_loader.h
index 3f1ee6aa46..fa8e5ed171 100644
--- a/libavutil/vulkan_loader.h
+++ b/libavutil/vulkan_loader.h
@@ -82,7 +82,7