Thank you for your response! A C++ compiler can't do implicit casts like a C compiler can, in this instance. This is fine for most of FFmpeg's codebase, since these tricks are in C source files, but in this instance it is in a header file. If any C++ code includes this header file, even with extern "C", it won't be able to be compiled.
On Tue, Jul 19, 2022 at 12:08 PM Nicolas George <geo...@nsup.org> wrote: > Hi. Thanks for the patch. > > Amir Mazzarella (12022-07-09): > > Signed-off-by: Amir Mazzarella <amirm...@google.com> > > --- > > libavutil/vulkan_loader.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavutil/vulkan_loader.h b/libavutil/vulkan_loader.h > > index 3f1ee6aa46..fa8e5ed171 100644 > > --- a/libavutil/vulkan_loader.h > > +++ b/libavutil/vulkan_loader.h > > @@ -82,7 +82,7 @@ static inline int > ff_vk_load_functions(AVHWDeviceContext *ctx, > > uint64_t extensions_mask, > > int has_inst, int has_dev) > > { > > - AVVulkanDeviceContext *hwctx = ctx->hwctx; > > + AVVulkanDeviceContext *hwctx = (AVVulkanDeviceContext *) ctx->hwctx; > > > > static const struct FunctionLoadInfo { > > int req_inst; > > Why? What is it supposed to fix? > > Regards, > > -- > Nicolas George > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".