Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-21 Thread Petri Hintukainen
On ma, 2015-04-13 at 09:41 -0700, Philip Langdale wrote: > On 2015-04-13 03:39, Petri Hintukainen wrote: > > > > I don't know if it is a good idea to use HDMV stream types without HDMV > > program registration descriptor. If this is fixed incrementally, fixing > > should be started from the opposi

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-13 Thread Philip Langdale
On 2015-04-13 03:39, Petri Hintukainen wrote: I don't know if it is a good idea to use HDMV stream types without HDMV program registration descriptor. If this is fixed incrementally, fixing should be started from the opposite direction: - Using HDMV stream type requires HDMV registration descrip

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-13 Thread Petri Hintukainen
On su, 2015-04-12 at 16:40 -0700, Philip Langdale wrote: > On Sun, 12 Apr 2015 08:13:39 + (UTC) > Carl Eugen Hoyos wrote: > > > > I tested with samples from the following directories: > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket598/ > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/tick

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Philip Langdale
On Sun, 12 Apr 2015 23:53:21 + Timothy Gu wrote: > On Sun, Apr 12, 2015 at 4:41 PM Philip Langdale > wrote: > > > > So, this change is not a complete fix, but it's one of the necessary > > steps. > > > > That was what I suspected. I simply forwarded the patch from GitHub. > > Also I didn't

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Timothy Gu
On Sun, Apr 12, 2015 at 4:41 PM Philip Langdale wrote: > > So, this change is not a complete fix, but it's one of the necessary > steps. > That was what I suspected. I simply forwarded the patch from GitHub. Also I didn't notice the patch had some trailing spaces… Timothy __

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Philip Langdale
On Sun, 12 Apr 2015 08:13:39 + (UTC) Carl Eugen Hoyos wrote: > > I tested with samples from the following directories: > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket598/ > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket1722/ > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3820/ > >

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Carl Eugen Hoyos
Philip Langdale overt.org> writes: > On Sun, 12 Apr 2015 00:16:45 + (UTC) > Carl Eugen Hoyos ag.or.at> wrote: > > > Timothy Gu gmail.com> writes: > > > > > From: Niklesh Lalwani gmail.com> > > > > > > Fixes #2622. > > > > Which sample did you use for testing? > > I don't think we have

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-11 Thread Philip Langdale
On Sun, 12 Apr 2015 00:16:45 + (UTC) Carl Eugen Hoyos wrote: > Timothy Gu gmail.com> writes: > > > From: Niklesh Lalwani gmail.com> > > > > Fixes #2622. > > Which sample did you use for testing? I don't think we have a sample in FATE that has subtitles. I used one of my own bluray discs

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-11 Thread Carl Eugen Hoyos
Timothy Gu gmail.com> writes: > From: Niklesh Lalwani gmail.com> > > Fixes #2622. Which sample did you use for testing? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-11 Thread Timothy Gu
From: Niklesh Lalwani Fixes #2622. --- >From https://github.com/FFmpeg/FFmpeg/pull/125 libavformat/mpegts.h| 2 ++ libavformat/mpegtsenc.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/libavformat/mpegts.h b/libavformat/mpegts.h index 84f3098..f6a6551 100644 --- a/libavformat/mpe