On Sun, 12 Apr 2015 08:13:39 +0000 (UTC) Carl Eugen Hoyos <ceho...@ag.or.at> wrote: > > I tested with samples from the following directories: > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket598/ > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket1722/ > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3820/ > > None of them work for me with the patch. It seems I am > doing something wrong, could you explain how I should > test?
OK. I used: http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket598/00002_nosubs_detected.m2ts Then I did: ffmpeg -i 00002_nosubs_detected.m2ts -map 0 -c:v copy -c:a copy -c:s \ copy remux.m2ts and I played remux.m2ts successfully in mplayer with working subtitles. Now, the ffmpeg probe output will not look the same as the original file. You'll see: Stream #0:7[0x107], 0, 1/90000: Unknown: none ([144][0][0][0] / 0x0090) Stream #0:8[0x108], 0, 1/90000: Unknown: none ([144][0][0][0] / 0x0090) Stream #0:9[0x109], 0, 1/90000: Unknown: none ([144][0][0][0] / 0x0090) Stream #0:10[0x10a], 0, 1/90000: Unknown: none ([144][0][0][0] / 0x0090) Stream #0:11[0x10b], 0, 1/90000: Unknown: none ([144][0][0][0] / 0x0090) This change makes sure the 0x0090 type ID at the end is carried over during the copy operation. There is a bunch of separate metadata which needs to be copied for the 'Unknown' to be replaced by the right info for the pgs subtitles, but that's a separate lower level problem in the muxer - it doesn't appear to copy that info correctly in a whole class of types, where pgs is just one example. It does have implications. You can remux from a proper bluray m2ts and get a working file, but if you try and remux that output into a new file, everything fails because ffmpeg can't identify the subtitle tracks any more. So, this change is not a complete fix, but it's one of the necessary steps. --phil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
