Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread James Almer
On 11/21/2018 9:57 PM, Xiang, Haihao wrote: > On Wed, 2018-11-21 at 12:27 -0300, James Almer wrote: >> On 11/20/2018 11:47 PM, Haihao Xiang wrote: >>> This fixes the link errors below: >>> >>> LD ffmpeg_g >>> libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' >>> libavfilte

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Xiang, Haihao
On Wed, 2018-11-21 at 12:27 -0300, James Almer wrote: > On 11/20/2018 11:47 PM, Haihao Xiang wrote: > > This fixes the link errors below: > > > > LD ffmpeg_g > > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > > libavfilter/libavfilter.so: undefined reference to `ff_s

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread James Almer
On 11/20/2018 11:47 PM, Haihao Xiang wrote: > This fixes the link errors below: > > LD ffmpeg_g > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_sse2' > collect2: error: ld returned 1 exit status > Make

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Derek Buitenhuis
On 21/11/2018 14:09, Hendrik Leppkes wrote: > This does not apply here, the function is called unconditionally on > x86 (or rather on ARCH_X86) > What we usually do is just put the contents of such functions into the > guard, and not the init function itself - instead of having a second > one. Ah,

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Hendrik Leppkes
On Wed, Nov 21, 2018 at 2:21 PM Derek Buitenhuis wrote: > > On 21/11/2018 02:47, Haihao Xiang wrote: > > This fixes the link errors below: > > > > LD ffmpeg_g > > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > > libavfilter/libavfilter.so: undefined reference to `ff_

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Derek Buitenhuis
On 21/11/2018 02:47, Haihao Xiang wrote: > This fixes the link errors below: > > LD ffmpeg_g > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_sse2' > collect2: error: ld returned 1 exit status > Makefil

[FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-20 Thread Haihao Xiang
This fixes the link errors below: LD ffmpeg_g libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_sse2' collect2: error: ld returned 1 exit status Makefile:108: recipe for target 'ffmpeg_g' failed make: *** [f