On Wed, Nov 21, 2018 at 2:21 PM Derek Buitenhuis <derek.buitenh...@gmail.com> wrote: > > On 21/11/2018 02:47, Haihao Xiang wrote: > > This fixes the link errors below: > > > > LD ffmpeg_g > > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_sse2' > > collect2: error: ld returned 1 exit status > > Makefile:108: recipe for target 'ffmpeg_g' failed > > make: *** [ffmpeg_g] Error 1 > > > > Signed-off-by: Haihao Xiang<haihao.xi...@intel.com> > > --- > > libavfilter/x86/scene_sad_init.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > We require dead code elimination to build FFmpeg, so this shouldn't be needed. >
This does not apply here, the function is called unconditionally on x86 (or rather on ARCH_X86) What we usually do is just put the contents of such functions into the guard, and not the init function itself - instead of having a second one. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
