Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-13 Thread Nicolas George
Le tridi 23 ventôse, an CCXXV, Marton Balint a écrit : > You should set either AVFrame->flags to AV_FRAME_FLAG_CORRUPT or > AVFrame->decode_error_flags to something, so the API user can distinguish > between a frame with possible guessed colors and a frame without such > guesses. Indeed, that woul

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Marton Balint
On Sun, 12 Mar 2017, Paul B Mahol wrote: On 3/12/17, Nicolas George wrote: Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : I absolutely disagree with you on this one. I may have formulated the things a bit sarcastically, but the technical facts remain, and you need to address them.

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> I absolutely disagree with you on this one. > > I may have formulated the things a bit sarcastically, but the technical > facts remain, and you need to address them. Yes, I addressed this specific one - I

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paul B Mahol a écrit : > I absolutely disagree with you on this one. I may have formulated the things a bit sarcastically, but the technical facts remain, and you need to address them. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> Because conflicting entries have not been added yet. Last time I >> compared it was different. > > Well, unlike some people on this mailing-list, I actually check my facts > before sending a mail. And I re

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paul B Mahol a écrit : > Because conflicting entries have not been added yet. Last time I > compared it was different. Well, unlike some people on this mailing-list, I actually check my facts before sending a mail. And I repeat, I did not see any conflict. > Also wh

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paras Chadha a ecrit : >> Xpm decoder was added >> Also added xpm_pipe demuxer with its probe function >> [...] >> +typedef struct XPMContext { > >> +uint32_t *pixels; >> +int pixels_size; > > The spacing is strange

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paras Chadha a écrit : > Xpm decoder was added > Also added xpm_pipe demuxer with its probe function > > Signed-off-by: Paras Chadha > --- > Changelog| 1 + > doc/general.texi | 2 + > libavcodec/Makefile | 1 + > libavcodec/allco

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Marton Balint wrote: > > On Sat, 11 Mar 2017, Paras Chadha wrote: > >> On Sat, Mar 11, 2017 at 5:40 AM, Moritz Barsnick wrote: >> >>> >>> > +static int color_table_compare(const void *lhs, const void *rhs) >>> > +{ >>> > +return av_strcasecmp(lhs, ((const ColorEntry *)rhs)->name);

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Marton Balint
On Sat, 11 Mar 2017, Paras Chadha wrote: On Sat, Mar 11, 2017 at 5:40 AM, Moritz Barsnick wrote: > +static int color_table_compare(const void *lhs, const void *rhs) > +{ > +return av_strcasecmp(lhs, ((const ColorEntry *)rhs)->name); > +} > + > +static const ColorEntry color_table[] = {

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paras Chadha
On Sat, Mar 11, 2017 at 5:47 PM, Michael Niedermayer wrote: > On Sat, Mar 11, 2017 at 05:33:30PM +0530, Paras Chadha wrote: > > Here is the patch with all the changes mentioned above > > > > Signed-off-by: Paras > > --- > > Changelog | 1 + > > doc/general.texi| 2 + >

[FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-11 Thread Paras Chadha
Xpm decoder was added Also added xpm_pipe demuxer with its probe function Signed-off-by: Paras Chadha --- Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h | 1 + libavcodec/codec_des

[FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-11 Thread Paras Chadha
Signed-off-by: Paras --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/version.h| 4 +- libavcodec/xpmdec.c | 430 ++

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-11 Thread Paul B Mahol
On 3/11/17, Paras Chadha wrote: > Here is the patch with all the changes mentioned above > > Signed-off-by: Paras > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + >

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-11 Thread Michael Niedermayer
On Sat, Mar 11, 2017 at 05:33:30PM +0530, Paras Chadha wrote: > Here is the patch with all the changes mentioned above > > Signed-off-by: Paras > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > liba

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-11 Thread Paras Chadha
On Sat, Mar 11, 2017 at 5:40 AM, Moritz Barsnick wrote: > > > +static int color_table_compare(const void *lhs, const void *rhs) > > +{ > > +return av_strcasecmp(lhs, ((const ColorEntry *)rhs)->name); > > +} > > + > > +static const ColorEntry color_table[] = { > > +{ "AliceBlue",

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-11 Thread Paras Chadha
Here is the patch with all the changes mentioned above Signed-off-by: Paras --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/version

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-10 Thread Moritz Barsnick
On Sat, Mar 11, 2017 at 00:34:18 +0530, Paras wrote: > OBJS-$(CONFIG_XBM_DECODER) += xbmdec.o > OBJS-$(CONFIG_XBM_ENCODER) += xbmenc.o > +OBJS-$(CONFIG_XPM_DECODER) += xpmdec.o > OBJS-$(CONFIG_XFACE_DECODER) += xfacedec.o xface.o I do understand tha

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-10 Thread Lou Logan
Hi, On Sat, 11 Mar 2017 00:34:18 +0530 Paras wrote: > From: Paras Chadha > > Signed-off-by: Paras > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/

[FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-10 Thread Paras
From: Paras Chadha Signed-off-by: Paras --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/version.h| 4 +- libavcodec/xpmdec.c