Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-17 Thread Claudio Freire
On Mon, Mar 16, 2015 at 12:41 AM, Michael Niedermayer wrote: > On Fri, Mar 13, 2015 at 03:53:56PM -0300, Claudio Freire wrote: >> On Fri, Mar 13, 2015 at 3:06 PM, Michael Niedermayer >> wrote: >> > On Fri, Mar 13, 2015 at 02:34:08PM -0300, Claudio Freire wrote: >> >> On Fri, Mar 13, 2015 at 12:3

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-15 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 03:53:56PM -0300, Claudio Freire wrote: > On Fri, Mar 13, 2015 at 3:06 PM, Michael Niedermayer wrote: > > On Fri, Mar 13, 2015 at 02:34:08PM -0300, Claudio Freire wrote: > >> On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic > >> wrote: > >> >> btw, i use the qemu from http

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Fri, Mar 13, 2015 at 3:06 PM, Michael Niedermayer wrote: > On Fri, Mar 13, 2015 at 02:34:08PM -0300, Claudio Freire wrote: >> On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic >> wrote: >> >> btw, i use the qemu from https://github.com/ssvb/QEMU.git >> >> for mips as it at least years ago suppo

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 02:34:08PM -0300, Claudio Freire wrote: > On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic > wrote: > >> btw, i use the qemu from https://github.com/ssvb/QEMU.git > >> for mips as it at least years ago supported more extensions, i > >> would have guessed these where merged

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic wrote: >> btw, i use the qemu from https://github.com/ssvb/QEMU.git >> for mips as it at least years ago supported more extensions, i >> would have guessed these where merged into main qemu but as you list >> all the disables in the wiki, maybe i wa

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Fri, Mar 13, 2015 at 2:34 PM, Claudio Freire wrote: > On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic > wrote: >>> btw, i use the qemu from https://github.com/ssvb/QEMU.git >>> for mips as it at least years ago supported more extensions, i >>> would have guessed these where merged into main q

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Nedeljko Babic
> btw, i use the qemu from https://github.com/ssvb/QEMU.git > for mips as it at least years ago supported more extensions, i > would have guessed these where merged into main qemu but as you list > all the disables in the wiki, maybe i was guessing wrong I can confirm that main qemu supports both

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 12:36:58PM +0100, Michael Niedermayer wrote: > On Fri, Mar 13, 2015 at 12:30:30PM +0100, Michael Niedermayer wrote: > > On Fri, Mar 13, 2015 at 04:42:36AM -0300, Claudio Freire wrote: > > > On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire > > > wrote: > > > > On Tue, Mar 1

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 12:30:30PM +0100, Michael Niedermayer wrote: > On Fri, Mar 13, 2015 at 04:42:36AM -0300, Claudio Freire wrote: > > On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire > > wrote: > > > On Tue, Mar 10, 2015 at 8:05 AM, Michael Niedermayer > > > wrote: > > >>> I cannot test my

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 04:42:36AM -0300, Claudio Freire wrote: > On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire > wrote: > > On Tue, Mar 10, 2015 at 8:05 AM, Michael Niedermayer > > wrote: > >>> I cannot test myself yet (cannot build against mips, it will > >>> probably take me a long while

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire wrote: > On Tue, Mar 10, 2015 at 8:05 AM, Michael Niedermayer wrote: >>> I cannot test myself yet (cannot build against mips, it will >>> probably take me a long while before I can set up qemu for that), but >>> the patch should bring both implemen

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-10 Thread Claudio Freire
On Tue, Mar 10, 2015 at 8:05 AM, Michael Niedermayer wrote: >> I cannot test myself yet (cannot build against mips, it will >> probably take me a long while before I can set up qemu for that), but >> the patch should bring both implementations in sync, at least enough >> for the test to pass witho

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-10 Thread Michael Niedermayer
On Tue, Mar 10, 2015 at 12:37:34AM -0300, Claudio Freire wrote: > On Mon, Mar 9, 2015 at 3:31 PM, Claudio Freire wrote: > > On Mon, Mar 9, 2015 at 1:38 PM, Michael Niedermayer > > wrote: > >> On Mon, Mar 09, 2015 at 01:31:26PM -0300, Claudio Freire wrote: > >>> On Mon, Mar 9, 2015 at 1:26 PM, Mi

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Claudio Freire
On Mon, Mar 9, 2015 at 3:31 PM, Claudio Freire wrote: > On Mon, Mar 9, 2015 at 1:38 PM, Michael Niedermayer wrote: >> On Mon, Mar 09, 2015 at 01:31:26PM -0300, Claudio Freire wrote: >>> On Mon, Mar 9, 2015 at 1:26 PM, Michael Niedermayer >>> wrote: >>> > doesnt help >>> > but >>> > this does: >

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Claudio Freire
On Mon, Mar 9, 2015 at 1:38 PM, Michael Niedermayer wrote: > On Mon, Mar 09, 2015 at 01:31:26PM -0300, Claudio Freire wrote: >> On Mon, Mar 9, 2015 at 1:26 PM, Michael Niedermayer wrote: >> > doesnt help >> > but >> > this does: >> > -fate-aac-s7350-encode: CMD = enc_dec_pcm adts wav s16le $(REF)

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 01:31:26PM -0300, Claudio Freire wrote: > On Mon, Mar 9, 2015 at 1:26 PM, Michael Niedermayer wrote: > > doesnt help > > but > > this does: > > -fate-aac-s7350-encode: CMD = enc_dec_pcm adts wav s16le $(REF) -strict -2 > > -c:a aac -b:a 256k > > +fate-aac-s7350-encode: CMD

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Claudio Freire
On Mon, Mar 9, 2015 at 1:26 PM, Michael Niedermayer wrote: > doesnt help > but > this does: > -fate-aac-s7350-encode: CMD = enc_dec_pcm adts wav s16le $(REF) -strict -2 > -c:a aac -b:a 256k > +fate-aac-s7350-encode: CMD = enc_dec_pcm adts wav s16le $(REF) -strict -2 > -c:a aac -b:a 88k > > this

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 01:16:56PM -0300, Claudio Freire wrote: > On Mon, Mar 9, 2015 at 1:05 PM, Michael Niedermayer wrote: > >> Head is still using a butterworth filter for the lowpass IIRC. That > >> could very well be both platform and sample rate specific. > >> > >> Sadly, I cannot test mips,

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Claudio Freire
On Mon, Mar 9, 2015 at 1:05 PM, Michael Niedermayer wrote: >> Head is still using a butterworth filter for the lowpass IIRC. That >> could very well be both platform and sample rate specific. >> >> Sadly, I cannot test mips, but commenting the lowpass could yield >> useful results. > > what exact

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 12:55:43PM -0300, Claudio Freire wrote: > On Mon, Mar 9, 2015 at 12:41 PM, Michael Niedermayer wrote: > > On Sun, Mar 08, 2015 at 11:07:33PM -0300, Claudio Freire wrote: > >> On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire > >> wrote: > >> > On Sun, Mar 8, 2015 at 8:23 AM

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 04:53:52PM +0100, Michael Niedermayer wrote: > On Mon, Mar 09, 2015 at 04:41:05PM +0100, Michael Niedermayer wrote: > > On Sun, Mar 08, 2015 at 11:07:33PM -0300, Claudio Freire wrote: > > > On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire > > > wrote: > > > > On Sun, Mar 8,

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Claudio Freire
On Mon, Mar 9, 2015 at 12:41 PM, Michael Niedermayer wrote: > On Sun, Mar 08, 2015 at 11:07:33PM -0300, Claudio Freire wrote: >> On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire >> wrote: >> > On Sun, Mar 8, 2015 at 8:23 AM, Michael Niedermayer >> > wrote: >> >> i think its better to leave fuzz

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 04:41:05PM +0100, Michael Niedermayer wrote: > On Sun, Mar 08, 2015 at 11:07:33PM -0300, Claudio Freire wrote: > > On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire > > wrote: > > > On Sun, Mar 8, 2015 at 8:23 AM, Michael Niedermayer > > > wrote: > > >> i think its better

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Michael Niedermayer
On Sun, Mar 08, 2015 at 11:07:33PM -0300, Claudio Freire wrote: > On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire > wrote: > > On Sun, Mar 8, 2015 at 8:23 AM, Michael Niedermayer > > wrote: > >> i think its better to leave fuzz at a small value otherwise we > >> would forget to update the targe

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-09 Thread Michael Niedermayer
On Sun, Mar 08, 2015 at 11:07:33PM -0300, Claudio Freire wrote: > On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire > wrote: > > On Sun, Mar 8, 2015 at 8:23 AM, Michael Niedermayer > > wrote: > >> i think its better to leave fuzz at a small value otherwise we > >> would forget to update the targe

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-08 Thread Claudio Freire
On Sun, Mar 8, 2015 at 11:06 PM, Claudio Freire wrote: > On Sun, Mar 8, 2015 at 8:23 AM, Michael Niedermayer wrote: >> i think its better to leave fuzz at a small value otherwise we >> would forget to update the target when it improves and then >> subsequent worsenings could be missed > > An upda

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-08 Thread Claudio Freire
On Sun, Mar 8, 2015 at 8:23 AM, Michael Niedermayer wrote: > i think its better to leave fuzz at a small value otherwise we > would forget to update the target when it improves and then > subsequent worsenings could be missed An updated version with that fixed. It's a bit tricky to squash commit

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-08 Thread Michael Niedermayer
On Sun, Mar 08, 2015 at 03:55:09AM -0300, Claudio Freire wrote: > On Fri, Mar 6, 2015 at 2:19 PM, Michael Niedermayer wrote: > >> So it seems the test doesn't set up the LD_LIBRARY_PATH correctly. > >> That's fixable, I'll see about getting a patch for that when I > >> understand the makefile layo

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-07 Thread Claudio Freire
On Fri, Mar 6, 2015 at 2:19 PM, Michael Niedermayer wrote: >> So it seems the test doesn't set up the LD_LIBRARY_PATH correctly. >> That's fixable, I'll see about getting a patch for that when I >> understand the makefile layout. >> >> In the meantime, I'm *guessing* a test would look like the pat

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-06 Thread Michael Niedermayer
On Fri, Mar 06, 2015 at 01:06:53PM -0300, Claudio Freire wrote: > On Fri, Mar 6, 2015 at 11:47 AM, Michael Niedermayer wrote: > >> 2- How to run that, make check dies at dct1d-4 > > > > make check should pass, if it does not please try without local > > changes, with make distclean or if (unlikely

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-06 Thread Claudio Freire
On Fri, Mar 6, 2015 at 11:47 AM, Michael Niedermayer wrote: >> 2- How to run that, make check dies at dct1d-4 > > make check should pass, if it does not please try without local > changes, with make distclean or if (unlikely) these still fail a > fresh git checkout I did use a clean checkout. Ju

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-06 Thread Michael Niedermayer
On Fri, Mar 06, 2015 at 10:54:33AM -0300, Claudio Freire wrote: > On Fri, Mar 6, 2015 at 9:59 AM, Michael Niedermayer wrote: > > On Fri, Mar 06, 2015 at 04:28:38AM -0300, Claudio Freire wrote: > >> AAC: Add support for 7350Hz sampling rates, no error on too hight bitrate. > >> > >> Instead, warn t

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-06 Thread Claudio Freire
On Fri, Mar 6, 2015 at 9:59 AM, Michael Niedermayer wrote: > On Fri, Mar 06, 2015 at 04:28:38AM -0300, Claudio Freire wrote: >> AAC: Add support for 7350Hz sampling rates, no error on too hight bitrate. >> >> Instead, warn that bitrate will be clamped down to the maximum allowed. >> >> Patch is mo

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-06 Thread Michael Niedermayer
On Fri, Mar 06, 2015 at 04:28:38AM -0300, Claudio Freire wrote: > AAC: Add support for 7350Hz sampling rates, no error on too hight bitrate. > > Instead, warn that bitrate will be clamped down to the maximum allowed. > > Patch is mostly work of Kamendo2 in issue #2686, quite tested within that >

[FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-05 Thread Claudio Freire
AAC: Add support for 7350Hz sampling rates, no error on too hight bitrate. Instead, warn that bitrate will be clamped down to the maximum allowed. Patch is mostly work of Kamendo2 in issue #2686, quite tested within that issue. Tested with abtest.sh and confirmed it does work as intended. From d