On Sun, Mar 08, 2015 at 03:55:09AM -0300, Claudio Freire wrote: > On Fri, Mar 6, 2015 at 2:19 PM, Michael Niedermayer <michae...@gmx.at> wrote: > >> So it seems the test doesn't set up the LD_LIBRARY_PATH correctly. > >> That's fixable, I'll see about getting a patch for that when I > >> understand the makefile layout. > >> > >> In the meantime, I'm *guessing* a test would look like the patch > >> attached, but I still cannot run it. It says it won't, because: > >> warning: only a subset of the fate tests will be run because SAMPLES > >> is not specified > >> > >> Any idea where to get the samples? It's not just any samples, it wants > >> a specific set of samples. > > > > configure with --samples= to point to some directory and run > > make fate-rsync > > (this will need about 900mb space) > > > Yeah, that works. > > Attached another patch that adds the tests. Goes on top of the initial > patch (with the fixes themselves)
> fate-run.sh | 6 ++++++
> fate/aac.mak | 33 +++++++++++++++++++++++++++++++--
> 2 files changed, 37 insertions(+), 2 deletions(-)
> 7ee0079156ce01622cf6f4658db9d8e452513aee s7350test.patch
> From 9ebb5b6d0085a547938afb32c7d203686f7fcf11 Mon Sep 17 00:00:00 2001
> From: Claudio Freire <klaussfre...@gmail.com>
> Date: Sun, 8 Mar 2015 03:53:22 -0300
> Subject: [PATCH] Add AAC tests for 7350hz sampling rates and M/S
>
> Also tweak fuzz factor to not error out on too little distortion (ie: codec
> improvement)
> ---
> tests/fate-run.sh | 6 ++++++
> tests/fate/aac.mak | 33 +++++++++++++++++++++++++++++++--
> 2 files changed, 37 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 824d5f4..feac731 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -50,6 +50,12 @@ do_tiny_psnr(){
> size_cmp=$(compare $size1 $size2 $size_tolerance)
> if [ "$val_cmp" != 0 ] || [ "$size_cmp" != 0 ]; then
> echo "$psnr"
> + if [ "$val_cmp" != 0 ]; then
> + echo "$3: |$val - $cmp_target| >= $fuzz"
> + fi
> + if [ "$size_cmp" != 0 ]; then
> + echo "size: |$size1 - $size2| >= $size_tolerance"
> + fi
> return 1
> fi
> }
> diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
> index 34823be..cda80a4 100644
> --- a/tests/fate/aac.mak
> +++ b/tests/fate/aac.mak
> @@ -91,9 +91,29 @@ fate-aac-aref-encode: CMD = enc_dec_pcm adts wav s16le
> $(REF) -strict -2 -c:a aa
> fate-aac-aref-encode: CMP = stddev
> fate-aac-aref-encode: REF = ./tests/data/asynth-44100-2.wav
> fate-aac-aref-encode: CMP_SHIFT = -4096
> -fate-aac-aref-encode: CMP_TARGET = 434
> +fate-aac-aref-encode: CMP_TARGET = 225
> fate-aac-aref-encode: SIZE_TOLERANCE = 2464
> -fate-aac-aref-encode: FUZZ = 5
> +fate-aac-aref-encode: FUZZ = 225
i think its better to leave fuzz at a small value otherwise we
would forget to update the target when it improves and then
subsequent worsenings could be missed
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
