Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-15 Thread Michael Niedermayer
On Fri, May 15, 2020 at 10:00:02AM -0700, Thierry Foucu wrote: > On Thu, May 14, 2020 at 12:26 PM Derek Buitenhuis < > derek.buitenh...@gmail.com> wrote: > > > On 14/05/2020 18:19, Thierry Foucu wrote: > > > Looking at > > > > > https://developer.apple.com/library/archive/documentation/QuickTime/Q

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-15 Thread Thierry Foucu
On Thu, May 14, 2020 at 12:26 PM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 14/05/2020 18:19, Thierry Foucu wrote: > > Looking at > > > https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/Metadata/Metadata.html > > The spec does not seem to say 1 or more. But b

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-14 Thread Derek Buitenhuis
On 14/05/2020 18:19, Thierry Foucu wrote: > Looking at > https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/Metadata/Metadata.html > The spec does not seem to say 1 or more. But because the `keys` atom is a > list of indexes used by the `ilst` and the spec for `keys` said: > I

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-14 Thread Thierry Foucu
On Thu, May 14, 2020 at 5:09 AM Derek Buitenhuis wrote: > On 11/05/2020 17:35, Thierry Foucu wrote: > > If you have a file with multiple Metadata Keys, the second time you parse > > the keys, you will re-alloc c->meta_keys without freeing the old one. > > This change will avoid parsing all the co

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-14 Thread Derek Buitenhuis
On 11/05/2020 17:35, Thierry Foucu wrote: > If you have a file with multiple Metadata Keys, the second time you parse > the keys, you will re-alloc c->meta_keys without freeing the old one. > This change will avoid parsing all the consecutive Metadata keys. > --- > libavformat/mov.c | 3 ++- > 1 f

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-13 Thread Thierry Foucu
On Mon, May 11, 2020 at 9:35 AM Thierry Foucu wrote: > If you have a file with multiple Metadata Keys, the second time you parse > the keys, you will re-alloc c->meta_keys without freeing the old one. > This change will avoid parsing all the consecutive Metadata keys. > --- > libavformat/mov.c |

[FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-11 Thread Thierry Foucu
If you have a file with multiple Metadata Keys, the second time you parse the keys, you will re-alloc c->meta_keys without freeing the old one. This change will avoid parsing all the consecutive Metadata keys. --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi