On Fri, May 15, 2020 at 10:00:02AM -0700, Thierry Foucu wrote: > On Thu, May 14, 2020 at 12:26 PM Derek Buitenhuis < > derek.buitenh...@gmail.com> wrote: > > > On 14/05/2020 18:19, Thierry Foucu wrote: > > > Looking at > > > > > https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/Metadata/Metadata.html > > > The spec does not seem to say 1 or more. But because the `keys` atom is a > > > list of indexes used by the `ilst` and the spec for `keys` said: > > > Indexes into the metadata item keys atom are 1-based (1…entry_count). > > > > > > having 2+ `keys` atoms will conflict with this, as which one will be > > index 1 > > > > > > I'm assuming that only `keys` could only work. > > > instead of skipping the consecutive `keys` atom, I could change the code > > to > > > free the keys and re-alloc it for each `keys` atom found. So you will get > > > only the data from the last `keys` atom. > > > > > > so, it is either the 1st `keys` or the last `keys`. Up to you. > > > > LGTM as-is then. > > > > Thanks for the review, Derek. > Any chance to have someone to submit it?
will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
