017
Bests,
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
!
Bests,
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
I support the decision to keep ffserver
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
-test_h.avi
+e28ba75853caf975e06d92955c9f7f73 *ff-test_l.avi
a767dbdf5d1bded3450279f812f97b37 *ff-test.swf
dc16f607e13328a832e73801cd21ec98 *ff-test_h.asf
69337d6c8cd7ac7e626338decdbf41d3 *ff-test_l.asf
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
Looks good & works correctly Michael. Please feel free to push. Thank you.
On 12/01/2016 09:02 AM, Michael Niedermayer wrote:
if (src->codec->flags & AV_CODEC_FLAG_BITEXACT)
+c->pfmt_ctx->flags |= AVFMT_FLAG_BITEXACT;
--
Reynaldo H. Verdejo Pinochet
Open So
tat
2>/dev/null
do_md5sum ff-stat >>ffserver.regression
)
kill $FFSERVER_PID
diff --git a/tests/ffserver.regression.ref b/tests/ffserver.regression.ref
index ec7b37c..8629d52 100644
--- a/tests/ffserver.regression.ref
+++ b/tests/ffserver.regressio
/feed1.ffm
-$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" 2> /dev/null &
+$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" &
FFSERVER_PID=$!
echo "Waiting for feeds to startup..."
sleep 2
--
Reynaldo H. Verdejo Pi
Both OK. Thanks.
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hi Michael
Looks good too. Please feel free to push
alongside the ones on the "Remove use of
AVStream.." thread.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
___
ffmpeg-devel mailing list
ffmpeg-devel@
Looks good. Thank you!
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 11/26/2016 01:00 PM, Rostislav Pehlivanov wrote:
[..]
Since a month has passed, reynaldo still hasn't responded, I think it's
This is not correct. I have been working on weeding
out it's private API usage problems. Last commit to
this effect is from 3 weeks ago.
Bests,
On 11/08/2016 06:29 AM, James Almer wrote:
[..]
Right now it just returns st->codec->time_base, but after st->codec is
deprecated
it will be adapted to use st->internal->avctx->time_base.
Perfect! Will do. Thanks for the hint James.
Bests,
--
Reynaldo H. Verdejo Pi
Bests,
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
from me.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Thanks for the comments and corrections. Fixed the typos and pushed as:
commit f06598a8e1fcccef8c38a657162db309773d1515
Author: Reynaldo H. Verdejo Pinochet
Date: Sun Oct 30 01:37:26 2016 -0700
news: add final report for summer of code 2016
Bests,
--
Reynaldo H. Verdejo Pinochet
Open
From: "Reynaldo H. Verdejo Pinochet"
Signed-off-by: Reynaldo H. Verdejo Pinochet
---
src/index | 34 ++
1 file changed, 34 insertions(+)
diff --git a/src/index b/src/index
index edc1243..eb3a929 100644
--- a/src/index
+++ b/src/index
@@ -3
From: "Reynaldo H. Verdejo Pinochet"
pkg-config(1) expects uninstalled pc files to follow the
blah-uninstalled.pc naming convention and the behavior
of the program is impacted by it. Without this fix
overriding PKGP_CONFIG_LIBDIR is required to ensure
uninstalled files are preferred
release.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hello
On 10/27/2016 11:25 AM, James Almer wrote:
[..]
This is not how things were agreed.
I haven't agreed to this.
The patch fixes nothing while breaking master
for ffserver users. There's a way forward, but
the patch can't be applied before it happens.
Bests,
--
Reyn
I understand you might be upset but please refrain from
using bad language.
The way I see it your removal will happen once there's a
solution in place just not before. This is why the patch
is not rejected.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research Am
ith a commitment not break our own apps.
The server will be fixed to work using public API in the
process. I can work on this with whoever wants to help.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group - Samsung Research America
___
ffmpeg-
; 13 LGTM
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
; http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Pushed as:
commit 21c34cb26154a5eadd6e10df86c20e2df3a7bd55
Author: Reynaldo H. Verdejo Pinochet
Date: Fri Dec 4 14:07:23 2015 -0800
libavutil: add version component accessor macros
[..]
Thanks
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg
On 12/05/2015 11:36 AM, Ganesh Ajjanagadde wrote:
> [...]
>
> minor nit: commit message typo (libavtuil -> libavutil).
>
True. Corrected. Thanks for taking a look
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ht
On 12/05/2015 10:31 AM, Reynaldo H. Verdejo Pinochet wrote:
> Pretty standard macros, these should help libav*
> users avoid repeating ver.si.on parsing code,
> which aids in compatibility-checking tasks like
> identifying FFmpeg from Libav (_MICRO >= 100 check).
Actually ran
Pretty standard macros, these should help libav*
users avoid repeating ver.si.on parsing code,
which aids in compatibility-checking tasks like
identifying FFmpeg from Libav (_MICRO >= 100 check).
Something many are doing since we are not
intercompatible anymore.
Signed-off-by: Reynaldo H. Verd
n_buf(ctx->pb, &c->pb_buffer);
> +ctx->pb = NULL;
Looks good. I think there's a similar issue at the end
of rtp_new_av_stream() you might want to handle too but
please feel free to push as-is.
Bests,
--
Reynaldo
___
This one looks OK (pending a final decision on
av_clipd64())
Bests,
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
_() twice while
we are at this. The check and re-get seems racy although it might
not matter much in this context.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-d
Signed-off-by: Reynaldo H. Verdejo Pinochet
---
src/index | 33 +
1 file changed, 33 insertions(+)
diff --git a/src/index b/src/index
index 77946a4..4dec768 100644
--- a/src/index
+++ b/src/index
@@ -37,6 +37,39 @@
News
+ Telepoint & MediaHub are
Totally missed it. Thanks & please ignore. Proly a good idea
to update entry at coverity.com though.
Bests.
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-d
Fixes Coverity CID 1325680
Signed-off-by: Reynaldo H. Verdejo Pinochet
---
libavfilter/af_pan.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c
index 9117cc0..91cc434 100644
--- a/libavfilter/af_pan.c
+++ b/libavfilter/af_pan.c
@@ -239,6
esigning a solution that would let us have this
functionality available for internal use while being maintainable
, have good platform coverage, and be as uncluttered (use-case wise)
as it can possibly be.
Humbly,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Sili
Hi
On 06/06/2015 10:43 AM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> ffserver.c | 20
> 1 file changed, 20 insertions(+)
>
> [..]
Looks good. Thanks!
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsun
,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 04/05/2015 01:46 PM, Reynaldo H. Verdejo Pinochet wrote:
> Hi everyone
>
> OPW/Outreachy internships for this round are starting
> in May and we are about to hit the deadline for applications
> set for Tuesday next week.
> [..]
Deadline for applications has just been ex
/Outreachy/2015-05
If you have any questions regarding the program please get
in touch with us at o...@ffmpeg.org
By all means, please consider forwarding this information among
your circles.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
;= INT_MAX/sizeof(*avs) ||
> -!(avs = av_malloc(avc->nb_streams * sizeof(*avs
> +if (!(avs = av_malloc_array(avc->nb_streams, sizeof(*avs
> goto sdp_done;
>
> for(i = 0; i < stream->nb_streams; i++) {
>
--
Reynaldo H. Verdejo Pinochet
Open Sourc
OK to push too. Thanks a lot.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Looks OK too.
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Looks OK. Feel free to push.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Should be OK. Thanks.
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 11/26/2014 07:52 PM, Lukasz Marek wrote:
> [..]
>
> In fact 20 is too small. INT64_MIN has 19 digits, '-' sign and
> terminating 0. So 21 is a minimum. I put 22, the same as av_dict_set_int.
True, forgot about the sign. Go ahead after fixing please.
Thanks,
-
nks a lot!
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hi Lukasz. Are you sending an updated patch for this one
or I missed it somehow?
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman
Hi. LGTM, feel free to push please.
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
har *opt, int64_t arg,
> + int type, FFServerConfig *config)
> +{
> +char buf[30];
char buf[20] should be plenty considering INT64_MAX. Feel free to push
after this minor fix unless someone else holds you.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Res
Hi Lukasz. Sorry for the delay.
Patch looks good. Feel free to push.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman
t; return AVERROR(ENOMEM);
>> for (i = 0; i < 62; i++) {
>
> Right after submit I notice this hardcoded 62 so I changed locally to
> MAX_CHILD_ARGS - 2 :]
Cool. Feel free to push please.
Thanks a lot
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Feel free to push please.
Thanks a lot
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
g->stream_use_defaults = 2;
> } else {
> ERROR("Invalid entry '%s' inside \n", cmd);
> }
I think these should be WARNING()s. Patch looks good otherwise.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 11/21/2014 07:17 PM, Reynaldo H. Verdejo Pinochet wrote:
> [..]
> suggestion many avid by.
s/avid by/follow/g
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hi
On 11/20/2014 10:14 PM, Lukasz Marek wrote:
> On 18.11.2014 21:35, Reynaldo H. Verdejo Pinochet wrote:
> [...]
> Also, please make an effort
>> to break lines at 80 chars as long as it doesn't make the
>> code harder to read. This seems particularly possible on th
Hi
On 11/20/2014 10:09 PM, Lukasz Marek wrote:
> On 18.11.2014 23:25, Reynaldo H. Verdejo Pinochet wrote:
>> [..]
>> I do think undefined behavior should be avoided if possible
>> without too much hassle, so if we go with the former I would
>> appreciate doc ent
Hi
On 11/18/2014 06:54 PM, Nicolas George wrote:
> L'octidi 28 brumaire, an CCXXIII, Reynaldo H. Verdejo Pinochet a
> écrit :
>> I think I commented about this before but having yesvar & novar
>> options seems redundant. Having var = yes or no if absent (or
>>
t a blocker of course.
Looks OK otherwise. Feel free to push after confirming ^
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
st
> as these two *.o are not treated as dependencies. I don't know where to
> place it in general, so I could use some help.
>
For build/test system integration, see my previous answer on
this same thread.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Sa
{
You seem to use an space before ( for if/while/for. Add it here.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
d simplify the code a bit too, avoiding checking
for the two and imposing a precedence, which is not always
documented. What do you think? This happens twice on this patch
IIRC.
Otherwise seems OK to push.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open So
ckers.
As a general comment, I would avoid the grammatical "!!!"s and
such to denote severity. We have the log categories for that.
This is also just a tip, not something you need to change.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
__
_rate.num, 0) < 0 ||
> -av_dict_set_int(&config->video_conf, "VideoFrameRateDen",
> frame_rate.den, 0) < 0)
> +else {
> +if ((w % 2) || (h % 2))
Drop the redundant () across %. Also, please make an effort
to break lines at
2 files changed, 69 insertions(+), 170 deletions(-)
>
> @Reynaldo, you may check the test I submitted, and the comments, you may
> then have just high level review, not bother if mapping between options
> is ok
Will do. Thanks for the hint. I should be able to take a look
at this and the re
OK to push too.
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Looks Good. Feel free to push.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
OK to push. Thanks.
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Looks. OK. Feel free to push after some testing. Can't
try it out right now but seems harmless.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpe
Hi Lukasz. Sry for the delay at answering, been traveling
the whole week.
Patch looks OK, feel free to push.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel
gt;guessed_audio_codec_id : AV_CODEC_ID_AAC;
+break;
+case AVMEDIA_TYPE_VIDEO:
+id = config->guessed_video_codec_id != AV_CODEC_ID_NONE ?
config->guessed_video_codec_id : AV_CODEC_ID_H264;
+break;
+ default:
+
recent checkout of master. For future reference,
you need to do this every time you send a patch over.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
Looks good. Thanks. Feel free to push.
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
rr on the above
condition? Please double check.
>> +close(fd);
Above block needs to be re-indented. Also, check for failures in
open and dup2() and react accordingly. I think Nicolas mentioned
this already.
>> +
>> +}
>> +}
>>
Hi. I'm afraid I don't understand what the problem is. Can
someone elaborate?
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://
/* Used internally to test AVOptions, not
> to be used anywere else */
s/anywere/anywhere/g
nit: . Not to be
Looks OK, feel free to push after fixing ^
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
matters is usually that if the feature
works and does no harm, then keep it. Maybe there's someone relying
on this. I will try getting others to comment on and decide. For
the time been though I think there might be a missing and needed
change to the ffserver docs for this patch to be complete.
its latter on.
>
> OK, will do that locally.
>
Thanks. Feel free to push afterward.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Looks OK. Feel free to push.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
ax_size = (int64_t)fsize;
> if (feed->feed_max_size < FFM_PACKET_SIZE*4)
> @@ -876,11 +878,15 @@ static int ffserver_parse_config_stream(FFServerConfig
> *config, const char *cmd,
> stream->is_multicast = 1;
> stream->loo
Patch seems OK but I'm missing on the rationalle behind
dropping the preset support. Can you elaborate?
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-
f 16\n");
> [..]
OK if always safe. Otherwise demote to WARNING()
Feel free to push otherwise.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
emonize yes/no toggle should be enough but I'm OK
either way in the context of this patch.
Binathi: As an added bonus, try adding an -s to your
commit command line so you get the Signed-off-by:
line added, this is customary.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung
t3(avcodec_find_encoder(config->video_id));
> +if (config->video_preset &&
> +ffserver_opt_preset(arg, video_enc,
> AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_ENCODING_PARAM,
> +NULL, NULL) < 0)
> +
.video_opts = NULL,
> +.video_conf = NULL,
> +.audio_opts = NULL,
> +.audio_conf = NULL,
> +.video_preset = NULL,
> +.audio_preset = NULL,
> };
>
Guess you are already considered dropping the explicit initialization
code as Reimaer suggested.
Looks good othe
Feel free to push after removing the explicit/redundant
initialization of FFServerConfig config as Reimar suggested.
While you are at this though, can you remove braces on
single statement ifs? appreciated.
Thanks
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America
On 10/21/2014 07:10 AM, Stefano Sabatini wrote:
> [..]
>
> LGTM.
Agree.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://f
Config parsing changeset LGTM. Feel free to push.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hello Di Wu
On 10/15/2014 05:24 AM, di1028...@samsung.com wrote:
From: Di Wu
Add the judement after create a new program to avoid segment fault.
[..]
Thanks for your patch. Can you spell check your commit summary
though?, you have at least two typos there.
Thanks,
--
Reynaldo H. Verdejo
27;t meent the standards, I can change it again.
The new patch is attached, please check if there is any point needs to be
modified.
Pushed. Thanks for your patch Di Wu
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Sili
if (!s->refreshctx){
> +ff_thread_finish_setup(ctx);
> +}
Surrounding code does not use braces for single statement if()s,
please drop them.
CCing Clement so he can comment on the validity of the change otherwise.
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
S
forgot, it's the Qualification Mentor's task to suggest
that number, Guess Michael can have a run at them latter and correct
any wrongs.
Please do reserve some time to keep the table updated.
Thanks for all your help ppl!
Bests,
--
Reynaldo H. Verdejo Pinochet
Open Source Group
S
anks in advance!
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Pushed. Thanks for taking a look.
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Set pushed. Thanks for taking a look.
--
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
ff_all_channel_layouts() might return null on alloc failure.
Fixes CID1241516
Signed-off-by: Reynaldo H. Verdejo Pinochet
---
libavfilter/af_amix.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c
index d8a6651..47cbb45
ff_all_channel_layouts() might return null on alloc failure.
Fixes CID1241518
Signed-off-by: Reynaldo H. Verdejo Pinochet
---
libavfilter/af_join.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c
index 560c5c8..a1717c6
ff_all_channel_layouts() might return null on alloc failure.
Fixes CID1241517
Signed-off-by: Reynaldo H. Verdejo Pinochet
---
libavfilter/af_channelmap.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c
index
anks in advance!
--
Reynaldo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 09/12/2014 09:07 PM, Lou Logan wrote:
> [..]
> How should it be worded to be less confusing?
> [..]
No bug reports without patches? or "Not for bug reports unless
you are including a patch that fixes the problem"?
--
Reynaldo
_
&p);
if (resolve_host(&my_http_addr.sin_addr, arg) != 0) {
ERROR("%s:%d: Invalid host/IP address: %s\n", arg);
--
Reynaldo H. Verdejo Pinochet
Sr. Multimedia Engineer, Open Source Group
Samsung Research America - Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 08/02/2014 10:40 AM, Stefano Sabatini wrote:
The new option names are more explicit.
---
[..]
Looks OK
Bests,
--
Reynaldo H. Verdejo Pinochet
Sr. Multimedia Engineer, Open Source Group
Samsung Research America - Silicon Valley
___
ffmpeg-devel
1 - 100 of 101 matches
Mail list logo
