Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix ref_order_hint value for second slot

2025-06-05 Thread David Rosca
On Mon, Apr 14, 2025 at 4:00 PM David Rosca wrote: > > We always use two slots, even when only one L0 reference is supported > by the driver. However we still need to set the correct value for the > ref_order_hint of the second slot. > > Fixes bf9f921ef7 ("avcodec/hw_base_e

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Add direct map quirk for Intel i965 driver

2025-05-07 Thread David Rosca
vaGetImage is currently used for all maps when read access is required because vaDeriveImage is supposed to be very slow on old Intel HW with i965 driver. However, this is not the case with modern drivers and vaDeriveImage is faster also for reading. Add a new quirk for i965 driver that will keep

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix ref_order_hint value for second slot

2025-04-15 Thread David Rosca
We always use two slots, even when only one L0 reference is supported by the driver. However we still need to set the correct value for the ref_order_hint of the second slot. Fixes bf9f921ef7 ("avcodec/hw_base_encode: restrict size of next_prev") --- libavcodec/vaapi_encode_av1.c | 3 +++ 1 file

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref

2025-04-14 Thread David Rosca
On Tue, Mar 4, 2025 at 8:43 AM David Rosca wrote: > > On Tue, Mar 4, 2025 at 2:55 AM Wang, Fei W > wrote: > > > > On Mon, 2025-03-03 at 14:47 +0100, David Rosca wrote: > > > On Wed, Jan 15, 2025 at 10:41 PM David Rosca > > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref

2025-03-03 Thread David Rosca
On Tue, Mar 4, 2025 at 2:55 AM Wang, Fei W wrote: > > On Mon, 2025-03-03 at 14:47 +0100, David Rosca wrote: > > On Wed, Jan 15, 2025 at 10:41 PM David Rosca > > wrote: > > > > > > Don't need to alternate when only one reference is used. > > > Fi

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref

2025-03-03 Thread David Rosca
On Wed, Jan 15, 2025 at 10:41 PM David Rosca wrote: > > Don't need to alternate when only one reference is used. > Fixes fail after bf9f921ef7 ("avcodec/hw_base_encode: restrict size of > next_prev") > due to AV1 writer complaining about incorre

[FFmpeg-devel] [PATCH 1/1] Bug Fix: Prevent AVFoundation configuration error when two different formats have the same dimensions but different frame rates.

2025-02-28 Thread David Franco
--- libavdevice/avfoundation.m | 9 + 1 file changed, 9 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index 61dac4b713..b625990c37 100644 --- a/libavdevice/avfoundation.m +++ b/libavdevice/avfoundation.m @@ -375,6 +375,15 @@ static int configure_video_de

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref

2025-01-15 Thread David Rosca
Don't need to alternate when only one reference is used. Fixes fail after bf9f921ef7 ("avcodec/hw_base_encode: restrict size of next_prev") due to AV1 writer complaining about incorrect ref_order_hint value. --- libavcodec/vaapi_encode_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH] avformat/rtpenc_mpegts: copy AVStream metadata to rtp_mpegts muxer

2025-01-01 Thread Vojta David
Copy AVStream metadata from source file to RTP MPEGTS muxer. Muxer supports only language metadata. User can set/change language metadata from cli. Signed-off-by: Vojta David --- libavformat/rtpenc_mpegts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtpenc_mpegts.c b

Re: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_encode: Query surface alignment

2024-11-18 Thread David Rosca
On Tue, Oct 22, 2024 at 5:28 PM David Rosca wrote: > > It needs to create temporary config to query surface attribute. > --- Ping. Thanks, David > libavcodec/vaapi_encode.c | 66 +++ > libavcodec/vaapi_encode.h | 4 +++ > 2 files chan

[FFmpeg-devel] [PATCH] vulkan: Don't try to early reuse exec context with query

2024-11-15 Thread David Rosca
It needs to first get the query before the context can be used again. Fixes getting incorrect values from encode query with async_depth > 1. --- libavutil/vulkan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index 2c71312d78..8485c5

[FFmpeg-devel] [PATCH] vulkan_encode_h264/5: Fix uninitialized return value in write_extra_headers

2024-11-14 Thread David Rosca
--- libavcodec/vulkan_encode_h264.c | 1 + libavcodec/vulkan_encode_h265.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavcodec/vulkan_encode_h264.c b/libavcodec/vulkan_encode_h264.c index cdc87fb4ca..fdd3cc8a55 100644 --- a/libavcodec/vulkan_encode_h264.c +++ b/libavcodec/vulkan_encod

[FFmpeg-devel] [PATCH 2/2] lavc/vaapi_encode_h265: Use surface alignment

2024-10-22 Thread David Rosca
This is needed to correctly set conformance window crop with Mesa AMD. --- libavcodec/vaapi_encode_h265.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index 2283bcc0b4..0f97c9188b 100644 --- a/liba

[FFmpeg-devel] [PATCH 1/2] lavc/vaapi_encode: Query surface alignment

2024-10-22 Thread David Rosca
It needs to create temporary config to query surface attribute. --- libavcodec/vaapi_encode.c | 66 +++ libavcodec/vaapi_encode.h | 4 +++ 2 files changed, 70 insertions(+) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 16a9a364f0..c8

[FFmpeg-devel] [PATCH] hw_base_encode: Free pictures on close

2024-10-15 Thread David Rosca
Fixes leaking recon surfaces with VAAPI. --- libavcodec/hw_base_encode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c index 7b6ec97d3b..912c707a68 100644 --- a/libavcodec/hw_base_encode.c +++ b/libavcodec/hw_base_encode.c @@ -80

Re: [FFmpeg-devel] [PATCH v2] hw_base_enc: inject side data to crop output for AV1

2024-10-01 Thread David Rosca
On Sat, Sep 14, 2024 at 8:59 AM Lynne via ffmpeg-devel wrote: > > Unlike H264/H265, AV1 contains no fields to crop encoded output > to specific sizes. > AMD's hardware cannot handle encoding of unaligned dimensions for > AV1, hence it codes 1920x1080 as 1920x1088. > > Add side data to crop the out

Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support.

2024-08-12 Thread David Wu via ffmpeg-devel
thanks you Mark! will follow up on libva changes first. David On 2024-08-11 14:42, Mark Thompson wrote: On 11/08/2024 19:27, Mark Thompson wrote: On 30/07/2024 21:02, David (Ming Qiang) Wu via ffmpeg-devel wrote: AV1Profile2 VAAPI is supported and tested on AMD VCN5. Signed-off-by: David

[FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support.

2024-07-30 Thread David (Ming Qiang) Wu via ffmpeg-devel
AV1Profile2 VAAPI is supported and tested on AMD VCN5. Signed-off-by: David (Ming Qiang) Wu --- libavcodec/av1dec.c | 3 +++ libavcodec/vaapi_decode.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 1d5b9ef4f4..77f63661a0 100644

[FFmpeg-devel] [PATCH v2] lavc/vaapi_decode: Reject decoding of frames with no slices

2024-05-13 Thread David Rosca
Matches other hwaccels. --- v2: AVERROR libavcodec/vaapi_decode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index 8e9f647c20..7c91d50f7b 100644 --- a/libavcodec/vaapi_decode.c +++ b/libavcodec/vaapi_decode.c @@ -157,6 +157,11 @@

[FFmpeg-devel] [PATCH] lavc/vaapi_decode: Reject decoding of frames with no slices

2024-05-10 Thread David Rosca
Matches other hwaccels. --- libavcodec/vaapi_decode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index 8e9f647c20..3c4030c073 100644 --- a/libavcodec/vaapi_decode.c +++ b/libavcodec/vaapi_decode.c @@ -157,6 +157,11 @@ int ff_vaapi

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_h264: Fix merging fields in DPB with missing references

2024-05-08 Thread David Rosca
On Tue, May 7, 2024 at 10:22 PM Mark Thompson wrote: > > On 07/05/2024 07:00, David Rosca wrote: > > If there are missing references, h264 decode does error concealment > > by copying previous refs which means there will be duplicated surfaces > > and this code would try

[FFmpeg-devel] [PATCH v2] lavc/vaapi_h264: Fix merging fields in DPB with missing references

2024-05-08 Thread David Rosca
If there are missing references, h264 decode does error concealment by copying previous refs which means there will be duplicated surfaces. Check long_ref and frame_idx in addition to surface when looking for the other field to avoid trying to merge with wrong picture. Also allow to merge with mult

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_av1: Avoid sending the same slice buffer multiple times

2024-05-08 Thread David Rosca
On Tue, May 7, 2024 at 10:01 PM Mark Thompson wrote: > > On 28/04/2024 08:26, David Rosca wrote: > > When there are multiple tiles in one slice buffer, use multiple slice > > params to avoid sending the same slice buffer multiple times and thus > > increasing the bitstr

[FFmpeg-devel] [PATCH v2 2/2] lavc/vaapi_av1: Avoid sending the same slice buffer multiple times

2024-05-08 Thread David Rosca
When there are multiple tiles in one slice buffer, use multiple slice params to avoid sending the same slice buffer multiple times and thus increasing the bitstream size the driver will need to upload to hw. --- v2: Avoid allocations every slice. libavcodec/vaapi_av1.c | 47 ++

[FFmpeg-devel] [PATCH v2 1/2] lavc/vaapi_decode: Make it possible to send multiple slice params buffers

2024-05-08 Thread David Rosca
--- v2: No changes libavcodec/vaapi_av1.c| 2 +- libavcodec/vaapi_decode.c | 3 ++- libavcodec/vaapi_decode.h | 1 + libavcodec/vaapi_h264.c | 2 +- libavcodec/vaapi_hevc.c | 4 ++-- libavcodec/vaapi_mjpeg.c | 2 +- libavcodec/vaapi_mpeg2.c | 2 +- libavcodec/vaapi_mpeg4.c | 2 +- liba

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_h264: Don't try to merge fields in DPB for non-field pics

2024-05-06 Thread David Rosca
On Mon, May 6, 2024 at 9:55 PM Mark Thompson wrote: > > On 05/05/2024 17:36, David Rosca wrote: > > This path can be hit when there are missing references while decoding > > progressive stream and would completely break the DPB contents. > > --- > >

[FFmpeg-devel] [PATCH] lavc/vaapi_h264: Fix merging fields in DPB with missing references

2024-05-06 Thread David Rosca
If there are missing references, h264 decode does error concealment by copying previous refs which means there will be duplicated surfaces and this code would try to merge them instead of correctly appending to DPB. Make sure the fields were actually merged before early return. --- libavcodec/vaap

[FFmpeg-devel] [PATCH] lavc/vaapi_h264: Don't try to merge fields in DPB for non-field pics

2024-05-05 Thread David Rosca
This path can be hit when there are missing references while decoding progressive stream and would completely break the DPB contents. --- libavcodec/vaapi_h264.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/libavcodec/vaapi_h264.c b/libavcode

[FFmpeg-devel] [PATCH 2/2] lavc/vaapi_av1: Avoid sending the same slice buffer multiple times

2024-04-28 Thread David Rosca
When there are multiple tiles in one slice buffer, use multiple slice params to avoid sending the same slice buffer multiple times and thus increasing the bitstream size the driver will need to upload to hw. --- libavcodec/vaapi_av1.c | 37 +++-- 1 file changed, 23

[FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: Make it possible to send multiple slice params buffers

2024-04-28 Thread David Rosca
--- libavcodec/vaapi_av1.c| 2 +- libavcodec/vaapi_decode.c | 3 ++- libavcodec/vaapi_decode.h | 1 + libavcodec/vaapi_h264.c | 2 +- libavcodec/vaapi_hevc.c | 4 ++-- libavcodec/vaapi_mjpeg.c | 2 +- libavcodec/vaapi_mpeg2.c | 2 +- libavcodec/vaapi_mpeg4.c | 2 +- libavcodec/vaapi_vc1

Re: [FFmpeg-devel] [PATCH v4] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2024-04-25 Thread David Rosca
On Fri, Nov 24, 2023 at 8:27 AM Xiang, Haihao wrote: > > On Vr, 2023-10-27 at 22:25 +0200, David Rosca wrote: > > This allows some optimizations in driver, such as not having to read > > back the data if write-only mapping is requested. > > --- > > v4: overwrite

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Set roi_quant_range

2024-04-01 Thread David Rosca
--- libavcodec/vaapi_encode_av1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c index a46b882ab9..02a31b894d 100644 --- a/libavcodec/vaapi_encode_av1.c +++ b/libavcodec/vaapi_encode_av1.c @@ -155,6 +155,8 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13.

2024-01-01 Thread David Bohman
On Mon, Jan 1, 2024 at 9:26 AM wrote: > > > > On 1 Jan 2024, at 15:38, David Bohman wrote: > > > This is a build failure in the master branch as a result of commit > > e37b15e26fbc7bc31a86a4a2c7c798e20d4f4c2c: > > > > There is no type AVMediaType prior t

Re: [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13.

2024-01-01 Thread David Bohman
On Mon, Jan 1, 2024 at 9:08 AM Michael Niedermayer wrote: > > error: corrupt patch at line 19 > Sorry, I have also attached the patch file to this message. --- libavdevice/avfoundation.m | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation

[FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13.

2024-01-01 Thread David Bohman
This is a build failure in the master branch as a result of commit e37b15e26fbc7bc31a86a4a2c7c798e20d4f4c2c: There is no type AVMediaType prior to macOS 10.13. --- libavdevice/avfoundation.m | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundat

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc.c: Populate OTI using AAC profile in write_codec_attr.

2023-12-30 Thread David Johansen
On Sat, Dec 30, 2023 at 8:23 AM Romain Beauxis wrote: > Le jeu. 28 déc. 2023 à 17:26, David Johansen a > écrit : > >> > >> I love this change, but it appears that st->codecpar->profile is always > AV_PROFILE_UNKNOWN when using libfdk_aac as the encoder. Any indi

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc.c: Populate OTI using AAC profile in write_codec_attr.

2023-12-28 Thread David Johansen
> > I love this change, but it appears that st->codecpar->profile is always > AV_PROFILE_UNKNOWN when using libfdk_aac as the encoder. Any indications > where I should look for fix that so this can be used with that encoder? > It appears that the issue is that profile doesn't default to what's bei

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio

2023-12-28 Thread David Johansen
On Wed, Nov 8, 2023 at 6:38 PM Steven Liu wrote: > David Johansen 于2023年11月9日周四 07:47写道: > > > > On Fri, Oct 27, 2023 at 1:33 AM Steven Liu > wrote: > > > > > David Johansen 于2023年10月27日周五 12:03写道: > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc.c: Populate OTI using AAC profile in write_codec_attr.

2023-12-28 Thread David Johansen
On Fri, Dec 22, 2023 at 8:10 AM Romain Beauxis wrote: > This patch populates the third entry for HLS codec attribute using the > AAC profile. > > The HLS specifications[1] require this digit to be the Object Type ID as > referred to in table 1.3 of ISO/IEC 14496-3:2009[2]. > > The numerical const

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

2023-11-25 Thread David Bohman
On Fri, Nov 24, 2023 at 8:09 PM Zhao Zhili wrote: > > > > > On Nov 25, 2023, at 05:32, David Bohman wrote: > > > > On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili wrote: > >> > >>> On Nov 24, 2023, at 23:40, David Bohman wrote: > >&g

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

2023-11-24 Thread David Bohman
On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili wrote: > > > On Nov 24, 2023, at 23:40, David Bohman wrote: > > > > This is to fix a build failure on macOS < 10.13. > > > It looks like kVTCompressionPropertyKey_EncoderID is the root cause of build > failure. >

[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

2023-11-24 Thread David Bohman
This is to fix a build failure on macOS < 10.13. This is a build failure in release 6.1. The issue also exists at the top of the master branch, and the patch applies there. --- libavcodec/videotoolboxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolbox

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio

2023-11-08 Thread David Johansen
On Fri, Oct 27, 2023 at 1:33 AM Steven Liu wrote: > David Johansen 于2023年10月27日周五 12:03写道: > > > > > > > > LGTM > > > > > > > > > Thanks > > > Steven > > > > > > > I'm new to ffmpeg development so what&#x

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hlsenc: Add init_program_date_time so start time can be specified

2023-11-08 Thread David Johansen
On Sun, Nov 5, 2023 at 1:21 AM Marton Balint wrote: > > > On Fri, 27 Oct 2023, David Johansen wrote: > > > On Fri, Oct 27, 2023 at 4:58 AM wrote: > > > >> On 27 Oct 2023, at 5:59, Dave Johansen wrote: > >> > @item second_level_segment_index > &

[FFmpeg-devel] Separate stream for subtitles in HLS?

2023-11-01 Thread David Johansen
Currently, I have to put the subtitles on the video stream and when I make the subtitles their own stream, I get this error: No streams to mux were specified Would it be possible to have the subtitles as their own stream or is too engrained of an assumption that there's an output stream tied to ea

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hlsenc: Add init_program_date_time so start time can be specified

2023-10-27 Thread David Johansen
On Fri, Oct 27, 2023 at 4:58 AM wrote: > On 27 Oct 2023, at 5:59, Dave Johansen wrote: > > @item second_level_segment_index > > Makes it possible to use segment indexes as %%d in hls_segment_filename > expression > > besides date/time values when strftime is on. > > diff --git a/libavformat/hl

[FFmpeg-devel] [PATCH v4] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2023-10-27 Thread David Rosca
This allows some optimizations in driver, such as not having to read back the data if write-only mapping is requested. --- v4: overwrite + note about vaMapBuffer libva fallback libavutil/hwcontext_vaapi.c | 12 1 file changed, 12 insertions(+) diff --git a/libavutil/hwcontext_vaapi.

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio

2023-10-27 Thread David Johansen
On Fri, Oct 27, 2023 at 1:33 AM Steven Liu wrote: > David Johansen 于2023年10月27日周五 12:03写道: > > > > > > > > LGTM > > > > > > > > > Thanks > > > Steven > > > > > > > I'm new to ffmpeg development so what&#x

Re: [FFmpeg-devel] [PATCH v3] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2023-10-27 Thread David Rosca
On Fri, Oct 27, 2023 at 7:14 PM Mark Thompson wrote: > > On 27/10/2023 11:00, David Rosca wrote: > > This allows some optimizations in driver, such as not having to read > > back the data if write-only mapping is requested. > > --- > > v3: Fix another warning > &g

[FFmpeg-devel] [PATCH v3] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2023-10-27 Thread David Rosca
This allows some optimizations in driver, such as not having to read back the data if write-only mapping is requested. --- v3: Fix another warning libavutil/hwcontext_vaapi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c

[FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2023-10-27 Thread David Rosca
This allows some optimizations in driver, such as not having to read back the data if write-only mapping is requested. --- v2: Fix warning libavutil/hwcontext_vaapi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 558fe

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2023-10-27 Thread David Rosca
This allows some optimizations in driver, such as not having to read back the data if write-only mapping is requested. --- libavutil/hwcontext_vaapi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 558fed94c6..c3ecd90077

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio

2023-10-26 Thread David Johansen
> > LGTM > > > Thanks > Steven > I'm new to ffmpeg development so what's the process for this to be merged? Do I need to do something or is it taken care of by a different process/someone else? Thanks, Dave ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [PATCH] Add init_program_date_time so start time can be specified

2023-10-26 Thread David Johansen
On Thu, Oct 26, 2023 at 7:12 PM Dave Johansen wrote: > --- > doc/muxers.texi | 3 +++ > libavformat/hlsenc.c | 41 + > 2 files changed, 28 insertions(+), 16 deletions(-) > I submitted a revised set of patches with additional features with this as th

Re: [FFmpeg-devel] [PATCH] Add init_program_date_time so start time can be specified

2023-10-17 Thread David Johansen
On Tue, Oct 17, 2023 at 7:09 PM wrote: > > > On 17 Oct 2023, at 17:51, Dave Johansen wrote: > > > --- > > doc/muxers.texi | 3 +++ > > libavformat/hlsenc.c | 7 ++- > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/doc/muxers.texi b/doc/muxers.texi > > index f6071

Re: [FFmpeg-devel] [PATCH v2] libavformat/data_uri: export mime_type of data urls

2023-09-05 Thread David Lou
ping On Tue, Jul 4, 2023 at 3:17 AM David Lou wrote: > Fix the fact that ffprobe no longer detects m3u8 in a data url correctly. > > For example, > > ffprobe > data:application/vnd.ap

Re: [FFmpeg-devel] [PATCH v2] lavc/vaapi_encode: Add filler_data option

2023-08-15 Thread David Rosca
On Tue, Aug 15, 2023 at 9:25 PM Mark Thompson wrote: > > On 15/08/2023 20:09, Mark Thompson wrote: > > On 15/08/2023 09:02, Xiang, Haihao wrote: > >> On Ma, 2023-08-07 at 09:27 +0200, David Rosca wrote: > >>> v2: Add description in encoders.texi > >>&

[FFmpeg-devel] [PATCH v3] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread David Rosca
Support for allocating frames with x2rgb10 format was added in c00264f5013, this adds support for importing DMA-BUFs. --- v2: fix #ifdef -> #if v3: annotate libavutil/hwcontext_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread David Rosca
On Wed, Aug 9, 2023 at 2:35 PM Rémi Denis-Courmont wrote: > > > > Le 9 août 2023 15:02:45 GMT+03:00, David Rosca a écrit : > >Support for allocating frames with x2rgb10 format was added > >in c00264f5013, this adds support for importing DMA-BUFs. > >--- >

[FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread David Rosca
Support for allocating frames with x2rgb10 format was added in c00264f5013, this adds support for importing DMA-BUFs. v2: Fix #ifdef -> #if --- libavutil/hwcontext_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 6c3a22

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Add vaapi_drm_format_map support for x2rgb10

2023-08-09 Thread David Rosca
Support for allocating frames with x2rgb10 format was added in c00264f5013, this adds support for importing DMA-BUFs. --- libavutil/hwcontext_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 6c3a227ddd..63544ce476 100644

[FFmpeg-devel] [PATCH v2] lavc/vaapi_encode: Add filler_data option

2023-08-07 Thread David Rosca
v2: Add description in encoders.texi --- doc/encoders.texi | 3 +++ libavcodec/vaapi_encode.c | 1 + libavcodec/vaapi_encode.h | 9 - 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 25d6b7f09e..f146942aa5 100644 --- a/doc/e

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: Add filler_data option

2023-08-05 Thread David Rosca
--- libavcodec/vaapi_encode.c | 1 + libavcodec/vaapi_encode.h | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index bfca315a7a..f161c76304 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -

Re: [FFmpeg-devel] [PATCH v1 6/6] lavc/vaapi_encode: Add VAAPI AV1 encoder

2023-07-17 Thread David Rosca
On Mon, Jul 10, 2023 at 9:40 AM Fei Wang wrote: > > Signed-off-by: Fei Wang > --- > Changelog |1 + > configure |3 + > doc/encoders.texi | 13 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c|1 + > li

[FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-07 Thread David Lemler
2-pass encode so the fifo is not filled at all; replaces original patch which drained the fifo after filling to prevent it from becoming full. Fixes the regression originally introduced in 5bda4ec6c3cb6f286bb40dee4457c3c26e0f78cb Co-authored-by: James Zern Signed-off-by: David Lemler

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-05 Thread David Lemler
> On 07/05/2023 2:16 PM CDT James Zern wrote: > > > On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > > > Hi, > > > > +ffmpeg-dev. I took the wrong email off the reply. > > > On Mon, Jul 3, 2023 at 10:08 PM David Lemler wrote: > > &

[FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-03 Thread David Lemler
, preventing it from overflowing. Problem is fixed by manually draining the fifo when performing the first pass of a 2-pass encode. Fixes the regression originally introduced in 5bda4ec6c3cb6f286bb40dee4457c3c26e0f78cb Signed-off-by: David Lemler --- libavcodec/libvpxenc.c | 6 ++ 1 file changed, 6

[FFmpeg-devel] [PATCH v2] libavformat/data_uri: export mime_type of data urls

2023-07-03 Thread David Lou
provides the mime_type hls detection requires. Thank you. Hopefully this patch doesn't get truncated by email again. Signed-off-by: David Lou --- libavformat/data_uri.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/libavformat/data_

[FFmpeg-devel] [PATCH] export mime_type of data urls

2023-07-02 Thread David Lou
provides the mime_type hls detection requires. Signed-off-by: David Lou --- libavformat/data_uri.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/libavformat/data_uri.c b/libavformat/data_uri.c index 28eb2b9e08..fdc1a2eef9 100644 --- a

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: add "quality" option to all encoders

2023-05-21 Thread David Rosca
Move "quality" option from h264_vaapi to common options. --- libavcodec/vaapi_encode.c | 3 +++ libavcodec/vaapi_encode.h | 8 +++- libavcodec/vaapi_encode_h264.c | 5 - 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_e

[FFmpeg-devel] [PATCH v3] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-17 Thread David Rosca
v3: pic_order_cnt steps by 2 --- libavcodec/vaapi_encode_h264.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index f15bcc6..de0951f 100644 --- a/libavcodec/vaapi_encode_h264.c +++ b/libavcodec/vaapi_e

Re: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-10 Thread David Rosca
On Mon, Jan 9, 2023 at 10:11 PM Mark Thompson wrote: > > On 09/01/2023 07:37, David Rosca wrote: > > On Mon, Jan 9, 2023 at 3:22 AM Xiang, Haihao wrote: > >> > >> On Do, 2022-12-29 at 22:20 +0100, David Rosca wrote: > >>> --- > >>> libavc

[FFmpeg-devel] [PATCH v2] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-10 Thread David Rosca
v2: frame_num steps by 2 --- libavcodec/vaapi_encode_h264.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index 7a6b54ab6f..8093c47179 100644 --- a/libavcodec/vaapi_encode_h264.c +++ b/libavcodec/vaapi_en

Re: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-08 Thread David Rosca
On Mon, Jan 9, 2023 at 3:22 AM Xiang, Haihao wrote: > > On Do, 2022-12-29 at 22:20 +0100, David Rosca wrote: > > --- > > libavcodec/vaapi_encode_h264.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/vaapi_encode_h26

[FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2022-12-29 Thread David Rosca
--- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index dd17be2..d6926c4 100644 --- a/libavcodec/vaapi_encode_h264.c +++ b/libavcodec/vaapi_encode_h264.c @@ -350,7 +350,7 @@ static

Re: [FFmpeg-devel] [PATCH] avfilter/af_alimiter: fix misbehavior when nb_channels != 2

2022-08-23 Thread David Flater
This is a friendly reminder. Cc: Paul B Mahol On 2022-08-14 21:53, David Flater wrote: > Some code in alimiter assumes that there are 2 channels, resulting in > clipping if the loudest channel is 3 or above and an out-of-bounds read if > the input is monophonic. Fix that in

[FFmpeg-devel] [PATCH] avfilter/af_alimiter: fix misbehavior when nb_channels != 2

2022-08-14 Thread David Flater
Some code in alimiter assumes that there are 2 channels, resulting in clipping if the loudest channel is 3 or above and an out-of-bounds read if the input is monophonic. Fix that in 2 places. Signed-off-by: David Flater --- libavfilter/af_alimiter.c | 23 +-- 1 file changed

[FFmpeg-devel] [PATCH] Added SO_KEEPALIVE in TCP sockets, so kernel keepalive settings manage timeouts in case of TCP hangs

2022-06-07 Thread David Maseda Neira
Signed-off-by: David Maseda Neira --- libavformat/network.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/network.c b/libavformat/network.c index 21e20b3e9a..0361346631 100644 --- a/libavformat/network.c +++ b/libavformat/network.c @@ -204,6 +204,12 @@ int ff_socket(int

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-07 Thread David Fletcher
ion of MDCT integrated into the native mp3 fixed point decoder I can test that on the ARMv4 hardware to see if the decoding bug is fixed. Certainly these are old chips but still lots of them around - a big part of them being useful is the assembly optimisations otherwise eve

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-04 Thread David Fletcher
> Andreas Rheinhardt wrote: > > David Fletcher: > > Following today's posts about help with submitting patches I realised I > > sent the libmad patch yesterday in the wrong format. Apologies, I was > > not familiar with the git format patches. > > > >

Re: [FFmpeg-devel] PATCH - wolfSSL TLS support

2022-05-03 Thread David Fletcher
aster branch. Best regards, David. From 3fc91e85b31ce0e5422f6ffe39d7d2287bce5939 Mon Sep 17 00:00:00 2001 From: David Fletcher Date: Tue, 3 May 2022 19:23:50 +0100 Subject: [PATCH] Patched to work with wolfSSL as a new TLS backend Signed-off-by: David Fletcher --- configure

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-03 Thread David Fletcher
eport about why this exists is at the following link, including a link to sample distorted audio from decoding an mp3 stream on ARMv4 hardware: https://trac.ffmpeg.org/ticket/9764 Best regards, David. From c7012e7743d245bfc737bd921341a462cd5c843c Mon Sep 17 00:00:00 2001 From: David Fletcher Date: T

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
gher alternative when the CPU can handle that. I've not tried --arch=generic. I'm cross-compiling on x86 targeting ARMv4 so the cross-compile will stop working properly if I take out --arch=armv4t. I'll do some further investigation and see if I can create ffm

Re: [FFmpeg-devel] PATCH - wolfSSL TLS support

2022-05-02 Thread David Fletcher
ter-b67572c). Best regards, David. diff -Nur ./ffmpeg-master-b67572c/configure ./ffmpeg-master-b67572c-wolfssl/configure --- ./ffmpeg-master-b67572c/configure 2022-05-02 16:10:22.0 +0100 +++ ./ffmpeg-master-b67572c-wolfssl/configure 2022-05-02 17:52:25.646019060 +0100 @@ -211,7 +211,7

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
can tell this is an issue affecting older ARM hardware, it cannot be reproduced on x86 hardware. I now have some additional ARM hardware with a more capable CPU which should help pin down the problem. Best regards, David. ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
On 2/5/2022, "Paul B Mahol" wrote: >Only patches for master are accepted. > >No more wrappers. > >Thanks. Hi Paul, Please find attached the libmad MP3 decoding patch against the master (ffmpeg-master-b67572c). I'm not sure what "No more wrappers" means?

[FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-01 Thread David Fletcher
optimised for very fast decoding on the ARMv4 CPU. More info about this application here: http://www.megapico.co.uk/sharpfin/mediaserver.html. Best regards, David. diff -Nur ./ffmpeg-5.0.1/configure ./ffmpeg-5.0.1-mad/configure --- ./ffmpeg-5.0.1/configure 2022-04-04 15:40:22.0 +0100

[FFmpeg-devel] PATCH - wolfSSL TLS support

2022-05-01 Thread David Fletcher
around an ARMv4 CPU and just 32MB RAM, for context more info about this application here: http://www.megapico.co.uk/sharpfin/mediaserver.html). Best regards, David. diff -Nur ./ffmpeg-5.0.1/configure ./ffmpeg-5.0.1-wolfssl/configure --- ./ffmpeg-5.0.1/configure 2022-04-04 15:40:22.0 +0100

Re: [FFmpeg-devel] [PATCH v2] avfilter/adelay: Add command support

2022-02-08 Thread David Lacko
Yes, during development I tested it streaming to rtmp and to file with a python client sending zmq requests. I Also tried changing the delay multiple times while running a single ffmpeg instance. Seemed to be working fine. so 5. 2. 2022 o 15:05 Paul B Mahol napísal(a): > Have this been tested? >

Re: [FFmpeg-devel] [PATCH v2] avfilter/adelay: Add command support

2022-02-03 Thread David Lacko
Is this being reviewed? št 20. 1. 2022 o 12:38 David Lacko napísal(a): > Adds command 'delays' to the adelay filter. > This command accepts same values as the option with one difference, to > apply > delay to all channels prefix 'all:' to the argument is accepted

[FFmpeg-devel] [PATCH v2] avfilter/adelay: Add command support

2022-01-20 Thread David Lacko
Adds command 'delays' to the adelay filter. This command accepts same values as the option with one difference, to apply delay to all channels prefix 'all:' to the argument is accepted. Signed-off-by: David Lacko --- libavfilter/af_adelay.c | 182

Re: [FFmpeg-devel] [PATCH] avfilter/adelay: Add command support

2022-01-20 Thread David Lacko
I would maybe even remove the av_freep(..) call, to keep the original buffer and the original delay. The user would only get an error code that the delay could not be changed. st 19. 1. 2022 o 20:14 Andreas Rheinhardt napísal(a): > David Lacko: > > Adds command 'delays' t

[FFmpeg-devel] [PATCH] avfilter/adelay: Add command support

2022-01-19 Thread David Lacko
Adds command 'delays' to the adelay filter. This command accepts same values as option with one difference, to apply delay to all channels prefix 'all:' to the arguments is accepted. Signed-off-by: David Lacko --- libavfilter/af_adelay.c | 183

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-14 Thread Dominguez Bonini, David
y), 0x87 (Nordig version) United Kingdom --> Private Data Specifier = 0x233A, LCN Descriptor Tag = 0x83 Rest of Europe + Most of the World --> Private Data Specifier = 0x0028, LCN Descriptor Tag = 0x83 Australia --> _Do_not_include_Private_data_specifier_descriptor_ , LCN Desc

[FFmpeg-devel] [PATCH 1/1] avutil silencing little build warning

2021-01-09 Thread David CARLIER
Hi here little patch for avutil. Kind regards. 0001-avutil-silencing-const-qualifier-warning.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit li

Re: [FFmpeg-devel] [PATCH v2] configure: fix the bigendian test

2020-11-14 Thread David Michael
On Sat, Nov 14, 2020 at 8:21 PM David Michael wrote: > On Sat, Nov 14, 2020 at 6:57 PM Carl Eugen Hoyos wrote: > > Am Sa., 14. Nov. 2020 um 20:16 Uhr schrieb David Michael > > : > > > On Sat, Nov 14, 2020 at 2:06 PM Carl Eugen Hoyos > > > wrote: > >

Re: [FFmpeg-devel] [PATCH v2] configure: fix the bigendian test

2020-11-14 Thread David Michael
On Sat, Nov 14, 2020 at 6:57 PM Carl Eugen Hoyos wrote: > Am Sa., 14. Nov. 2020 um 20:16 Uhr schrieb David Michael > : > > On Sat, Nov 14, 2020 at 2:06 PM Carl Eugen Hoyos wrote: > > > Am Sa., 14. Nov. 2020 um 18:22 Uhr schrieb David Michael > > > : > &

Re: [FFmpeg-devel] [PATCH v2] configure: fix the bigendian test

2020-11-14 Thread David Michael
On Sat, Nov 14, 2020 at 2:06 PM Carl Eugen Hoyos wrote: > Am Sa., 14. Nov. 2020 um 18:22 Uhr schrieb David Michael > : > > > > There are two issues: > > > > When build systems enable LTO in CFLAGS, the unused global integer > > does not make it into the co

[FFmpeg-devel] [PATCH v2] configure: fix the bigendian test

2020-11-14 Thread David Michael
, so the expected value will not be matched when its four bytes are split across two lines. Use the POSIX "-A n" option to disable printing input offsets and delete all newline characters to output continuous hex values to grep. Signed-off-by: David Michael --- configure | 5 +++-- 1 fi

Re: [FFmpeg-devel] [PATCH] configure: fix the bigendian test

2020-11-12 Thread David Michael
On Thu, Nov 12, 2020 at 2:56 AM Carl Eugen Hoyos wrote: > > Am 12.11.2020 um 00:41 schrieb David Michael : > >> On Wed, Nov 11, 2020 at 6:20 PM Carl Eugen Hoyos > >> wrote: > >>> Am Mi., 11. Nov. 2020 um 16:30 Uhr schrieb David Michael > >>> : &g

  1   2   >